| 41 Collaborator |
|
Jonathan Ellis , Brandon Williams , Aleksey Yeschenko , Benjamin Lerer , Štefan Miklošovič , Caleb Rackliffe , Alex Petrov , David Capwell , Andrés de la Peña , Paulo Motta , Branimir Lambov , Ekaterina Dimitrova , Mick Semb Wever , Berenguer Blasi , Jeff Jirsa , Chris Lohfink , Yifan Cai , Jacek Lewandowski , Mike Adamson , Francisco Guerrero , Maxim Muzafarov , Brad Schoening , Alex Sorokoumov , Jackson Fleming , Dimitar Dimitrov , Claude Warren , Ling Mao , Ningzi Zhan , Jaroslaw Grabowski , maoling , Tomek Łasica , Saranya Krishnakumar , Kan Maung , reviewed by Yifan Cai , cclive1601 , Suhel0328 , Stefania Alborghetti reviewed by Alex Sorokoumov , Mohammad Suhel , Henrik Ingo , Ata İlhan Köktürk , Amit Pawar |
| 12 Patch |
33 Review |
|
46b36f23cd865ee905742ff1d3da05fc8a467758,
9f18aab1dcbc40bb038fdcbad15c5bcd40909819,
a84698753344e767145a38fe5b68722caa9b1254,
0c7410a9da1281dd4f7a70a0668903ebb61bda58,
26c374da4f03e4a6b64e414805cd92f3eb0a36c6,
cc3e742c735daddc29d2fb90aac638c641463d39,
fc9efd6357fb4255174689b3c107b897254a7d2f,
49dfb805e9045c856181d6c2ac3b586b98d1a82a,
3f83396b76115a25b8189410c68775f87f31f8ac,
ee8b66da8ce3bdac0378f89159d8bd7e45a91363,
e773bbd9c6c52a2fedc127cb7ab77a1fdbeb63d2,
a7a0e7fe40cd375c647d2f5e56d04fd98963cff2 |
ff54fd5ffd03846326862951e2a6de9b52de01f6,
664ab193d6b4db387e5ed751c0dff1635015bf28,
5ab976d796471a1ecdf3596a148a3e4b8c1a982e,
8c4a58f035f0d52e36aaba5ae1cf04049ae3dd9c,
34fa4e279ac136d6e673be9540b9f322f414bf7f,
f0ea12c6d7683697d9a5ca0c99c2b7dc3bc11230,
50273d98e4780b57da37400752eab69e65cd41bc,
3259bea5332ed7d28fac8709c854adfee596dda5,
c26f2a3d6936d6ff2f14c6ab19b3727c2f86c941,
b59b832eba014e8d2fc93133cb3db41b509a1c26,
3b9881bfa65d2806e3918ba2c73198cb17c7071b,
26c374da4f03e4a6b64e414805cd92f3eb0a36c6,
6befb178aa0b7ad669f5c30e8b53fdd69a225a7a,
4093be5295e15a3665b7ca49e9527785f5893bd9,
725655dda2776fef35567496a6e331102eb7610d,
fd9f07dab863a93008180bcd1c6e207dee48e2a7,
7482d88f48662480c6879b4e500bcdf93c78e5e0,
5a82c04fd363030d712fb2935b6c591577ba25ec,
394d4b116868e4897ad3cc40833df801366a8916,
957eca2fb53477d56bdc9a97c612f1fbecfb5d41,
903857b4ef01b577db2cbcf3ea9a9b194dede21c,
ddbc52990f90473db729e96f22d2914e51a957a6,
c95e5a556709cf131ba074680585106559ff9511,
ae537abc6494564d7254a2126465522d86b44c1e,
1eccb2bc1ff69817b2fc8d16a4707b64d8b514e7,
5143bd81e82c35ce686dd40860ec2aebe30aaf22,
b72da02611b62436100fa3fd66537c68461bcaf5,
fad1f7457032544ab6a7b40c5d38ecb8b25899bb,
f16fb6765b8a3ff8f49accf61c908791520c0d6e,
b0aa44b27da97b37345ee6fafbee16d66f3b384f,
65c99bfc42015ccfbcbc8963b3fb3c2a761ea053,
db78e746d7e2fb9a2aa4c10e1322c6c5033f006b,
85f69cf394a8035280a741b117e7dfc71fb848c3 |
46b36f23cd865ee905742ff1d3da05fc8a467758 | Author: Ata İlhan Köktürk <atailhan2006@gmail.com>
| 2024-09-29 12:31:34+08:00
Explicitly localize strings to Locale.US for internal implementation
There is inconsistent usage of toLowerCase/toUpperCase methods in the codebase.
Somewhere we already use Locale.US, somewhere not. That might cause various issues in runtime
as shown in CASSANDRA-19953 ticket when an environment Cassandra runs in has different locale from expected.
In this patch, all such method calls explicitly set their locale to Locale.US. This patch also contains
a checkstyle rule which fails the compilation if toLowerCase or toUpperCase is used.
We prefer calls to methods in LocalizeString class which use US locale.
patch by Ata İlhan Köktürk; reviewed by Stefan Miklosovic, Brandon Williams for CASSANDRA-19953
Co-authored-by: Maxwell Guo <cclive1601@gmail.com>
Co-authored-by: Stefan Miklosovic <smiklosovic@apacheorg>
664ab193d6b4db387e5ed751c0dff1635015bf28 | Author: Suhel0328 <suhel.mohammad@ksolves.com>
| 2024-08-30 11:01:45+05:30
Add JSON and YAML output option to nodetool gcstats
patch by Mohammad Suhel; reviewed by Maxim Muzafarov, Maxwell Guo and Stefan Miklosovic for CASSANDRA-19771
a84698753344e767145a38fe5b68722caa9b1254 | Author: Maxwell Guo <cclive1601@gmail.com>
| 2024-08-14 17:10:25+08:00
Throw ConfigurationException when commitlog_disk_access_mode is direct but direct IO is not supported by filesystem
patch by Maxwell Guo; reviewed by Branimir Lambov, Stefan Miklosovic for CASSANDRA-19812
5ab976d796471a1ecdf3596a148a3e4b8c1a982e | Author: Stefan Miklosovic <smiklosovic@apache.org>
| 2024-07-18 15:14:53+02:00
Fix direct IO support always being evaluated to false upon the first start of a node
patch by Stefan Miklosovic; reviewed by Branimir Lambov, Maxwell Guo for CASSANDRA-19779
f0ea12c6d7683697d9a5ca0c99c2b7dc3bc11230 | Author: Jacek Lewandowski <lewandowski.jacek@gmail.com>
| 2023-12-12 12:36:23+01:00
Add a startup check to fail startup when using invalid configuration with certain Kernel and FS type
Patch by Jacek Lewandowski; reviewed by Maxwell Guo, Stefan Miklosovic for CASSANDRA-19196
b59b832eba014e8d2fc93133cb3db41b509a1c26 | Author: Stefan Miklosovic <smiklosovic@apache.org>
| 2023-10-26 12:21:44+02:00
Remove crc_check_chance from CompressionParams
patch by Stefan Miklosovic; reviewed by Maxwell Guo, Jacek Lewandowski, Branimir Lambov for CASSANDRA-18872
0c7410a9da1281dd4f7a70a0668903ebb61bda58 | Author: maxwellguo <cclive1601@gmail.com>
| 2023-10-25 08:25:42+02:00
Fix nodetool tablehistograms output to avoid printing repeated information and ensure at most two arguments
patch by Maxwell Guo; reviewed by Stefan Miklosovic and Brandon Williams for CASSANDRA-18955
3259bea5332ed7d28fac8709c854adfee596dda5 | Author: Amit Pawar <Amit.Pawar@amd.com>
| 2023-10-06 01:23:37+05:30
Enable Direct-IO feature for CommitLog files using Java native API's.
Patch by Amit Pawar and Jacek Lewandowski; reviewed by Branimir Lambov and Maxwell Guo for CASSANDRA-18464
Co-authored-by: Amit Pawar <Amit.Pawar@amd.com>
Co-authored-by: Jacek Lewandowski <lewandowski.jacek@gmail.com>
4093be5295e15a3665b7ca49e9527785f5893bd9 | Author: Brandon Williams <brandonwilliams@apache.org>
| 2023-09-08 09:02:55-05:00
Nodetool paxos-only repair is no longer incremental
Patch by Ningzi Zhan; reviewed by brandonwilliams, jlewandowski, and
Maxwell Guo for CASSANDRA-18466
725655dda2776fef35567496a6e331102eb7610d | Author: Brandon Williams <brandonwilliams@apache.org>
| 2023-09-08 09:02:55-05:00
Nodetool paxos-only repair is no longer incremental
Patch by Ningzi Zhan; reviewed by brandonwilliams, jlewandowski, and
Maxwell Guo for CASSANDRA-18466
34fa4e279ac136d6e673be9540b9f322f414bf7f | Author: Benjamin Lerer <b.lerer@gmail.com>
| 2023-08-17 10:03:00+02:00
Simplify the bind marker and Term logic
patch by Benjamin Lerer; reviewed by Andrés de la Peña, Ekaterina Dimitrova and Maxwell Guo for CASSANDRA-18813
The patch refactor the Term and Terms interfaces to simplify the logic.
* It removes the MultiItemTerminal and MultiColumnRaw interfaces
* Represents IN bind marker as Terms instead of having 2 different representations (a list of terms and a single MultiItemTerminal).
* Replaces the AbstractMarker hierachy by the Marker class
* It introduces a new MultiElementType that becomes a super class of all the CollectionTypes, TupleType, UserType and VectorType (standardizing the pack and unpack method name and their modifiers)
* It replaces the Value and DelayedValue implementations for the Lists, Sets, Maps, Tuples, UserTypes and Vectors classes by the MultiElements Value and DelayedValue classes.
fd9f07dab863a93008180bcd1c6e207dee48e2a7 | Author: Brandon Williams <brandonwilliams@apache.org>
| 2023-08-16 10:38:28-05:00
Add speculative retries to tablestats
Patch by brandonwilliams; reviewed by bereng and Maxwell Guo for
CASSANDRA-18767
903857b4ef01b577db2cbcf3ea9a9b194dede21c | Author: Stefan Miklosovic <smiklosovic@apache.org>
| 2023-06-29 17:30:02+02:00
Deprecate CloudstackSnitch and remove duplicate code in snitches
The patch also refactors existing cloud snitches to get rid of the duplicate code,
this is the logical follow-up of CASSANDRA-16555 where AbstractCloudMetadataServiceConnector was introduced.
patch by Stefan Miklosovic; reviewed by Jacek Lewandowski, Jackson Fleming and Maxwell Guo for CASSANDRA-18438
5a82c04fd363030d712fb2935b6c591577ba25ec | Author: Andrés de la Peña <a.penya.garcia@gmail.com>
| 2023-06-28 16:43:58+01:00
Add vector similarity functions
patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova and Maxwell Guo for CASSANDRA-18640
Co-authored-by: Jonathan Ellis <jbellis@datastax.com>
Co-authored-by: Andrés de la Peña <a.penya.garcia@gmail.com>
394d4b116868e4897ad3cc40833df801366a8916 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2023-06-21 17:29:05-05:00
Add support for index implementation selection via USING for CREATE INDEX
patch by Caleb Rackliffe; reviewed by Maxwell Guo and Andres de la Peña for CASSANDRA-18615
1eccb2bc1ff69817b2fc8d16a4707b64d8b514e7 | Author: ningzi.zhan <ningzi.zhan@datastax.com>
| 2023-06-08 14:59:17-07:00
Fix error message handling when trying to use CLUSTERING ORDER with non-clustering column
Patch by Ningzi Zhan and Tomasz Lasica; reviewed by brandonwilliams,
edimitrova and Maxwell Guo for CASSANDRA-17818
Co-Authored-By: Tomek Lasica <tomasz.lasica@datastax.com>
5143bd81e82c35ce686dd40860ec2aebe30aaf22 | Author: Jacek Lewandowski <lewandowski.jacek@gmail.com>
| 2023-05-26 09:29:37+02:00
Track the amount of read data per row
If an sstable is corrupted in a nasty way, we may read invalid cell sizes and try to read much more data for a row than we should. In rare scenarios this can lead even to OOMs.
This simple fix adds tracking and limiting the amount of data that is read per row. Row has its size stored in preamble which can be used as a limit. If the deserialization code tries to read more than that, it will simply fail with EOF which will prevent more serious problems later.
Patch by Jacek Lewandowski; reviewed by Berenguer Blasi and Maxwell Guo for CASSANDRA-18513
# Conflicts:
# src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java
b72da02611b62436100fa3fd66537c68461bcaf5 | Author: Andrés de la Peña <a.penya.garcia@gmail.com>
| 2023-05-24 19:20:35+01:00
Add guardrail for partition tombstones and deprecate compaction_tombstone_warning_threshold
patch by Andrés de la Peña; reviewed by Berenguer Blasi and Maxwell Guo for CASSANDRA-17194
b0aa44b27da97b37345ee6fafbee16d66f3b384f | Author: Andrés de la Peña <a.penya.garcia@gmail.com>
| 2023-05-09 12:07:29+01:00
Add guardrail for partition size and deprecate compaction_large_partition_warning_threshold
patch by Andrés de la Peña; reviewed by Berenguer Blasi and Maxwell-Guo for CASSANDRA-18500
fad1f7457032544ab6a7b40c5d38ecb8b25899bb | Author: Branimir Lambov <branimir.lambov@datastax.com>
| 2023-04-21 11:52:10+03:00
Rename the byte-comparable translation version to OSS50
Also fix some minor issues in ByteComparable.md
patch by Branimir Lambov and Jacek Lewandowski; reviewed by Caleb Rackliffe and Maxwell Guo for CASSANDRA-18398
65c99bfc42015ccfbcbc8963b3fb3c2a761ea053 | Author: Henrik Ingo <henrik.ingo@avoinelama.fi>
| 2023-04-19 17:34:23+03:00
Improve 'Not enough space for compaction' logging messages
Adds separate WARN level messages to the check itself in Directories.
patch by Henrik Ingo; reviewed by Mick Semb Wever, Brad Schoening, Claude Warren, Kan Maung, maxwellguo for CASSANDRA-18260
db78e746d7e2fb9a2aa4c10e1322c6c5033f006b | Author: Stefan Miklosovic <smiklosovic@apache.org>
| 2023-04-17 12:20:21+02:00
Do not remove SSTables when cause of FSReadError is OutOfMemoryError while using best_effort disk failure policy
patch by Stefan Miklosovic; reviewed by Brandon Williams and Maxwell Guo for CASSANDRA-18336
26c374da4f03e4a6b64e414805cd92f3eb0a36c6 | Author: Francisco Guerrero <frank.guerrero@gmail.com>
| 2023-03-09 12:11:20-08:00
Synchronize CQLSSTableWriter#build on the Schema.instance object
In this commit the `org.apache.cassandra.io.sstable.CQLSSTableWriter#build` method synchronizes on the
`Schema.instance` object (instead of the `CQLSSTableWriter.class`) to prevent concurrent schema operations
to fail when the offline tools also updates the schema.
For example, a table creation operation, which modifies the keyspace tables metadata, might end up
missing the update when a concurrent call to the `CQLSSTableWriter#build` method is accessing the
singleton Schema instance.
Patch by Francisco Guerrero, reviewed by Yifan Cai, Maxwell Guo, Alex Petrov for CASSANDRA-18317.
fc9efd6357fb4255174689b3c107b897254a7d2f | Author: maxwellguo <cclive1601@gmail.com>
| 2023-03-09 11:18:14+08:00
Add virtual table system_views.snapshots
patch by Maxwell Guo; reviewed by Stefan Miklosovic and Paulo Motta for CASSANDRA-18102
Co-authored-by: Stefan Miklosovic <smiklosovic@apache.org>
49dfb805e9045c856181d6c2ac3b586b98d1a82a | Author: maxwellguo <cclive1601@gmail.com>
| 2023-01-16 19:49:38+01:00
Add compaction_properties column to system.compaction_history table and nodetool compactionhistory command
patch by Maxwell Guo; reviewed by Stefan Miklosovic and Jacek Lewandowski for CASSANDRA-18061
f16fb6765b8a3ff8f49accf61c908791520c0d6e | Author: Jacek Lewandowski <lewandowski.jacek@gmail.com>
| 2023-01-03 18:17:13+01:00
Implementation of the trie-indexed SSTable format (BTI) as described in CEP-25.
Documentation in the included BTIFormat.md.
patch by Branimir Lambov and Jacek Lewandowski; reviewed by Caleb Rackliffe and Maxwell Guo for CASSANDRA-18398
957eca2fb53477d56bdc9a97c612f1fbecfb5d41 | Author: Branimir Lambov <branimir.lambov@datastax.com>
| 2022-11-29 09:41:23+02:00
Implementation of the Unified Compaction Strategy as described in CEP-26
The approach is documented in the included UnifiedCompactionStrategy.md.
Also included:
- Generalize prettyPrint to prettyPrintBinary (with 2^10 multiplier,
e.g. MiB) and prettyPrintDecimal (with 1000 multiplier, e.g. ms)
that cover the full range of double, and add a parseHumanReadable
method that can read both.
- CASSANDRA-18123: Fix invalid reuse of metadata collector during flushing
- Fix invalid token range splitting with non-unit weights
- Add flushSizeOnDisk metric
- Add ability to change compaction default in YAML
patch by Alex Sorokoumov, Branimir Lambov, Dimitar Dimitrov and Stefania Alborghetti
reviewed by Alex Sorokoumov, Jaroslaw Grabowski and Maxwell Guo for CASSANDRA-18397
e773bbd9c6c52a2fedc127cb7ab77a1fdbeb63d2 | Author: cclive1601 <cclive1601@gmail.com>
| 2022-01-21 11:07:37-08:00
Reject snapshot names with special character
Patch by Maxwell Guo, Saranya Krishnakumar and Francisco Guerrero; review
by Benjamin Lerer, Chris Lohfink, Stefan Miklosovic for CASSANDRA-15297
This commit also adds unit tests for the snapshot nodetool command.
Co-authored-by: Saranya Krishnakumar <saranya_k@apple.com>
Co-authored-by: Francisco Guerrero <francisco.guerrero@apple.com>