| 39 Collaborator |
|
Sam Tunnicliffe , Marcus Eriksson , Caleb Rackliffe , David Capwell , Brandon Williams , Mick Semb Wever , Branimir Lambov , Benjamin Lerer , Francisco Guerrero , Maxim Muzafarov , Jon Haddad , Ekaterina Dimitrova , Brad Schoening , Berenguer Blasi , Jordan West , Doug Rohrer , Dinesh Joshi , Andy Tolbert , Josh McKenzie , Chris Lohfink , Maxwell Guo , Dmitry Konstantinov , Arun Ganesh , Tiago Alves , Sunil Ramchandra Pawar , Mohammad Aburadeh , Maulin Vasavada , Cheng Wang , Bernardo Botella , maoling , manish-m-pillai , Zhongxiang Zheng , Suhel0328 , Mohammad Suhel , Manish Pillai , Ling Mao , James Hu , Cheng , Ata İlhan Köktürk |
| 22 Patch |
23 Review |
|
22af7a74cc79294199eb2272625c7eb80c8a8291,
75ec1ada7a40761e8b6eb948925c2dd2b116876e,
2ff41551a6897705a1fad842f9d550b019f6eadb,
f410b0fa0bc5adbb674654a0e27b02282971cfec,
8ea70cd1f0ba0a52cf4b19af9fac4c4289663270,
6093c2d99bd300eebe353ff05482924f38538e74,
181ddc0600cb7104ff0a9e01889f7cb013f7f802,
194e632ab3781cd10f8bc10f150ada526b186d5a,
46b36f23cd865ee905742ff1d3da05fc8a467758,
b9f900947adb254a395bb535a402c26e02c457a2,
63cad45bfc74c2d3a3705bc64398742e76bef136,
b43f077bc904bf1c95b62bfe9e295991ed0040b6,
b11909b611de811ed2f030848820a17c77df7013,
39b1c2df896fd6f17d2ce1863ee467d2cc069e24,
971747e3e25b7dec6a8ed50ed56ac0d14a3de6b1,
08b2e80aabd2b56e69fb6708dd1e579ede760ded,
b8e08840ee676a4d94f643221627689241e5f51f,
5ab976d796471a1ecdf3596a148a3e4b8c1a982e,
98a0b54c4025ef21aa3fb56f1962c4771e095652,
a5767a58343f7c954e2a5bdb36811f909483dd97,
a878adfc895b2e70b058f90ad5d207c710788c4d,
d336dda1123af0c272c69e42b6214577e30447e1 |
2ff41551a6897705a1fad842f9d550b019f6eadb,
bc40d3bb27cac7979867def92fe84e5fa5011155,
9131be9fa53e27b7e3bc332b613e00b73e9fffef,
d0c984fa32b81f3fe8058daf0fac2a3081775c9b,
b79f9dca873b551eee4bfae89d295e7b415a1366,
0b3c26ab0568656a9572bdf8cf58d8221e9ae550,
ff54fd5ffd03846326862951e2a6de9b52de01f6,
46b36f23cd865ee905742ff1d3da05fc8a467758,
c8854af03064ae894e4d69253723a1f99f001450,
69a6dc61a89aac96b9f9a2a7aef958452e14384e,
d939e40dfb59bebcf97b06b617e28031ff65fdc0,
2dea5c75882ee2caaaac0ae5b84f9d6b66c46b2e,
b9f900947adb254a395bb535a402c26e02c457a2,
664ab193d6b4db387e5ed751c0dff1635015bf28,
6111a60ad68725f1a318a2301788ec50023d4c85,
9da4bd412d1c7d34048241806cd572862b494648,
06a05ccde520925113edc92b28a4bd3b2bed2a29,
9f18aab1dcbc40bb038fdcbad15c5bcd40909819,
c56ba3b317e67f4530db1737169f5558969bd531,
a84698753344e767145a38fe5b68722caa9b1254,
c137958963d104829d2f493f92050cf438b24554,
25291ff3fd99f92cdb0a7d5d2125442282d42ff8,
26ff589f3da0a66c10c5ca16451a1c49fbb57ade |
75ec1ada7a40761e8b6eb948925c2dd2b116876e | Author: Stefan Miklosovic <smiklosovic@apache.org>
| 2024-12-16 23:18:36+01:00
Check presence of a snapshot in a case-insensitive manner on macOS platform to prevent hardlinking failures
When hardlinks are created for a snapshot with the name "snapshot"
and then we take a snapshot with the name "Snapshot", macOS platform thinks
that this was already hardlinked because its hardlinking implementation
does not seem to be case-sensitive. The fix consists of checking,
in a case-insensitive manner, if there is already such snapshot,
but only on macOS platform.
The patch also does not create empty directories for a given snapshot
prematurely before checking its presence so there are not dangling empty
directories in case of a failure.
patch by Stefan Miklosovic; reviewed by Bernardo Botella, Caleb Rackliffe for CASSANDRA-20146
22af7a74cc79294199eb2272625c7eb80c8a8291 | Author: manish-m-pillai <manishpillai64@gmail.com>
| 2024-12-13 13:23:12+01:00
Enable sorting of nodetool status output
patch by Manish Pillai; reviwed by Stefan Miklosovic, Bernardo Botella, Jordan West for CASSANDRA-20104
Co-authored-by: Stefan Miklosovic <smiklosovic@apache.org>
d0c984fa32b81f3fe8058daf0fac2a3081775c9b | Author: Dmitry Konstantinov <netudima@gmail.com>
| 2024-11-12 14:11:27+00:00
Change the resolution of AbstractCommitLogService#lastSyncedAt to nanos to be aligned with later comparisons
patch by Dmitry Konstantinov; reviewed by Branimir Lambov, Stefan Miklosovic for CASSANDRA-20074
b79f9dca873b551eee4bfae89d295e7b415a1366 | Author: Mohammad Aburadeh <mohmmad_aburadeh@hotmail.com>
| 2024-11-10 14:24:45+00:00
Log client address when detecting unknown exception in client networking
Patch by Mohammad Aburadeh, reviewed by brandonwilliams and smiklosovic
for CASSANDRA-20072
0b3c26ab0568656a9572bdf8cf58d8221e9ae550 | Author: Mohammad Aburadeh <mohmmad_aburadeh@hotmail.com>
| 2024-11-10 14:18:09+00:00
Log client address when detecting unknown exception in client networking
Patch by Mohammad Aburadeh, reviewed by brandonwilliams and smiklosovic
for CASSANDRA-20072
181ddc0600cb7104ff0a9e01889f7cb013f7f802 | Author: Stefan Miklosovic <smiklosovic@apache.org>
| 2024-11-04 17:11:19+01:00
Fix CQL in snapshot's schema which did not contained UDTs used as reverse clustering columns
patch by Stefan Miklosovic; reviewed by David Capwell for CASSANDRA-20036
69a6dc61a89aac96b9f9a2a7aef958452e14384e | Author: mck <mck@apache.org>
| 2024-10-11 16:48:34+02:00
Prevent CQLTester fuzz testing from using illegal commitlog_disk_access_mode combinations
Also provide a clearer message from DatabaseDescriptor about the failing combination
patch by Mick Semb Wever; reviewed by David Capwell, Štefan Miklošovič for CASSANDRA-19812
46b36f23cd865ee905742ff1d3da05fc8a467758 | Author: Ata İlhan Köktürk <atailhan2006@gmail.com>
| 2024-09-29 12:31:34+08:00
Explicitly localize strings to Locale.US for internal implementation
There is inconsistent usage of toLowerCase/toUpperCase methods in the codebase.
Somewhere we already use Locale.US, somewhere not. That might cause various issues in runtime
as shown in CASSANDRA-19953 ticket when an environment Cassandra runs in has different locale from expected.
In this patch, all such method calls explicitly set their locale to Locale.US. This patch also contains
a checkstyle rule which fails the compilation if toLowerCase or toUpperCase is used.
We prefer calls to methods in LocalizeString class which use US locale.
patch by Ata İlhan Köktürk; reviewed by Stefan Miklosovic, Brandon Williams for CASSANDRA-19953
Co-authored-by: Maxwell Guo <cclive1601@gmail.com>
Co-authored-by: Stefan Miklosovic <smiklosovic@apacheorg>
b43f077bc904bf1c95b62bfe9e295991ed0040b6 | Author: Stefan Miklosovic <smiklosovic@apache.org>
| 2024-09-26 14:32:40+02:00
Make TableParams.Serializer set allowAutoSnapshots and incrementalBackups
patch by Stefan Miklosovic; reviwed by Marcus Eriksson, David Capwell for CASSANDRA-19954
2dea5c75882ee2caaaac0ae5b84f9d6b66c46b2e | Author: Tiago Alves <tiago.alves@datastax.com>
| 2024-09-24 10:27:40+01:00
Use ParameterizedClass for all auth-related implementations
Uses ParameterizedClass for IAuthorizer, INetworkAuthorizer, and
IRoleManager implementations enabling those to be configurable from
parameters specified directly in cassandra.yaml.
Opportunistically makes consistent the initialization and setting of
all auth-related implementations and removes code duplication.
Notes:
* IInternodeAuthenticator implementations are expected to be set as
default directly in DatabaseDescriptor instead of done via
AuthConfig.applyAuth(). This is assumed in tests and client logic.
For instance ReconnectableSnitchHelperTest fetches this authenticator
before calling daemonInitialize(). Also, BulkLoader fetches this
directly when creating an outbound connection.
* Changing this behavior in BulkLoader causes a cascade of changes.
First, one would need to add AuthConfig.applyAuth() directly in
clientInitialize() and then would need to enable all the additional
classes that this change causes. Long term this might be justified
as if we're depending on the auth logic to be properly set. However,
in the context of this change it was decided to postpone further
changes.
* Standardize auth-related configurations by using a short-form with
the class name instead of the full qualified class name containing
the package name.
patch by Tiago Alves; reviewed by Mick Semb Wever, Stefan Miklosovic for CASSANDRA-19946
9da4bd412d1c7d34048241806cd572862b494648 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2024-09-23 12:04:34-05:00
Ensure that RFP queries potentially stale replicas even with only key columns in the row filter
patch by Caleb Rackliffe; reviewed by Stefan Miklosovic for CASSANDRA-19938
06a05ccde520925113edc92b28a4bd3b2bed2a29 | Author: Sunil Ramchandra Pawar <pawar_sr@apple.com>
| 2024-09-20 18:56:47+05:30
Fix indexing of a frozen collection that is the clustering key and reversed
patch by Sunil Ramchandra Pawar; reviewed by David Capwell, Stefan Miklosovic for CASSANDRA-19889
39b1c2df896fd6f17d2ce1863ee467d2cc069e24 | Author: Stefan Miklosovic <smiklosovic@apache.org>
| 2024-09-16 15:00:37+02:00
Emit error when altering a table with non-frozen UDTs with nested non-frozen collections the same way as done upon table creation
patch by Stefan Miklosovic; reviewed by Maxim Muzafarov for CASSANDRA-19925
971747e3e25b7dec6a8ed50ed56ac0d14a3de6b1 | Author: Stefan Miklosovic <smiklosovic@apache.org>
| 2024-09-11 00:09:31+02:00
Make configuration entries in memtable section order-independent
patch by Stefan Miklosovic; reviewed by David Capwell for CASSANDRA-19906
Co-authored-by: David Capwell <dcapwell@apache.org>
664ab193d6b4db387e5ed751c0dff1635015bf28 | Author: Suhel0328 <suhel.mohammad@ksolves.com>
| 2024-08-30 11:01:45+05:30
Add JSON and YAML output option to nodetool gcstats
patch by Mohammad Suhel; reviewed by Maxim Muzafarov, Maxwell Guo and Stefan Miklosovic for CASSANDRA-19771
c56ba3b317e67f4530db1737169f5558969bd531 | Author: Dmitry Konstantinov <netudima@gmail.com>
| 2024-08-27 21:21:07+01:00
Improve accuracy of memtable heap usage tracking
Fix estimateRowOverhead in Memtable: ByteBuffer in Partition key was not counted
Fix non-counted size of "columns" field in Columns.unsharedHeapSize
BTree.sizeOfStructureOnHeap wrongly reported a non-zero size for EMPTY_LEAF shared constant value
Fix MemtableSizeTest flakeness by not measuring of allocator and ColumnFamilyStore/Keyspace
Patch by Dmitry Konstantinov; reviewed by Branimir Lambov, Stefan Miklosovic for CASSANDRA-17298
a84698753344e767145a38fe5b68722caa9b1254 | Author: Maxwell Guo <cclive1601@gmail.com>
| 2024-08-14 17:10:25+08:00
Throw ConfigurationException when commitlog_disk_access_mode is direct but direct IO is not supported by filesystem
patch by Maxwell Guo; reviewed by Branimir Lambov, Stefan Miklosovic for CASSANDRA-19812
c137958963d104829d2f493f92050cf438b24554 | Author: Dmitry Konstantinov <netudima@gmail.com>
| 2024-08-07 20:46:16+01:00
Minor improvements in Cassandra shutdown and startup logs
To improve a DBA experience the following log messages would be nice to add/adjust:
on shutdown: an explicit message at the end of Cassandra shutdown
on startup:
- print the time spent to load prepared statements
- print the time spent to load repair session information and the number of loaded session records
- print the time spent to apply commit log
Patch by Dmitry Konstantinov; reviewed by Štefan Miklošovič and Brad Schoening for CASSANDRA-19818
5ab976d796471a1ecdf3596a148a3e4b8c1a982e | Author: Stefan Miklosovic <smiklosovic@apache.org>
| 2024-07-18 15:14:53+02:00
Fix direct IO support always being evaluated to false upon the first start of a node
patch by Stefan Miklosovic; reviewed by Branimir Lambov, Maxwell Guo for CASSANDRA-19779
a5767a58343f7c954e2a5bdb36811f909483dd97 | Author: Stefan Miklosovic <smiklosovic@apache.org>
| 2024-07-03 13:49:42+02:00
Fix schema.cql created by a snapshot after dropping more than one column
patch by Stefan Miklosovic; reviewed Benjamin Lerer, Francisco Guerrero for CASSANDRA-19747
26ff589f3da0a66c10c5ca16451a1c49fbb57ade | Author: maoling <maoling@apache.org>
| 2024-06-12 23:14:00+08:00
Expose current compaction throughput in nodetool
patch by Ling Mao; reviewed by Jon Haddad, Stefan Miklosovic for CASSANDRA-13890
Co-authored-by: Jon Haddad <jon@jonhaddad.com>
b9f900947adb254a395bb535a402c26e02c457a2 | Author: Arun Ganesh <20590666+arkn98@users.noreply.github.com>
| 2024-06-03 15:14:17-07:00
Add total space used for a keyspace to nodetool tablestats
patch by Arun Ganesh; reviewed by Stefan Miklosovic, Brad Schoening for CASSANDRA-19671
Co-authored-by: Stefan Miklosovic <smiklosovic@apache.org>
b8e08840ee676a4d94f643221627689241e5f51f | Author: Stefan Miklosovic <smiklosovic@apache.org>
| 2024-01-02 15:06:55+01:00
Do not spam log with SSLExceptions
patch by Stefan Miklosovic; reviewed by Caleb Rackliffe for CASSANDRA-18839
Co-authored-by: James Hu <jhudson15869@gmail.com>
08b2e80aabd2b56e69fb6708dd1e579ede760ded | Author: Stefan Miklosovic <smiklosovic@apache.org>
| 2023-09-06 22:36:14+02:00
Warn about unqualified prepared statement only if it is select or modification statement
patch by Stefan Miklosovic; reviewed by Benjamin Lerer for CASSANDRA-18322
8ea70cd1f0ba0a52cf4b19af9fac4c4289663270 | Author: Josh McKenzie <jmckenzie@apache.org>
| 2022-08-11 14:02:27-04:00
Backport of CASSANDRA-17812: Rate-limit new client connection auth setup to avoid overwhelming bcrypt
This backport differs from CASSANDRA-17812 in such a way that by default the number
of auth request threads is set to 0. That will route all requests to request executor as before this change.
The patch in 5.0 and later sets the default number of auth request threads to 4.
patch by Josh McKenzie; reviewed by Chris Lohfink for CASSANDRA-20057
Co-authored-by: Stefan Miklosovic <smiklosovic@apache.org>
2ff41551a6897705a1fad842f9d550b019f6eadb | Author: Zhongxiang Zheng <zzheng@yahoo-corp.jp>
| 2016-06-30 18:17:49+09:00
Enable JMX server configuration to be in cassandra.yaml
patch by Zhongxiang Zheng; reviewed by Stefan Miklosovic, Maulin Vasavada, Cheng Wang, Jordan West for CASSANDRA-11695
Co-authored-by: Stefan Miklosovic <smiklosovic@apache.org>
Co-authored-by: Sam Tunnicliffe <samt@apache.org>