Maxim Muzafarov test_and_ci all time


 27 Collaborator
Brandon Williams , Sam Tunnicliffe , Alex Petrov , Mick Semb Wever , Štefan Miklošovič , Ekaterina Dimitrova , David Capwell , Caleb Rackliffe , Josh McKenzie , Branimir Lambov , Jon Meredith , Jacek Lewandowski , Zhao Yang , Chris Lohfink , Aleksei Zotov , Maxwell Guo , Claude Warren , Bernardo Botella , Jakub Zytka , Aleksandr Volochnev , Artem Chekunov , Aleks Volochnev , ayushis , Suhel0328 , Mohammad Suhel , Ayushi Singh , Andrés de la Peña García

 12 Patch  23 Review
ad4ad5ef5aa9a432d7126140fc9f4fedcd20411c, 8619010cdca8bce471754e4fbeb861f036535007, 2e7def7626fe299318e0cf4c2bf8138a6c31e149, 81a2cb782eed932961b0c89fbd40199c7269c662, 07df26778b01a00c1f5770c8cf133ce4c2829533, 269285213d12f9e549f735b93f77d08d36dbbfb8, f51d9ecbe36525893e3bab4108abaa84abbfc772, 4f232324ba030ff640a790b4029d9f722e96872b, f6509086483983176f82a4b72912927693b6e573, b3256f5bf22c99a8f5410634dd41ca1643a34c1c, 2e7def7626fe299318e0cf4c2bf8138a6c31e149, 3b66dcc870e8d929d81055c95124caf2d36f0ac4 f5df4b219e063cb24b9cc0c22b6e614506b8d903, f7c11bdcd458b2eb0769a4b76698fb6382cdab3a, 664ab193d6b4db387e5ed751c0dff1635015bf28, 39b1c2df896fd6f17d2ce1863ee467d2cc069e24, f7c11bdcd458b2eb0769a4b76698fb6382cdab3a, 154ef814bd2b7cf5290bf5f94484dd077b442449, 64e2a4e9a3e209cc6153c0e348ba7f3d56a7016f, 4d61359c214fbe8ee8b8edc822cad79f98b337bc, 7a2bfdc56d2441d27b467614c2b25fe915ae34bf, 69f5df0b00cc822f41823901956aeff9fcdd9dbb, 269285213d12f9e549f735b93f77d08d36dbbfb8, 987d03c142f086f05857f9c6a2eafef7e157eb15, b9f614f7e56b8b12149cb51f89558d0568901853, 3658ba58c7d0be0803cbd7480c73d46705c3372d, 4bbfd64fcd7ff208c8cc3833ffff00aea015d2a8, 6ab45971fc651f78c8748f80e3cd6d4a1b6dbc50, 3bf9bd6831ae23670f0113b5d858e4dc00448ce5, f5df4b219e063cb24b9cc0c22b6e614506b8d903, ffe4d85df23e22be78b8047e91e4a065c5c73c06, b9f614f7e56b8b12149cb51f89558d0568901853, 0a8fea03d2f66463478ec4a49387bfb035dd403a, 4b7b860e7b4351cb72ae7f28908aebce644a89cd, d1a9bb3295aabc7df4ad0b1dce29bdda9acc5fe7

ad4ad5ef5aa9a432d7126140fc9f4fedcd20411c | Author: Maxim Muzafarov <maxmuzaf@gmail.com>
 | 2024-09-30 15:42:55+02:00

    Fix race condition in DecayingEstimatedHistogramReservoir during rescale
    
    patch by Maxim Muzafarov; reviewed by Caleb Rackliffe for CASSANDRA-19365
    
    Co-authored-by: Jakub Zytka <jakub.zytka@datastax.com>

39b1c2df896fd6f17d2ce1863ee467d2cc069e24 | Author: Stefan Miklosovic <smiklosovic@apache.org>
 | 2024-09-16 15:00:37+02:00

    Emit error when altering a table with non-frozen UDTs with nested non-frozen collections the same way as done upon table creation
    
    patch by Stefan Miklosovic; reviewed by Maxim Muzafarov for CASSANDRA-19925

664ab193d6b4db387e5ed751c0dff1635015bf28 | Author: Suhel0328 <suhel.mohammad@ksolves.com>
 | 2024-08-30 11:01:45+05:30

    Add JSON and YAML output option to nodetool gcstats
    
    patch by Mohammad Suhel; reviewed by Maxim Muzafarov, Maxwell Guo and Stefan Miklosovic for CASSANDRA-19771

8619010cdca8bce471754e4fbeb861f036535007 | Author: Maxim Muzafarov <maxmuzaf@gmail.com>
 | 2024-04-30 22:15:52+02:00

    Reduce heap usage occupied by the metrics
    
    patch by Maxim Muzafarov; reviewed by Caleb Rackliffe for CASSANDRA-19567

2e7def7626fe299318e0cf4c2bf8138a6c31e149 | Author: Maxim Muzafarov <maxmuzaf@gmail.com>
 | 2024-04-03 17:07:14+02:00

    Expose all dropwizard metrics in virtual tables
    
    patch by Maxim Muzafarov; reviewed by Chris Lohfink, Stefan Miklosovic for CASSANDRA-14572

2e7def7626fe299318e0cf4c2bf8138a6c31e149 | Author: Maxim Muzafarov <maxmuzaf@gmail.com>
 | 2024-04-03 17:07:14+02:00

    Expose all dropwizard metrics in virtual tables
    
    patch by Maxim Muzafarov; reviewed by Chris Lohfink, Stefan Miklosovic for CASSANDRA-14572

154ef814bd2b7cf5290bf5f94484dd077b442449 | Author: Claude Warren <claude.warren@aiven.io>
 | 2024-04-03 15:53:24+02:00

    Ensured that PropertyFileSnitchTest do not overwrite cassandra-toploogy.properties
    
    patch by Claude Warren; reviewed by Brandon Williams, Maxim Muzafarov for CASSANDRA-19502

3b66dcc870e8d929d81055c95124caf2d36f0ac4 | Author: Maxim Muzafarov <maxmuzaf@gmail.com>
 | 2024-03-25 19:02:06+01:00

    Add system_metrics keyspace to default keyspaces list
    
    patch by Maxim Muzafarov; reviewed by Chris Lohfink, Stefan Miklosovic for CASSANDRA-14572

81a2cb782eed932961b0c89fbd40199c7269c662 | Author: Maxim Muzafarov <maxmuzaf@gmail.com>
 | 2024-03-06 14:54:02+01:00

    Register the measurements of the bootstrap process as Dropwizard metrics
    
    patch by Maxim Muzafarov; reviewed by Stefan Miklosovic for CASSANDRA-19447

64e2a4e9a3e209cc6153c0e348ba7f3d56a7016f | Author: Aleksei Zotov <azotcsit@gmail.com>
 | 2024-01-25 17:27:08+01:00

    Refactor structure of caching metrics and expose auth cache metrics via JMX
    
    patch by Aleksei Zotov; reviewed by Stefan Miklosovic, Maxim Muzafarov for CASSANDRA-17062
    
    Co-authored-by: Sam Tunnicliffe <samt@apache.org>
    Co-authored-by: Stefan Miklosovic <smiklosovic@apache.org>

7a2bfdc56d2441d27b467614c2b25fe915ae34bf | Author: Jacek Lewandowski <lewandowski.jacek@gmail.com>
 | 2023-11-07 16:18:54+01:00

    Fix incorrect seeking through the sstable iterator by IndexState
    
    Patch by Jacek Lewandowski; reviewed by Alex Petrov and Maxim Muzafarov for CASSANDRA-18932

69f5df0b00cc822f41823901956aeff9fcdd9dbb | Author: David Capwell <dcapwell@apache.org>
 | 2023-10-30 10:32:30-07:00

    Add metrics and logging to repair retries
    
    patch by David Capwell; reviewed by Caleb Rackliffe, Maxim Muzafarov for CASSANDRA-18952

07df26778b01a00c1f5770c8cf133ce4c2829533 | Author: Maxim Muzafarov <maxmuzaf@gmail.com>
 | 2023-10-20 11:01:54+02:00

    Change the checksum algorithm SAI-related files use from CRC32 to CRC32C
    
    patch by Maxim Muzafarov; reviewed by Caleb Rackliffe and Zhao Yang for CASSANDRA-18836

0a8fea03d2f66463478ec4a49387bfb035dd403a | Author: Stefan Miklosovic <smiklosovic@apache.org>
 | 2023-10-13 12:53:36+02:00

    CASSANDRA-18742 followup
    
    patch by Stefan Miklosovic; reviewed by Maxim Muzafarov, Brandon Williams for CASSANDRA-18742

269285213d12f9e549f735b93f77d08d36dbbfb8 | Author: Stefan Miklosovic <smiklosovic@apache.org>
 | 2023-10-11 20:30:55+02:00

    Add versions into Deprecated annotation
    
    patch by Stefan Miklosovic; reviewed by Maxim Muzafarov, Brandon Williams for CASSANDRA-18912
    
    Co-authored-by: Maxim Muzafarov <maxmuzaf@gmail.com>

3658ba58c7d0be0803cbd7480c73d46705c3372d | Author: Jacek Lewandowski <lewandowski.jacek@gmail.com>
 | 2023-09-20 11:44:41+02:00

    JMH improvements - faster build and async profiler
    
    - Don't create uber jar for microbenchmarks
    - Add async profiler to jmh tests
    - Benchmark classes names validation
    - Add jmh.args property to make it possible passing extra args to JMH
    - Add missing test/anttasks to idea configuration
    
    Patch by Jacek Lewandowski; reviewed by Branimir Lambov, Maxim Muzafarov, Stefan Miklosovic for CASSANDRA-18871

f51d9ecbe36525893e3bab4108abaa84abbfc772 | Author: Maxim Muzafarov <maxmuzaf@gmail.com>
 | 2023-09-19 14:38:09+02:00

    Upgrade Dropwizard Metrics to 4.2.19
    
    patch by Maxim Muzafarov; reviewed by Ekaterina Dimitrova and Stefan Miklosovic for CASSANDRA-14667

d1a9bb3295aabc7df4ad0b1dce29bdda9acc5fe7 | Author: Stefan Miklosovic <smiklosovic@apache.org>
 | 2023-09-18 15:46:53+02:00

    CASSANDRA-18742 alignement
    
    patch by Stefan Miklosovic; reviewed by Maxim Muzafarov, Brandon Williams for CASSANDRA-18742

b9f614f7e56b8b12149cb51f89558d0568901853 | Author: Stefan Miklosovic <smiklosovic@apache.org>
 | 2023-09-18 14:45:03+02:00

    Remove deprecated properties in CompressionParams
    
    This patch removes deprecated chunk_length_kb and sstable_compression in favor of
    chunk_length_in_kb and class parameters.
    
    The only deprecated compression parameter left, crc_check_chance (which is configurable outside
    of compression parameters as a standalone table parameter) is meant to be treated separately.
    
    patch by Stefan Miklosovic; reviewed by Maxim Muzafarov and Brandon Williams for CASSANDRA-18742

b9f614f7e56b8b12149cb51f89558d0568901853 | Author: Stefan Miklosovic <smiklosovic@apache.org>
 | 2023-09-18 14:45:03+02:00

    Remove deprecated properties in CompressionParams
    
    This patch removes deprecated chunk_length_kb and sstable_compression in favor of
    chunk_length_in_kb and class parameters.
    
    The only deprecated compression parameter left, crc_check_chance (which is configurable outside
    of compression parameters as a standalone table parameter) is meant to be treated separately.
    
    patch by Stefan Miklosovic; reviewed by Maxim Muzafarov and Brandon Williams for CASSANDRA-18742

4b7b860e7b4351cb72ae7f28908aebce644a89cd | Author: Mick Semb Wever <mck@apache.org>
 | 2023-09-13 09:43:46+02:00

    Add @pytest.mark.no_vnodes to upgrade_tests/cql_tests that are using an ordered partitioner
    
    And fix storage_engine_upgrade_test.py and upgrade_through_versions_test.py  so node2 has same dc as node1
    
     patch by Mick Semb Wever; reviewed by Brandon Williams, Ekaterina Dimitrova, Josh McKenzie, Maxim Muzafarov for CASSANDRA-18832

987d03c142f086f05857f9c6a2eafef7e157eb15 | Author: Mick Semb Wever <mck@apache.org>
 | 2023-09-09 21:14:10+02:00

    Fixes for in-tree scripts: offline mode, maybe-build for fqltool-test, jvm-dtest-upgrade
    
     - jvm-dtest-upgrade script running in ci-cassandra.a.o (needs default bash)
     - add offline mode (to avoid `git fetch` before building dtest-jars on other branches),
     - avoid rebuilding in fqltool-test target, as is standard for test targets.
     - python detection and override
     - FileTest cleanup (tmp directory was left unreadable and undeletable)
     - reuse ~/.ccm (like normal)
     - remove support for python 3.6
     - remove docker volumes in image (they are added at run time)
     - remove superfluousjava version debug
     – extra mount for build/tmp as hack to prevent buggy hardlinks on overlay
    
     patch by Mick Semb Wever; reviewed by Brandon Williams, Ekaterina Dimitrova, Josh McKenzie, Maxim Muzafarov for CASSANDRA-18665

4d61359c214fbe8ee8b8edc822cad79f98b337bc | Author: Jacek Lewandowski <lewandowski.jacek@gmail.com>
 | 2023-08-22 10:47:29+02:00

    CASSANDRA-18785: Add support for Sonar analysis
    
    Patch by Jacek Lewandowski; reviewed by Brandon Williams, Maxim Muzafarov, Michael Semb Wever, Stefan Miklosovic for CASSANDRA-18785

4f232324ba030ff640a790b4029d9f722e96872b | Author: Maxim Muzafarov <maxmuzaf@gmail.com>
 | 2023-08-01 22:01:55+02:00

    Fix HandshakeTest initiated twice for the outbound connection
    
    patch by Maxim Muzafarov; reviewed by Jon Meredith and Mchael Semb Wever for CASSANDRA-18704

6ab45971fc651f78c8748f80e3cd6d4a1b6dbc50 | Author: ayushis <ayushis@netflix.com>
 | 2023-07-10 15:21:07-07:00

    Introduce pluggable crypto providers and default to Amazon Corretto Crypto Provider
    
    patch by Ayushi Singh; reviewed by Stefan Miklosovic, Michael Semb Wever and Maxim Muzafarov for CASSANDRA-18624
    
    Co-authored-by: Stefan Miklosovic <smiklosovic@apache.org>

f7c11bdcd458b2eb0769a4b76698fb6382cdab3a | Author: Mick Semb Wever <mck@apache.org>
 | 2023-06-13 16:07:07+02:00

    Standalone Jenkinsfile
    
     – ensure test file paths, and their suite names are unique (the latter was broken for cqlshlib and python dtests)
     – removal of properties and system-out in test xml happens in CassandraXMLJUnitResultFormatter
     – new jenkins agent labels and introduce agents sizes
     - ci_summary.html generation script, ref work submitted in apache/cassandra-builds#99
     – fix for stress-test and fqltool-test running on small
     - ant generate-test-report is limited to only running on individual test types (ci_parser.py provides ci_summary.html for the overview now)
     - each cell has a single retry, and the retry will happen on a different agent
     - on ci-cassandra the summary stage happens on the builtin, bc copyArtifacts on 15k+ files takes many hours otherwise
     - test-burn only needs two splits
     - dependency-check is disabled from the lint target until CASSANDRA-19213
     - add $DEBUG env var to in-tree scripts, turns on bash debug
     - fix FBUtilities' handling of gcp cos_containerd (kernel version comes with a trailing '+' character)
    
     patch by Aleks Volochnev, Mick Semb Wever; reviewed by Aleksandr Volochnev, Josh McKenzie, Maxim Muzafarov, Stefan Miklosovic for CASSANDRA-18594
    
    Co-authored-by: Aleksandr Volochnev <a.volochnev@gmail.com>
    Co-authored-by: Mick Semb Wever <mck@apache.org>
    Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
    Co-authored-by: Artem Chekunov <artem.v.chekunov@gmail.com>

f7c11bdcd458b2eb0769a4b76698fb6382cdab3a | Author: Mick Semb Wever <mck@apache.org>
 | 2023-06-13 16:07:07+02:00

    Standalone Jenkinsfile
    
     – ensure test file paths, and their suite names are unique (the latter was broken for cqlshlib and python dtests)
     – removal of properties and system-out in test xml happens in CassandraXMLJUnitResultFormatter
     – new jenkins agent labels and introduce agents sizes
     - ci_summary.html generation script, ref work submitted in apache/cassandra-builds#99
     – fix for stress-test and fqltool-test running on small
     - ant generate-test-report is limited to only running on individual test types (ci_parser.py provides ci_summary.html for the overview now)
     - each cell has a single retry, and the retry will happen on a different agent
     - on ci-cassandra the summary stage happens on the builtin, bc copyArtifacts on 15k+ files takes many hours otherwise
     - test-burn only needs two splits
     - dependency-check is disabled from the lint target until CASSANDRA-19213
     - add $DEBUG env var to in-tree scripts, turns on bash debug
     - fix FBUtilities' handling of gcp cos_containerd (kernel version comes with a trailing '+' character)
    
     patch by Aleks Volochnev, Mick Semb Wever; reviewed by Aleksandr Volochnev, Josh McKenzie, Maxim Muzafarov, Stefan Miklosovic for CASSANDRA-18594
    
    Co-authored-by: Aleksandr Volochnev <a.volochnev@gmail.com>
    Co-authored-by: Mick Semb Wever <mck@apache.org>
    Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
    Co-authored-by: Artem Chekunov <artem.v.chekunov@gmail.com>

ffe4d85df23e22be78b8047e91e4a065c5c73c06 | Author: Bernardo Botella Corbi <contacto@bernardobotella.com>
 | 2023-05-18 16:21:16-07:00

    Use WithProperties in try-with-resources to improve properties handling in tests
    
    patch by Bernardo Botella Corbi; reviewed by Stefan Miklosovic, Maxim Muzafarov and Jacek Lewandowski for CASSANDRA-18453

f6509086483983176f82a4b72912927693b6e573 | Author: Maxim Muzafarov <maxmuzaf@gmail.com>
 | 2023-05-03 12:15:37+02:00

    Moved system properties and envs to CassandraRelevantProperties and CassandraRelevantEnv respectively
    
    Patch by Maxim Muzafarov; reviewed by Stefan Miklosovic and Jacek Lewandowski for CASSANDRA-17797

4bbfd64fcd7ff208c8cc3833ffff00aea015d2a8 | Author: Mick Semb Wever <mck@apache.org>
 | 2023-03-09 14:18:44+01:00

    Lift MessagingService.minimum_version to 40
    
     patch by Mick Semb Wever; reviewed by Andrés de la Peña García, Maxim Muzafarov for CASSANDRA-18314

3bf9bd6831ae23670f0113b5d858e4dc00448ce5 | Author: Mick Semb Wever <mck@apache.org>
 | 2023-03-09 14:11:19+01:00

    Remove legacy 3.0/3.11 buffer pool metrics
    
     patch by Mick Semb Wever; reviewed by Brandon Williams, Maxim Muzafarov for CASSANDRA-18313

b3256f5bf22c99a8f5410634dd41ca1643a34c1c | Author: Maxim Muzafarov <maxmuzaf@gmail.com>
 | 2023-03-01 00:35:36+01:00

    Fix the number of running trees per thread for LongBTreeTest hanging test
    
     patch by Maxim Muzafarov; reviewed by Mick Semb Wever for CASSANDRA-18131

f5df4b219e063cb24b9cc0c22b6e614506b8d903 | Author: Mick Semb Wever <mck@apache.org>
 | 2022-12-18 01:16:16-08:00

    Move build and test scripts in-tree, under .build/
    
    See .build/README.md  .Build and test scripts cover all CI activities in an CI agnostic manner. Scripts are found in non-docker and dockerised variants.
    
    The non-docker scripts are found first under .build/ .These interact directly with ant, providing additional checks and environment setup. It is intended that what can be pushed down into the base ant build layer should be. The
    debian and redhat build scripts are hidden under .build/docker because they are generally not usuable outside of their corresponding linux dists, and we don't want to encourage anything to the contrary.  Bring the artifact/deb/rpm
    build scripts (and associated docker images) from cassandra-builds repo to the .build directory.  These packaging script for debian and redhat are now separated from the artifacts scripts. An additional build script check-code.sh
    has been added that is solely responsible for all linter and code checks (includes owasp dependency checker).  Only JDK11 and JDK17 are supported (as JDK8 is soon to be dropped).  Scripts do not clean (or realclean) so that
    scripts can be better pipelined, but `ant jar` was required to be added to circleci and ci-cassandra.a.o cqlsh-tests.  Scripts can define a custom BUILD_DIR (build.dir) which can permit running parrallel builds off the same source
    (though not all tests support this, or their support for it has atrophied).  All build and test artifacts, results, and logs are found under build/ (or the BUILD_DIR).  The build local venv and .ccm directories are now also
    created under build (or BUILD_DIR).  The test venv, logs and results are wiped each run.  Use a separate mktemp directory each run, under /tmp (respect /tmp responsibility, and python fails when tmpdir is on a docker volume).
    Don't set CASSANDRA_HOME when running python dtests (and fail-fast if `ant artifacts` was used to build instead of `ant jar`).
    
    The docker scripts are found lower down under .build/docker/ .These scripts re-used the non-docker scripts inside containers. The docker images are versioned controlled in the same directory as dockerfiles, and tagged by their
    md5sums.  When running the docker scripts these docker images will, if not in the local registry, will first be attempted to be pulled from dockerhub and only then fallback to be built locally.  This allows the dockerfiles to be
    modified in existing patches and be run in existing CI as-is.  Docker scripts timeout after one hour.  virtualenv-clone is used, re-using the python versioned venvs in the image saves time over creating new ones each run.  The inner-spliting of docker containers has been removed.  It added a lot of complexity, for the most part duplicating the splitting concept, for little performance gain.
    
    Ant target 'generate-unified-test-report' added, used for aggregating test reports and printing a summary.
    
     patch by Mick Semb Wever; reviewed by Brandon Williams, Josh McKenzie, Maxim Muzafarov, Stefan Miklosovic for CASSANDRA-18133

f5df4b219e063cb24b9cc0c22b6e614506b8d903 | Author: Mick Semb Wever <mck@apache.org>
 | 2022-12-18 01:16:16-08:00

    Move build and test scripts in-tree, under .build/
    
    See .build/README.md  .Build and test scripts cover all CI activities in an CI agnostic manner. Scripts are found in non-docker and dockerised variants.
    
    The non-docker scripts are found first under .build/ .These interact directly with ant, providing additional checks and environment setup. It is intended that what can be pushed down into the base ant build layer should be. The
    debian and redhat build scripts are hidden under .build/docker because they are generally not usuable outside of their corresponding linux dists, and we don't want to encourage anything to the contrary.  Bring the artifact/deb/rpm
    build scripts (and associated docker images) from cassandra-builds repo to the .build directory.  These packaging script for debian and redhat are now separated from the artifacts scripts. An additional build script check-code.sh
    has been added that is solely responsible for all linter and code checks (includes owasp dependency checker).  Only JDK11 and JDK17 are supported (as JDK8 is soon to be dropped).  Scripts do not clean (or realclean) so that
    scripts can be better pipelined, but `ant jar` was required to be added to circleci and ci-cassandra.a.o cqlsh-tests.  Scripts can define a custom BUILD_DIR (build.dir) which can permit running parrallel builds off the same source
    (though not all tests support this, or their support for it has atrophied).  All build and test artifacts, results, and logs are found under build/ (or the BUILD_DIR).  The build local venv and .ccm directories are now also
    created under build (or BUILD_DIR).  The test venv, logs and results are wiped each run.  Use a separate mktemp directory each run, under /tmp (respect /tmp responsibility, and python fails when tmpdir is on a docker volume).
    Don't set CASSANDRA_HOME when running python dtests (and fail-fast if `ant artifacts` was used to build instead of `ant jar`).
    
    The docker scripts are found lower down under .build/docker/ .These scripts re-used the non-docker scripts inside containers. The docker images are versioned controlled in the same directory as dockerfiles, and tagged by their
    md5sums.  When running the docker scripts these docker images will, if not in the local registry, will first be attempted to be pulled from dockerhub and only then fallback to be built locally.  This allows the dockerfiles to be
    modified in existing patches and be run in existing CI as-is.  Docker scripts timeout after one hour.  virtualenv-clone is used, re-using the python versioned venvs in the image saves time over creating new ones each run.  The inner-spliting of docker containers has been removed.  It added a lot of complexity, for the most part duplicating the splitting concept, for little performance gain.
    
    Ant target 'generate-unified-test-report' added, used for aggregating test reports and printing a summary.
    
     patch by Mick Semb Wever; reviewed by Brandon Williams, Josh McKenzie, Maxim Muzafarov, Stefan Miklosovic for CASSANDRA-18133