57 Collaborator |
Brandon Williams , Štefan Miklošovič , Andrés de la Peña , Berenguer Blasi , Ekaterina Dimitrova , Mick Semb Wever , Marcus Eriksson , David Capwell , Sam Tunnicliffe , Josh McKenzie , Alex Petrov , Jacek Lewandowski , Benjamin Lerer , Branimir Lambov , Jon Meredith , Yifan Cai , Benedict Elliott Smith , Francisco Guerrero , Maxim Muzafarov , Dinesh Joshi , Aleksey Yeschenko , Paulo Motta , Mike Adamson , Blake Eggleston , Doug Rohrer , Zhao Yang , Chris Lohfink , Ariel Weisberg , Jonathan Ellis , Stefan Podkowinski , Jason Brown , Maxwell Guo , Abe Ratnofsky , Piotr Kołaczkowski , Jeremiah Jordan , Claude Warren , Bernardo Botella , Aleksandr Sorokoumov , Maulin Vasavada , Jason Rutherglen , Dan Jatnieks , Natnael Adere , Arun Ganesh , Piotr Kolaczkowski , Paul Chandler , Leonard Ma , Dimitar Dimitrov , Maxim Chanturiay , Jakub Zytka , reviewed by Caleb Rackliffe , arkn98 , and Josh McKenzie , Youki Shiraishi , Michael Marshall , Jakub Żytka , Claude Warren, Jr , Benedict Elliott Smith |
61 Patch |
140 Review |
2651623af6bb3da5f820d9e09abfbdd0683a1322,
376fe2a9fe3f13c7555c40cda6d3912d55ef63cc,
019c9118d4109ee1d394b65281c45495eb57e033,
176ce395bb42c102a8df080ecd26559ab0c93b13,
219eea33b6102ceac4832368444878b64ff2a63a,
b4f1c6d250991fc27c5f87a2dc0fd81e7ad0d272,
bddaa4409fc4cb83394c2963a1028bcfb9dce733,
5abe213ad0a9bbb48291a4a4e9f12757fa858eab,
93415c91af3d06504593a87c8b8d7e5d2d65b1ac,
d54646e40957ffc18f651753941fac3068b79f8e,
ab1c3e4877f215380dc6881cd7793ab4890ccfb4,
e22f67a2f7815f06190e78e7859e74d0769e4cc9,
428fa1f4453735ef43d508621e5e7d9e0a054415,
9bfaee91c4fd7a269e3ff924e8a504bad5d6514a,
0974a3656dd4fd98b527264a763b50980f49be24,
b0150e86fbf5863fd831cfca8118f1a8bd254a43,
be507c6e996078011c08e36b09d9f34faa454973,
46acaf22e688e7a2e707ac61fd88c96ed33b60d7,
001f70367e32bd44dc03c30d5533e549bbaea67e,
f7984627e7dd5794dabc099f49ecf80ca3631803,
1d7bae3697b97e64de2c2b958427ef86a1b17731,
87f2a7b7637a346cdeea23e0b74d9968ccfca619,
d5cea135c98bb98b16b215d309ead22e86f1329f,
e8fb4b2f63b32f337447992f9eb57a12e2afc0e4,
256e39fc62c0b0ce576fd29849672e6323eecea4,
f8d4e2a3c80d5d2be1e270e7ac601f4bc0a17fe7,
5bdfd790b7b8cc638a96efb5c34181ece35b04a1,
3ba4cd24a0c6b5a90ac0ed57ec2eec152308f211,
83203a14c400ff99cfb2a5b7e655a663ea882c2b,
394d4b116868e4897ad3cc40833df801366a8916,
b396faf913c5843dbac90cd275554cc1d4e05c21,
6f125c80420f6d249b5414d886e1b4a93cc34e7f,
c712312b8fb0d73a3bbb42ee742fea3059dd4157,
e5e0f3a8441503107b1ca2128cf8366e5e44d893,
cde91e56f09d9ebf315c79c9a81b89f70f4eb724,
303ca55a5dc9079071cd5459aa9c9abf0b3b2991,
c3327855e4bf98f8631c959b82bd8470726034a8,
4892331eb49f72d2e18432a2af56538d11c7c5d1,
530bc10bd0a053f5dcd8439fd3f5c72cd7952ea6,
8419fb21e016389f15be0954e8721cf4f6918249,
e89b214d069321c8968871b8eb7d51d4dfba7c33,
bd2ecb3454649d8c84cf0b1ce8c1e94ed1e06e74,
d6aee7e08c658db9d394a6b7e3e27791b4d6854f,
c56952efb570df2b09a7d428319a9b7755a0c387,
3e0b94565acc64e903d73af3a14b23c875abc5b3,
5e39c54678b0d70145b5c699593eb9ce7fa7706a,
d51f90201b2d127166612384a75b4a49da9776d1,
89f3978dcde958fbad191b8cf628fd89ace64d7a,
a00d8fd5ba9d73a377d1a11e6f540c56d66e9c8f,
af90c3634007ba9b2967267d6f8383d38cdff85f,
57ab3afcf16970047d3df4656241cf0705e94bee,
0089858819c9f06b0bee5bccf993ae7f5977d7f1,
4ea3e4c5050ba11a5b7897af74bb54e7e8dad068,
302c6fcf59c5fa9fcd475b2c811ad57ae7c45f49,
7b91e4cc18e77fa5862864fcc1150fd1eb86a01a,
28eea6e8cd4055c8d21f872c72f8bd14fd2467ba,
9ff28fc717e7926b5cf7c8acc85a35e0cfb43595,
8a33f323508dab061dbebfd168e431cd0e683e01,
4ef129092609821b13eee36c285dbdd89aa05c61,
cd6533401282e0455f87ba4d4a58bfec18fde4dc,
275f188660b66743bf3f055c8d7da438ad826061 |
7c55c73825e341315e520381968338d57afbb67a,
75ec1ada7a40761e8b6eb948925c2dd2b116876e,
f9ab5cf797013211c51c4e7d2dbd401300eb44e6,
bc40d3bb27cac7979867def92fe84e5fa5011155,
ad4ad5ef5aa9a432d7126140fc9f4fedcd20411c,
b4894226c57bf2cbc29cad1db47938c9e5ef0a7c,
bddaa4409fc4cb83394c2963a1028bcfb9dce733,
c7e9048d4df9c0a5bb178c8388a13ad44f1cc0d2,
2c52a8be6fdac7305e433b7f28bd70596ef1444a,
52396ec1fc4d08a988714704ff0cbb796ee06f7f,
3afa2585d9b7c88dc7d83c929df6f70c988d27a7,
018feb36f42d28bc11073741ef224b42f9a60ad0,
273975ef26e5de1a10a98c0df364cb67fa7830e3,
dc17c29724d86547538cc8116ff1a90d36a0bf3a,
534da538d229a5b4fc1d9ef7cc8b37ead455191c,
8619010cdca8bce471754e4fbeb861f036535007,
9157d98e4cc5c00d74cef6128c16659ff43f3585,
cada1a13c8b77fc672d67d754912cf28a7120e3c,
0974a3656dd4fd98b527264a763b50980f49be24,
6b48f8a11dbad8c0653309eb8193fa6157bba5d8,
b0150e86fbf5863fd831cfca8118f1a8bd254a43,
a26fa6cf2c9a86827d38c448a54878d76bb18e27,
016dd6ca376ac1080bba9a1e2a6fe1d4b037e751,
ad642d5e25201dd6dba937942025b61884f53447,
8ce4a6d1ecfaabf3ae7a3808a20ff36c155a346a,
439d1b122af334bf68c159b82ef4e4879c210bd5,
7447ee5bddb31ea71a232a44d64dbb7dd0010708,
3b05051f8678c28bc9d93a89123c68f8d0b93b7b,
6a7bef12ecdf59e3a67c81b89c13e3c2bf7e19d8,
0e42b77c9735d1124fe0a5766447f29c891cdb5b,
e8fb4b2f63b32f337447992f9eb57a12e2afc0e4,
e1355d72386d74d18baaf19fe93fdef91a7aa8b3,
fe1be800b4f7e6ca5b2f28dddd2b6f7489f41631,
9dbd63a5b9aa2f2398b02ee5c72d8e977f56867d,
69f5df0b00cc822f41823901956aeff9fcdd9dbb,
07df26778b01a00c1f5770c8cf133ce4c2829533,
e45c1092f91edd63591f562b2120ea6a5fd3edd5,
d828cd0228143438590f3aaa4e2c7d3c03bd66d8,
164fa7949d1437528363465d14ed20898f1daa9e,
9ce86e0ff8b6344b528a0640f9dafa23f97dd85a,
bde4fa0013eb8cec5b1d88b21ca4463bc07272bb,
b265b4658e007b6943d543a11c609b7ba5fd979f,
655a2455ac29395b0a303e6ad7fc4d458b18932d,
f0280fb6f863582125bfd16b8a90c345972c4a8c,
816d1ac1812cbf9aaf19c133d1d2b6087a2defad,
2531cb045897d5b771f79039d194a1f679d8629a,
eb208d3561eaf645f74f60b54c71ebe5bfc24c33,
cba3e19ccd81d705ca9f89c0eedab65824e9dd16,
b396faf913c5843dbac90cd275554cc1d4e05c21,
6f125c80420f6d249b5414d886e1b4a93cc34e7f,
98fefc1557efa7123bab19eb5f74f04964aa02c1,
ebea2ba6ade00a6f156787ca4ee36b2f8eb003ad,
01aeb616beecf4787e02760e473fbc9705c5b1bc,
e5e0f3a8441503107b1ca2128cf8366e5e44d893,
cde91e56f09d9ebf315c79c9a81b89f70f4eb724,
303ca55a5dc9079071cd5459aa9c9abf0b3b2991,
c3327855e4bf98f8631c959b82bd8470726034a8,
fad1f7457032544ab6a7b40c5d38ecb8b25899bb,
f16fb6765b8a3ff8f49accf61c908791520c0d6e,
ae995eb3d3cc1c98f61db0d071522b6f09443927,
4759a7353fca1dad330e913e7eaf1313890a35be,
4f348786bd6d72f4402134a29ddb3355b1fade61,
bd49f6ff265c8bfa64bf140328ae6736dc4a87bd,
d5b1483703b53c02fb0e616e58107afb814f9f81,
b8a87abba47441d97b3c85a0473d02919e1c071b,
d7c5c547f025301780658b37e6e8a591bc4a5b36,
9f58d76f3841864be11f5b9c4534027451328569,
e08c7a6295eed716e9973fbd809dfca32d68a3e8,
9a0dd603b18ab5034df27443a4bbc10111edcd8b,
8ec04361b9e098430023e4776baf1941be958475,
dd53a609c692c12ffb94acf9fcf81343e35723e9,
230fe8e64722ac02dbf8cdafb7d4fef120726dd7,
9074ee7ef8e041e1b15116373be0df80b985e3d9,
7c55c73825e341315e520381968338d57afbb67a,
562cb26010659830dd1192939ac815a0f6cb3502,
49e0c61107005b1a83799f7f1e6c0a855d159c29,
488c0c75a8f632f2db4e3db39f2ebcf8a489971e,
4fc2d9e53985dc89b93bbac80bea9faa4a3d708b,
7adfdc85cf5c1cb505e6507e5c08de84834c2224,
ff5f4833aa3e11fcffd6bff1b15597fd5a38b864,
d25adb498abde240cc162cfe4a9630c01381c7f9,
6748b8b7ead6fff7820045ebbfe23f6c050f2efe,
1ee5df02b1f98cf38f126d47a7f3fb153f790d52,
c4b1c0614e42b4ea2064822d31c28aa5d4f1450a,
3f2e8d1883c586bdb9cd7a23076ceaaeefa4bd8c,
09b282d1fdd7d6d62542137003011d144c0227be,
f5dc9a1c1e27ac5ea0cb972ceaf68d5993804d6f,
dd08314ed654aafa60b2a82fc4953aac171ba3ef,
0daf21244fc0187d092616834d38df1a77dcabf0,
1fef492e2bedc024e994a173222d27c6f8d7f0a3,
b4e58d83fc72f8babf61367aad23a9499df69881,
89f3978dcde958fbad191b8cf628fd89ace64d7a,
a9725b681b948f2122f3d48b96a5c4e7403d2c39,
e966c45afcf8bef47df245ccb851386e5ce60505,
60b54425edc0a328bc1baf00c2e5bf111d4b9da8,
d3ce825bf2b376fd2516e4b594ddb69037c13159,
a67a2a2441589e8bf41498c426fddacd7b9719cf,
ffc4c89c3df7ad0ae73ebefdcb7e15a2790c0a52,
e4e19e33faf9ac7cf27a9779c8083a7f5c5b865a,
3409e5d9b341de2114d6410225922843539d4172,
2873c9126979e21a8089e9a18d96af802745dbc2,
7db3285e7b745e591dc4c405ae9af6c1cddb0c79,
dac738d2eba8629d4f482d7cbfd855d2c5b9df47,
01c4404fff8c3dde071d4b9d0327acbb299be688,
fa7185ef02c313ff322fcc50d2de03186b9f96a7,
10103d353c3d63505cb119cda0e38e692cdb1809,
a41040ccdcec651bffb4d23843ab9be2d96ba1d1,
b58a5c86e89e10ad4d39756c5314a756eb18204d,
85c202d8a8b037791db08c531f4f3c8336c82696,
81922c5a7bcbf9db7564a29922c9d8f6222c7cdc,
9f56bf4ca7fdb61ad09e5f2ad09b87cd01e0716b,
c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23,
6d5203615f7a9670cb1698b74123666bc25ba471,
23138252f20891c26a3692664c6affaf99e86541,
1315d0c96f4625a76296f58d431f97669e5178c2,
ed48f3c017c5e572a523890bcd5b7c798d7eb358,
755fd9446b084e659e98bd7336b9e910c2e12577,
d85f7f7c2dd4b9bbdb44bc96235e6a8bc3ff3967,
b9e2ab75f8f6dedd45c6ad7a83b3160149869262,
a3258d66bcc9f946304c19d59e75d2721126303e,
5bb4bab12f8edfef95ed13cbabf8c0f377986065,
db9f7a67ec4b03413c10034956e2cf18739ca4b1,
df16b3750dc2c1b6b9bcdece6f81dfd3de7ebdfa,
9ff28fc717e7926b5cf7c8acc85a35e0cfb43595,
89c6addb505392ef3434597b61f83da25d13e3e2,
e4e19e33faf9ac7cf27a9779c8083a7f5c5b865a,
20ebcb23662d1b2023839a6662c68800dda120a0,
6dd7def99467952d1df6a451d2e74861cf6599de,
33ff84a396c9d5b9a9be574be50dbb2ea9c9ded0,
8367b3d6a9ea653211205c404b61d4b6d4f9520e,
c40973f6376fd80e5e0b5efddaa488a23ff1793a,
7bc8467233af69391efeaf74ef87a73c0ea9ceb1,
be48c417e6bbbd7c58f43ed001c9a2209a6339ab,
bd5e29c7ca8e0d6987ba9d180d97766cb30eb0fa,
3935906a685640b2f6a2058b38fdf45d917edfc9,
0448f15e3db392f2f60db332fabf6309aa3d5089,
27c6d022c2d7c197be03c7d6ebe22861ca66a04d,
796cfd4359355bcb8c31d072e9c4051a73ec9333,
6e0b450d9df3596d2eb79bfca92edd434cca7035,
6ed308d6a814826be145f6ba30304ea474bf263e |
75ec1ada7a40761e8b6eb948925c2dd2b116876e | Author: Stefan Miklosovic <smiklosovic@apache.org>
| 2024-12-16 23:18:36+01:00
Check presence of a snapshot in a case-insensitive manner on macOS platform to prevent hardlinking failures
When hardlinks are created for a snapshot with the name "snapshot"
and then we take a snapshot with the name "Snapshot", macOS platform thinks
that this was already hardlinked because its hardlinking implementation
does not seem to be case-sensitive. The fix consists of checking,
in a case-insensitive manner, if there is already such snapshot,
but only on macOS platform.
The patch also does not create empty directories for a given snapshot
prematurely before checking its presence so there are not dangling empty
directories in case of a failure.
patch by Stefan Miklosovic; reviewed by Bernardo Botella, Caleb Rackliffe for CASSANDRA-20146
2651623af6bb3da5f820d9e09abfbdd0683a1322 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2024-11-20 16:13:01-06:00
Interpret inet, bigint, varint, and decimal as non-reversed types for query construction and post-filtering
patch by Caleb Rackliffe; reviewed by David Capwell for CASSANDRA-20100
176ce395bb42c102a8df080ecd26559ab0c93b13 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2024-10-09 14:52:40-05:00
Always write local expiration time as an int to LivenessInfo digest
patch by Caleb Rackliffe; reviewed by Mick Semb Wever, David Capwell, and Marcus Eriksson for CASSANDRA-19989
ad4ad5ef5aa9a432d7126140fc9f4fedcd20411c | Author: Maxim Muzafarov <maxmuzaf@gmail.com>
| 2024-09-30 15:42:55+02:00
Fix race condition in DecayingEstimatedHistogramReservoir during rescale
patch by Maxim Muzafarov; reviewed by Caleb Rackliffe for CASSANDRA-19365
Co-authored-by: Jakub Zytka <jakub.zytka@datastax.com>
bddaa4409fc4cb83394c2963a1028bcfb9dce733 | Author: Arun Ganesh <20590666+arkn98@users.noreply.github.com>
| 2024-09-04 13:49:20-07:00
SAI support for BETWEEN operator
Patch by Arun Ganesh; reviewed by Caleb Rackliffe and Zhao Yang for CASSANDRA-19688
Co-authored-by: Arun Ganesh <20590666+arkn98@users.noreply.github.com>
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
2c52a8be6fdac7305e433b7f28bd70596ef1444a | Author: David Capwell <dcapwell@apache.org>
| 2024-08-20 11:50:34-07:00
Improve CQLTester to make it trivial to run the tests with different configs, and to add randomness to the test
patch by David Capwell; reviewed by Caleb Rackliffe for CASSANDRA-19833
3afa2585d9b7c88dc7d83c929df6f70c988d27a7 | Author: David Capwell <dcapwell@apache.org>
| 2024-08-14 11:55:19-07:00
Memtable allocation type unslabbed_heap_buffers_logged will cause an assertion error for TrieMemtables and SegmentedTrieMemtables
patch by David Capwell; reviewed by Brandon Williams, Caleb Rackliffe for CASSANDRA-19835
20ebcb23662d1b2023839a6662c68800dda120a0 | Author: Brandon Williams <brandonwilliams@apache.org>
| 2024-06-18 10:55:36-05:00
Byteman halts instead of exits
Patch by brandonwilliams; reviewed by maedhroz and smiklosovic for
CASSANDRA-19697
dc17c29724d86547538cc8116ff1a90d36a0bf3a | Author: Alex Petrov <oleksandr.petrov@gmail.com>
| 2024-05-27 21:33:25+02:00
Add native transport deadline, an ultimate deadline for all tasks related to a specific request
* Add an ability to base _replica_ side queries on the queue time
* Use queue time as a base for message timeouts
* Use native transport deadline for internode messages
* Make sure that local runnables respect transport timeouts and deadlines
* Make sure that remote mutation handler respects message expiration times
Patch by Alex Petrov; reviewed by Caleb Rackliffe for CASSANDRA-19534
e22f67a2f7815f06190e78e7859e74d0769e4cc9 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2024-05-02 09:48:41-05:00
Make sure IntersectFilteringQueryTest#shouldNotWarnOrFailOnIndexQuery waits for indexes to be available before making queries
patch by Caleb Rackliffe; reviewed by Brandon Williams for CASSANDRA-19612
9157d98e4cc5c00d74cef6128c16659ff43f3585 | Author: Jon Meredith <jonmeredith@apache.org>
| 2024-04-25 13:53:28-06:00
Streaming exception race creates corrupt transaction log files that prevent restart
patch by Jon Meredith; reviewed by Caleb Rackliffe, David Capwell for CASSANDRA-18736
428fa1f4453735ef43d508621e5e7d9e0a054415 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2024-04-19 18:40:08-05:00
Make queries visible to the "system_views.queries" virtual table at the coordinator level
patch by Caleb Rackliffe; reviewed by David Capwell and Chris Lohfink for CASSANDRA-19577
9bfaee91c4fd7a269e3ff924e8a504bad5d6514a | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2024-04-09 17:32:56-05:00
Optionally fail writes when SAI refuses to index a term value exceeding a configured maximum size
patch by Caleb Rackliffe; reviewed by Berenguer Blasi and Stefan Miklosovic for CASSANDRA-19493
cada1a13c8b77fc672d67d754912cf28a7120e3c | Author: Mick Semb Wever <mck@apache.org>
| 2024-04-09 00:11:20+02:00
Vector search should be able to restrict on clustering keys when filtering isn't required
patch by Mick Semb Wever; reviewed by Caleb Rackliffe for CASSANDRA-19544
be507c6e996078011c08e36b09d9f34faa454973 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2024-04-01 14:18:05-05:00
Warn clients about possible consistency violations for filtering queries against multiple mutable columns
patch by Caleb Rackliffe; reviewed by David Capwell and Berenguer Blasi for CASSANDRA-19489
8a33f323508dab061dbebfd168e431cd0e683e01 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2024-03-15 18:41:01-05:00
Deprecate Python 3.7 and earlier, but allow cqlsh to run with Python 3.6-3.11
patch by Caleb Rackliffe; reviewed by Brandon Williams and Stefan Miklosovic for CASSANDRA-19467
46acaf22e688e7a2e707ac61fd88c96ed33b60d7 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2024-03-15 17:29:01-05:00
Ensure SAI indexes empty byte buffers for types that allow them as a valid input
patch by Caleb Rackliffe; reviewed by David Capwell for CASSANDRA-19461
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: David Capwell <dcapwell@apache.org>
b0150e86fbf5863fd831cfca8118f1a8bd254a43 | Author: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
| 2024-03-04 13:46:25-05:00
Clean up KeyRangeIterator classes
* replace KeyRangeConcatIterator's PriorityQeueu with List
* remove KeyRangeIterator.current and simplify
* remove injected exception and tests - not relevant to the current implementation
* expand randomized testing
* inline getCurrent() -> peek(); rename getCount to getMaxKeys
* redefine skipTo contract to not return a value (which saves unnecessary work when skipTo is called multiple times in a row)
* calling hasNext in skipTo is a pessimization; if the iterator is in DONE state, then skipTo will see it and avoid further effort; if it is not, then we are computing a next value that we're just going to throw away
* fix SingleNodeQueryFailureTest - tests now multi and single index
* rationalize/standardize the way we release SSTableIndexes in QueryController
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, Ekaterina Dimitrova for CASSANDRA-19428
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: Jonathan Ellis <jbellis@apache.org>
Co-authored-by: Piotr Kolaczkowski <pkolaczk@datastax.com>
Co-authored-by: Michael Marshall <michael.marshall@datastax.com>
87f2a7b7637a346cdeea23e0b74d9968ccfca619 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2024-01-19 04:39:02-06:00
Avoid over-skipping of key iterators from static column indexes during mixed intersections
patch by Caleb Rackliffe; reviewed by Piotr Kołaczkowski and Alex Petrov for CASSANDRA-19278
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: Piotr Kołaczkowski <pkolaczk@gmail.com>
6b48f8a11dbad8c0653309eb8193fa6157bba5d8 | Author: Alex Petrov <oleksandr.petrov@gmail.com>
| 2024-01-17 19:12:43+01:00
Harry model that supports value overrides: an ability to provide specific values for clustering, regular, and static columns
Patch by Alex Petrov; reviewed by Caleb Rackliffe for CASSANDRA-19284
001f70367e32bd44dc03c30d5533e549bbaea67e | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2024-01-11 23:13:56-06:00
Harry model and in-JVM tests for partition-restricted 2i queries
patch by Caleb Rackliffe; reviewed by Alex Petrov for CASSANDRA-18275
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: Alex Petrov <oleksandr.petrov@gmail.com>
d5cea135c98bb98b16b215d309ead22e86f1329f | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2024-01-08 15:23:35-06:00
Revert unnecessary read lock acquisition when reading ring version in TokenMetadata introduced in CASSANDRA-16286
patch by Caleb Rackliffe; reviewed by Francisco Guerrero for CASSANDRA-19107
ad642d5e25201dd6dba937942025b61884f53447 | Author: Stefan Miklosovic <smiklosovic@apache.org>
| 2024-01-02 13:00:33+01:00
Creating a SASI index after creating an SAI index does not break secondary index queries
patch by Stefan Miklosovic; reviewed by Caleb Rackliffe, Andres de la Peña for CASSANDRA-18939
7447ee5bddb31ea71a232a44d64dbb7dd0010708 | Author: Mike Adamson <madamson@datastax.com>
| 2023-12-21 09:12:58+00:00
Avoid random IndexStreamingFailureTest failures
Change how ByteBuddy injections are handled to avoid ByteBuddy
failures after node restarts
Patch by Mike Adamson; reviewed by Caleb Rackliffe for CASSANDRA-19084
8ce4a6d1ecfaabf3ae7a3808a20ff36c155a346a | Author: Stefan Miklosovic <smiklosovic@apache.org>
| 2023-12-21 04:04:08+01:00
Optionally fail when a non-partition-restricted query is issued against an index
patch by Stefan Miklosovic; reviewed by Caleb Rackliffe for CASSANDRA-18796
3b05051f8678c28bc9d93a89123c68f8d0b93b7b | Author: Mike Adamson <madamson@datastax.com>
| 2023-12-12 17:14:41+00:00
Simplify segment building in SAI to use single in-memory structure
This removes the RAMStringIndexer for literal indexes and replaces
it with a SegmentTrieBuffer that replaces BlockBalancedTreeRamBuffer
for literal and numeric indexes.
patch by Mike Adamson; reviewed by Andrés de la Peña, Caleb Rackliffe for CASSANDRA-18598
6a7bef12ecdf59e3a67c81b89c13e3c2bf7e19d8 | Author: Mike Adamson <madamson@datastax.com>
| 2023-11-28 10:48:23+00:00
Fix SAI intersection queries
- Fix comparison in PostingListRangeIterator for updating skip token
- Fix binary search in KeyLookup.clusteredSeekToKey
- Added new on-disk component for storing partition sizes by partition ID
patch by Mike Adamson; reviewed by Caleb Rackliffe, Mick Semb Wever for CASSANDRA-19011
f7984627e7dd5794dabc099f49ecf80ca3631803 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2023-11-27 18:35:26-06:00
Avoid possible consistency violations for SAI intersection queries over partially updated rows at consistency levels that require reconciliation
- Replica filtring protection now correctly accounts for short reads caused by coordinator filtering of merged rows.
- There is a new flag in ReadCommand that indicates whether the user query it belongs to requires reconciliation.
- Local SAI queries now degrade intersections to unions on unrepaired data if reconciliation is required and multiple mutable columns are restricted.
patch by Caleb Rackliffe; reviewed by Andres de la Peña and Alex Petrov for CASSANDRA-19018
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: Alex Petrov <oleksandr.petrov@gmail.com>
e1355d72386d74d18baaf19fe93fdef91a7aa8b3 | Author: Stefan Miklosovic <smiklosovic@apache.org>
| 2023-11-15 22:02:04+01:00
Set default disk_access_mode to mmap_index_only
patch by Stefan Miklosovic; reviewed by Paulo Motta, Caleb Rackliffe, Brandon Williams for CASSANDRA-19021
e8fb4b2f63b32f337447992f9eb57a12e2afc0e4 | Author: Andrés de la Peña <a.penya.garcia@gmail.com>
| 2023-11-13 12:46:53+00:00
Ensure that empty SAI column indexes do not fail on validation after full-SSTable streaming
patch by Andrés de la Peña; reviewed by Caleb Rackliffe for CASSANDRA-19017
Co-authored-by: Andrés de la Peña <a.penya.garcia@gmail.com>
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
0e42b77c9735d1124fe0a5766447f29c891cdb5b | Author: Mike Adamson <madamson@datastax.com>
| 2023-11-10 14:49:41+00:00
Improve code model around IndexContext
- Replace IndexContext with IndexTermType and IndexDefinition
- Move index specific managers, factories and metrics to StorageAttachedIndex
- Refactor Expression to explicitly define indexed and unindexed expressions
patch by Mike Adamson; reviewed by Andres de la Peña, Caleb Rackliffe for CASSANDRA-18166
07df26778b01a00c1f5770c8cf133ce4c2829533 | Author: Maxim Muzafarov <maxmuzaf@gmail.com>
| 2023-10-20 11:01:54+02:00
Change the checksum algorithm SAI-related files use from CRC32 to CRC32C
patch by Maxim Muzafarov; reviewed by Caleb Rackliffe and Zhao Yang for CASSANDRA-18836
256e39fc62c0b0ce576fd29849672e6323eecea4 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2023-10-19 16:35:57-05:00
ClientRequestSize metrics should not treat CONTAINS restrictions as being equality-based
patch by Caleb Rackliffe; reviewed by Benjamin Lerer for CASSANDRA-18896
9dbd63a5b9aa2f2398b02ee5c72d8e977f56867d | Author: Jacek Lewandowski <lewandowski.jacek@gmail.com>
| 2023-10-05 09:09:07+02:00
Fix KeyCacheTest for cases when early open is disabled
Patch by Jacek Lewandowski; reviewed by Berenguer Blasi, Branimir Lambov, Caleb Rackliffe for CASSANDRA-18911
e45c1092f91edd63591f562b2120ea6a5fd3edd5 | Author: Mike Adamson <madamson@datastax.com>
| 2023-10-04 11:27:50+01:00
Correctly remove Index.Group from IndexRegistry
The Index.Group was being left in the list indexGroups in the SecondaryIndexManager because the incorrect
key was being used to remove it from the map
patch by Mike Adamson; reviewed by Caleb Rackliffe and Zhao Yang for CASSANDRA-18905
Co-authored-by: Zhao Yang <zhaoyangsingapore@gmail.com>
534da538d229a5b4fc1d9ef7cc8b37ead455191c | Author: Benjamin Lerer <b.lerer@gmail.com>
| 2023-09-15 18:05:11+02:00
Refactor Relation and Restrictions hierachies
patch by Benjamin Lerer and Piotr Kołaczkowski; reviewed by Berenguer Blasi, Caleb Rackliffe and Ekaterina Dimitrova for CASSANDRA-19341
Co-authored-by: Piotr Kołaczkowski <pkolaczk@datastax.com>
bde4fa0013eb8cec5b1d88b21ca4463bc07272bb | Author: Jon Meredith <jonmeredith@apache.org>
| 2023-08-28 16:10:41-06:00
Waiting indefinitely on ReceivedMessage response in StreamSession#receive() can cause deadlock
patch by Jon Meredith; reviewed by Caleb Rackliffe, David Capwell for CASSANDRA-18733
f8d4e2a3c80d5d2be1e270e7ac601f4bc0a17fe7 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2023-08-10 10:56:30-05:00
Disable heap dump creation by default on crash for tests that use test/conf/cassandra.yaml
patch by Caleb Rackliffe; reviewed by Brandon Williams and Ekaterina Dimitrova for CASSANDRA-18741
9ce86e0ff8b6344b528a0640f9dafa23f97dd85a | Author: Mike Adamson <madamson@datastax.com>
| 2023-08-08 17:07:01+01:00
SAI result retriever is filtering too many rows
This patch fixes a bug in the SegmentMetadata that
was only storing the partition key for min and max
primary keys for a segment. It also contains some
refactoring of the PrimaryKey to remove the deferred
loading of PrimaryKeys by the PrimaryKeyMaps.
Patch by Mike Adamson; reviewed by Caleb Rackliffe and Andrés de la Peña for CASSANDRA-18734
5bdfd790b7b8cc638a96efb5c34181ece35b04a1 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2023-08-01 14:53:07-05:00
Ensure that SSTablesSystemViewTest compacts to a single SSTable in testVirtualTableThroughIndexLifeCycle even w/ UCS
patch by Caleb Rackliffe; reviewed by Mick Semb Wever for CASSANDRA-18703
655a2455ac29395b0a303e6ad7fc4d458b18932d | Author: Mike Adamson <madamson@datastax.com>
| 2023-07-28 17:38:20+01:00
Reduce size of per-SSTable index components for SAI
This patch removes the PRIMARY_KEY_TRIE component and adds KeyLookup.Cursor#clusteredSeekToKey() to
search for clustering keys within a partition. To do this a new on-disk component
PARTITION_SIZES has been added that holds the size of each partition in the SSTable.
patch by Mike Adamson; reviewed by Caleb Rackliffe and Andres de la Peña for CASSANDRA-18673
3ba4cd24a0c6b5a90ac0ed57ec2eec152308f211 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2023-07-27 14:02:10-05:00
ninja-fix: make sure testVirtualTableThroughIndexLifeCycle disabled auto-compaction
83203a14c400ff99cfb2a5b7e655a663ea882c2b | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2023-07-14 01:44:26-07:00
Importer should build SSTable indexes successfully before making new SSTables readable
- Avoid validation in response to SSTableAddedNotification, as it should already have been done somewhere else
- Change SSTableWriter to prevent commit when a failure is thrown out of an index build
patch by Caleb Rackliffe; reviewed by Mike Adamson and Andres de la Peña for CASSANDRA-18670
ebea2ba6ade00a6f156787ca4ee36b2f8eb003ad | Author: Jonathan Ellis <jbellis@datastax.com>
| 2023-06-26 14:50:01-05:00
Upgrade to lucene-core 9.7.0
Notes on the upgrade path:
- RamIndexOutput is replaced with ResettableByteBuffersIndexOutput, an extension of ByteBuffersIndexOutput, which was the closest thing to a replacement of RamIndexOutput.
- Lucene exposes the code we needed from DirectReaders more or less directly in DirectReader now, so the old copied code has been deleted.
- Lucene changed its data files to be little endian, but to keep its compatibility story simple it retained BE for the header and footer ints. That's the cause of the changes in SAICodecUtils.
- We could gain a bit of performance making our own code natively little endian but that is too big of a change for this patch.
patch by Jonathan Ellis; reviewed by Andrés de la Peña, Caleb Rackliffe, and Mike Adamson for CASSANDRA-18494
394d4b116868e4897ad3cc40833df801366a8916 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2023-06-21 17:29:05-05:00
Add support for index implementation selection via USING for CREATE INDEX
patch by Caleb Rackliffe; reviewed by Maxwell Guo and Andres de la Peña for CASSANDRA-18615
b396faf913c5843dbac90cd275554cc1d4e05c21 | Author: Piotr Kołaczkowski <pkolaczk@datastax.com>
| 2023-06-20 16:03:03+02:00
Various changes to SAI index validation
- Fix checksum calculation in IncrementalChecksumSequentialWriter
- Checksum per-SSTable and per-column components after streaming
- Avoid validating indexes when full rebuild is requested
patch by Piotr Kołaczkowski; reviewed by Caleb Rackliffe and Andres de la Peña for CASSANDRA-18490
Co-authored-by: Piotr Kołaczkowski <pkolaczk@gmail.com>
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
98fefc1557efa7123bab19eb5f74f04964aa02c1 | Author: Piotr Kołaczkowski <pkolaczk@datastax.com>
| 2023-06-15 15:07:18+02:00
Stream all compatible components registered by an SSTable
patch by Piotr Kołaczkowski; reviewed by Andrés de la Peña and Caleb Rackliffe for CASSANDRA-18345
6f125c80420f6d249b5414d886e1b4a93cc34e7f | Author: Mike Adamson <madamson@datastax.com>
| 2023-06-12 11:25:17+01:00
Numeric on-disk index write and search
Includes:
- The disk/v1/kdtree package containing the
kdtree writer and reader
- The implementation code to tie these into
the existing read and write paths. The main parts
of this are the NumericIndexWriter and the
NumericIndexSegmentSearcher
- Additional testing for the new code
patch by Mike Adamson; reviewed by Caleb Rackliffe and Andres de la Peña for CASSANDRA-18067
Co-authored-by: Mike Adamson <madamson@datastax.com>
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: Piotr Kołaczkowski <pkolaczk@gmail.com>
Co-authored-by: Jason Rutherglen <jason.rutherglen@gmail.com>
Co-authored-by: Zhao Yang <zhaoyangsingapore@gmail.com>
c712312b8fb0d73a3bbb42ee742fea3059dd4157 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2023-06-01 14:43:20-05:00
post-rebase fixes for the rebase on trunk at fad1f7457032544ab6a7b40c5d38ecb8b25899bb
cba3e19ccd81d705ca9f89c0eedab65824e9dd16 | Author: Mike Adamson <madamson@datastax.com>
| 2023-05-10 15:05:15+01:00
Query all ranges at once for SAI distributed queries
patch by Mike Adamson; reviewed by Caleb Rackliffe, Andres de la Peña, and Berenguer Blasi for CASSANDRA-18515
eb208d3561eaf645f74f60b54c71ebe5bfc24c33 | Author: Mike Adamson <madamson@datastax.com>
| 2023-05-09 12:29:01+01:00
Add basic text analysis to SAI, including "case_sensitive", "normalize", and "ascii" modes
patch by Mike Adamson; reviewed by Caleb Rackliffe and Andres de la Peña for CASSANDRA-18479
4759a7353fca1dad330e913e7eaf1313890a35be | Author: David Capwell <dcapwell@apache.org>
| 2023-05-08 11:56:37-07:00
CEP-15: (C*) Enhance in-memory FileSystem to work with mmap and support tests to add custom logic
patch by David Capwell; reviewed by Caleb Rackliffe for CASSANDRA-18485
fad1f7457032544ab6a7b40c5d38ecb8b25899bb | Author: Branimir Lambov <branimir.lambov@datastax.com>
| 2023-04-21 11:52:10+03:00
Rename the byte-comparable translation version to OSS50
Also fix some minor issues in ByteComparable.md
patch by Branimir Lambov and Jacek Lewandowski; reviewed by Caleb Rackliffe and Maxwell Guo for CASSANDRA-18398
e5e0f3a8441503107b1ca2128cf8366e5e44d893 | Author: Mike Adamson <mikeatdot@gmail.com>
| 2023-04-13 17:23:13+01:00
Literal on-disk index and index write path (#9)
This commit contains the following additions
to SAI:
- The index write path and index building
based around StorageAttachedIndexBuilder
and StorageAttachedIndexWriter
- The on-disk index versioning using the
SSTable Descriptor analog IndexDescriptor
with Version and OnDiskFormat
- The literal on-disk index using the
LiteralIndexWriter
patch by Mike Adamson; reviewed by Caleb Rackliffe and Andres de la Peña for CASSANDRA-18062
Co-authored-by: Mike Adamson <mikeatdot@gmail.com>
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: Andres de la Peña <a.penya.garcia@gmail.com>
Co-authored-by: Piotr Kołaczkowski <pkolaczk@gmail.com>
Co-authored-by: Jason Rutherglen <jason.rutherglen@gmail.com>
6ed308d6a814826be145f6ba30304ea474bf263e | Author: Alex Petrov <oleksandr.petrov@gmail.com>
| 2023-03-09 17:13:18+01:00
Pull in Cassandra concurrent utils until there is a common shared library
Patch by Alex Petrov; reviewed by Caleb Rackliffe and Abe Ratnofsky for CASSANDRA-18315
cde91e56f09d9ebf315c79c9a81b89f70f4eb724 | Author: Mike Adamson <madamson@datastax.com>
| 2023-01-19 14:24:46+00:00
In-memory index implementation with query path
This includes the following elements of the Storage Attached Index:
- Memtable-attached indexes backed by an in-memory trie structure for byte-comparable values
- Query path for the in-memory index
- Index status propagation
- Randomized testing for Memtable-attached indexes
patch my Mike Adamson; reviewed by Caleb Rackliffe and Andres de la Peña for CASSANDRA-18058
Co-authored-by: Mike Adamson <madamson@datastax.com>
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
f16fb6765b8a3ff8f49accf61c908791520c0d6e | Author: Jacek Lewandowski <lewandowski.jacek@gmail.com>
| 2023-01-03 18:17:13+01:00
Implementation of the trie-indexed SSTable format (BTI) as described in CEP-25.
Documentation in the included BTIFormat.md.
patch by Branimir Lambov and Jacek Lewandowski; reviewed by Caleb Rackliffe and Maxwell Guo for CASSANDRA-18398
488c0c75a8f632f2db4e3db39f2ebcf8a489971e | Author: Stefan Miklosovic <smiklosovic@apache.org>
| 2022-10-11 23:13:13+02:00
Remove empty cq4 log files to prevent BinLog from failing to start
This patch also backports CASSANDRA-17595.
patch by Stefan Miklosovic; reviewed by Caleb Rackliffe for CASSANDRA-17933
8419fb21e016389f15be0954e8721cf4f6918249 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2022-10-04 17:44:34-05:00
Allow pre-V5 global limit on bytes in flight to revert to zero asynchronously in RateLimitingTest
patch by Caleb Rackliffe; reviewed by Brandon Williams for CASSANDRA-17927
4fc2d9e53985dc89b93bbac80bea9faa4a3d708b | Author: Josh McKenzie <jmckenzie@apache.org>
| 2022-09-23 14:04:42-04:00
Include estimated active compaction remaining write size when starting a new compaction
Patch by Marcus Eriksson; reviewed by Chris Lohfink, Stefan Podkowinski, Caleb Rackliffe,and Josh McKenzie for CASSANDRA-17931
Co-authored-by: Marcus Eriksson <marcuse@apache.org>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
bd2ecb3454649d8c84cf0b1ce8c1e94ed1e06e74 | Author: Josh McKenzie <jmckenzie@apache.org>
| 2022-09-15 14:22:34-04:00
Add metrics around storage usage and compression
Patch by Caleb Rackliffe; reviewed by Abe Ratnofsky and Josh McKenzie for CASSANDRA-17898
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
ff5f4833aa3e11fcffd6bff1b15597fd5a38b864 | Author: Josh McKenzie <jmckenzie@apache.org>
| 2022-09-15 13:56:00-04:00
Prevent NullPointerException when changing neverPurgeTombstones from true to false
Patch by Marcus Eriksson; reviewed by Caleb Rackliffe and Josh McKenzie for CASSANDRA-17897
Co-authored-by: Marcus Eriksson <marcuse@apache.org>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
e89b214d069321c8968871b8eb7d51d4dfba7c33 | Author: Josh McKenzie <jmckenzie@apache.org>
| 2022-09-13 12:48:00-04:00
Allow disabling hotness persistence for high sstable counts
Patch by Caleb Rackliffe; reviewed by Chris Lohfink and Josh McKenzie for CASSANDRA-17868
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
d25adb498abde240cc162cfe4a9630c01381c7f9 | Author: David Capwell <dcapwell@apache.org>
| 2022-09-06 16:47:04-07:00
upsert with adder support is not consistent with numbers and strings in LWT
patch by David Capwell; reviewed by Benedict Elliott Smith, Caleb Rackliffe for CASSANDRA-17857
c56952efb570df2b09a7d428319a9b7755a0c387 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2022-09-02 00:04:21-05:00
HintedHandoffAddRemoveNodesTest now accounts for the fact that StorageMetrics.totalHints is not updated synchronously w/ writes
patch by Caleb Rackliffe; reviewed by Ekaterina Dimitrova for CASSANDRA-16679
c4b1c0614e42b4ea2064822d31c28aa5d4f1450a | Author: David Capwell <dcapwell@apache.org>
| 2022-08-19 16:42:56-07:00
Read/Write/Truncate throw RequestFailure in a race condition with callback timeouts, should return Timeout instead
patch by David Capwell; reviewed by Caleb Rackliffe for CASSANDRA-17828
09b282d1fdd7d6d62542137003011d144c0227be | Author: Josh McKenzie <jmckenzie@apache.org>
| 2022-08-11 14:02:27-04:00
Rate-limit new client connection auth setup to avoid overwhelming bcrypt
Patch by Chris Lohfink; reviewed by Caleb Rackliffe, Yifan Cai, and Josh McKenzie for CASSANDRA-17812
Co-authored-by: Chris Lohfink <clohfink@apple.com>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
f5dc9a1c1e27ac5ea0cb972ceaf68d5993804d6f | Author: Brandon Williams <brandonwilliams@apache.org>
| 2022-08-10 08:19:50-05:00
Set default FD in DD client initialization
Patch by Doug Rohrer; reviewed by brandonwilliams and maedhroz for
CASSANDRA-17782
3e0b94565acc64e903d73af3a14b23c875abc5b3 | Author: Josh McKenzie <jmckenzie@apache.org>
| 2022-08-02 16:02:03-04:00
Add support to generate a One-Shot heap dump on unhandled exceptions
Patch by Caleb Rackliffe; reviewed by Josh McKenzie, David Capwell, and Jon Meredith for CASSANDRA-17795
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
0daf21244fc0187d092616834d38df1a77dcabf0 | Author: Josh McKenzie <jmckenzie@apache.org>
| 2022-07-25 11:58:42-04:00
Add JMX call to getSSTableCountPerTWCSBucket for TWCS
Patch by Stefan Podkowinski; reviewed by Caleb Rackliffe and Marcus Eriksson for CASSANDRA-17774
Co-authored-by: Stefan Podkowinski <s.podkowinski@gmail.com>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
d51f90201b2d127166612384a75b4a49da9776d1 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2022-07-12 12:06:56-05:00
Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for in-JVM dtests
patch by Caleb Rackliffe; reviewed by David Capwell for CASSANDRA-17731
dd08314ed654aafa60b2a82fc4953aac171ba3ef | Author: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
| 2022-06-30 17:06:58-04:00
Uncomment prepared_statements_cache_size, key_cache_size, counter_cache_size, index_summary_capacity which were
commented out by mistake in a previous patch;
Fix breaking change with cache_load_timeout; cache_load_timeout_seconds <=0 and cache_load_timeout=0 are equivalent
and they both mean disabled;
Deprecate public method setRate(final double throughputMbPerSec) in Compaction Manager in favor of
setRateInBytes(final double throughputBytesPerSec);
Revert breaking change removal of StressCQLSSTableWriter.Builder.withBufferSizeInMB(int size). Deprecate it in favor
of StressCQLSSTableWriter.Builder.withBufferSizeInMiB(int size);
Fix precision issues, add new -m flag (for nodetool/setstreamthroughput, nodetool/setinterdcstreamthroughput,
nodetool/getstreamthroughput and nodetoo/getinterdcstreamthroughput), add new -d flags (nodetool/getstreamthroughput,
nodetool/getinterdcstreamthroughput, nodetool/getcompactionthroughput);
Fix a bug with precision in nodetool/compactionstats;
Deprecate StorageService methods and add new ones for stream_throughput_outbound, inter_dc_stream_throughput_outbound,
compaction_throughput_outbound in the JMX MBean `org.apache.cassandra.db:type=StorageService`;
Removed getEntireSSTableStreamThroughputMebibytesPerSec in favor of new getEntireSSTableStreamThroughputMebibytesPerSecAsDouble
in the JMX MBean `org.apache.cassandra.db:type=StorageService`;
Removed getEntireSSTableInterDCStreamThroughputMebibytesPerSec in favor of getEntireSSTableInterDCStreamThroughputMebibytesPerSecAsDouble
in the JMX MBean `org.apache.cassandra.db:type=StorageService`
Patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, Francisco Guerrero for CASSANDRA-17225
a9725b681b948f2122f3d48b96a5c4e7403d2c39 | Author: Francisco Guerrero <frank.guerrero@gmail.com>
| 2022-06-29 11:15:10-07:00
Fix AbstractCell#toString throws MarshalException for cell in collection
patch by Francisco Guerrero; reviewed by Caleb Rackliffe, Yifan Cai for CASSANDRA-17695
c3327855e4bf98f8631c959b82bd8470726034a8 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2022-06-27 18:40:40-05:00
Add a virtual table that exposes currently running queries
patch by Chris Lohfink; reviewed by Caleb Rackliffe and Benedict Elliott Smith for CASSANDRA-15241
Co-authored-by: Chris Lohfink <clohfink@apple.com>
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: Benedict Elliott Smith <benedict@apache.org>
89f3978dcde958fbad191b8cf628fd89ace64d7a | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2022-06-27 18:40:40-05:00
Add a virtual table that exposes currently running queries
patch by Chris Lohfink; reviewed by Caleb Rackliffe and Benedict Elliott Smith for CASSANDRA-15241
Co-authored-by: Chris Lohfink <clohfink@apple.com>
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: Benedict Elliott Smith <benedict@apache.org>
5e39c54678b0d70145b5c699593eb9ce7fa7706a | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2022-06-22 17:12:41-06:00
Avoid initializing schema via SystemKeyspace.getPreferredIP() with the BulkLoader tool
patch by Caleb Rackliffe; reviewed by Jon Meredith for CASSANDRA-17740
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: Jon Meredith <jmeredithco@gmail.com>
d3ce825bf2b376fd2516e4b594ddb69037c13159 | Author: David Capwell <dcapwell@apache.org>
| 2022-06-03 14:37:39-07:00
Fix org.apache.cassandra.distributed.test.trackwarnings.TombstoneCountWarningTest.failThresholdSinglePartition
patch by David Capwell; reviewed by Caleb Rackliffe for CASSANDRA-17244
d54646e40957ffc18f651753941fac3068b79f8e | Author: Marcus Eriksson <marcus_eriksson@apple.com>
| 2022-05-27 00:40:44+02:00
UnsupportedOperationException when reducing scope for LCS compactions
patch by Caleb Rackliffe; reviewed by Zhao Yang, Brandon Williams, and Marcus Eriksson for CASSANDRA-19704
Co-authored-by: Marcus Eriksson <marcuse@apache.org>
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
a00d8fd5ba9d73a377d1a11e6f540c56d66e9c8f | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2022-05-25 17:08:25-05:00
Ensure FileStreamTask cannot compromise shared channel proxy for system table when interrupted
patch by Caleb Rackliffe; reviewed by Jon Meredith and David Capwell for CASSANDRA-17663
ffc4c89c3df7ad0ae73ebefdcb7e15a2790c0a52 | Author: Doug Rohrer <drohrer@apple.com>
| 2022-05-17 15:09:16-04:00
Fix issue where frozen maps may not be serialized in the correct order
patch by Doug Rohrer, Francisco Guerrero and Yifan Cai; reviewed by Andrés de la Peña and Caleb Rackliffe for CASSANDRA-17623
Co-authored-by: Doug Rohrer <drohrer@apple.com>
Co-authored-by: Francisco Guerrero <frank.guerrero@gmail.com>
Co-authored-by: Yifan Cai <ycai@apache.org>
3409e5d9b341de2114d6410225922843539d4172 | Author: David Capwell <dcapwell@apache.org>
| 2022-04-22 18:35:26-07:00
Enhance SnakeYAML properties to be reusable outside of YAML parsing, support camel case conversion to snake case, and add support to ignore properties
patch by David Capwell; reviewed by Caleb Rackliffe, Stefan Miklosovic for CASSANDRA-17166
7db3285e7b745e591dc4c405ae9af6c1cddb0c79 | Author: David Capwell <dcapwell@apache.org>
| 2022-04-20 15:15:34-07:00
Migrate track_warnings to more standard naming conventions and use latest configuration types rather than long
patch by David Capwell; reviewed by Andres de la Peña, Caleb Rackliffe for CASSANDRA-17560
af90c3634007ba9b2967267d6f8383d38cdff85f | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2022-04-05 15:20:28-05:00
Reduce histogram snapshot long[] allocation overhead during speculative read and write threshold updates
patch by Caleb Rackliffe; reviewed by Josh McKenzie for CASSANDRA-17523
a67a2a2441589e8bf41498c426fddacd7b9719cf | Author: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
| 2022-04-04 18:27:43-04:00
Handle config parameters upper bound on startup; Fix auto_snapshot_ttl and paxos_purge_grace_period min unit validations
patch by Ekaterina Dimitrova and Andres de la Pena; reviewed by Andres de la Pena and Caleb Rackliffe for CASSANDRA-17571
Co-authored-by: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
Co-authored-by: Andrés de la Peña <a.penya.garcia@gmail.com>
dac738d2eba8629d4f482d7cbfd855d2c5b9df47 | Author: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
| 2022-03-22 19:56:52-04:00
Transfer config parameters to the new types; Fix corner case for permissions_update_interval, roles_update_interval, credentials_update_interval;Fix typo in Config annotation; Made Converters type safe and fixed a few cases where converters used the wrong type; o should be provided with unit to DataStorageSpec and DurationStorageSpec; Fix null bug in DataStorageSpec and DurationSpec
patch by Ekaterina Dimitrova, David Capwell; reviewed by David Capwell and Caleb Rackliffe for CASSANDRA-17431
Co-authored-by: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
Co-authored-by: David Capwell <dcapwell@apache.org>
0089858819c9f06b0bee5bccf993ae7f5977d7f1 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2022-03-15 18:08:09-05:00
Shut repair task executor down without interruption to avoid compromising shared channel proxies
patch by Caleb Rackliffe; reviewed by David Capwell, Marcus Eriksson, and Josh McKenzie for CASSANDRA-17466
57ab3afcf16970047d3df4656241cf0705e94bee | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2022-03-14 17:13:47-05:00
reduce hot-path object allocations required to record local/remote requests against the client request metrics
patch by Caleb Rackliffe; reviewed by Jon Meredith for CASSANDRA-17424
Co-authored-by: Marcus Eriksson <marcuse@apache.org>
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
4ea3e4c5050ba11a5b7897af74bb54e7e8dad068 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2022-03-14 16:21:12-05:00
Add native transport rate limiter options to example cassandra.yaml, and expose metric for dispatch rate
patch by Caleb Rackliffe; reviewed by Josh McKenzie for CASSANDRA-17423
cd6533401282e0455f87ba4d4a58bfec18fde4dc | Author: maedhroz <calebrackliffe@gmail.com>
| 2022-03-14 13:35:11-05:00
Update SUPPORTED_UPGRADE_PATHS to include 3.0 and 3.x to 4.1 paths and remove obsolete tests
patch by Caleb Rackliffe; reviewed by Mick Semb Wever for CASSANDRA-17362
a41040ccdcec651bffb4d23843ab9be2d96ba1d1 | Author: Andrés de la Peña <a.penya.garcia@gmail.com>
| 2022-03-11 15:36:39+00:00
Add guardrails for read/write consistency levels
patch by Andrés de la Peña; reviewed by Caleb Rackliffe for CASSANDRA-17188
Co-authored-by: Andrés de la Peña <a.penya.garcia@gmail.com>
Co-authored-by: Aleksandr Sorokoumov <aleksandr.sorokoumov@gmail.com>
302c6fcf59c5fa9fcd475b2c811ad57ae7c45f49 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2022-03-10 17:12:47-06:00
Update SUPPORTED_UPGRADE_PATHS to include 3.0 and 3.x to 4.1 paths and remove obsolete tests
patch by Caleb Rackliffe; reviewed by Mick Semb Wever for CASSANDRA-17362
7b91e4cc18e77fa5862864fcc1150fd1eb86a01a | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2022-03-10 16:19:45-06:00
Remove all usages of junit.framework and ban them via Checkstyle
patch by Caleb Rackliffe; reviewed by Marcus Eriksson for CASSANDRA-17316
Co-authored-by: Marcus Eriksson <marcuse@apache.org>
9f56bf4ca7fdb61ad09e5f2ad09b87cd01e0716b | Author: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
| 2022-02-05 17:51:32-05:00
Remove old Duration class in favor of DurationSpec class
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23 | Author: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
| 2022-02-05 17:15:18-05:00
Bulk change of units around the code to support the move to the new configuration framework
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
230fe8e64722ac02dbf8cdafb7d4fef120726dd7 | Author: Abe Ratnofsky <abe@aber.io>
| 2022-02-04 11:15:42-08:00
Include Git SHA in --verbose flag for nodetool version
Patch by Abe Ratnofsky; review by Brandon Williams, Caleb Rackliffe, Michael Semb Wever and Stefan Miklosovic for CASSANDRA-17753
df16b3750dc2c1b6b9bcdece6f81dfd3de7ebdfa | Author: David Capwell <dcapwell@apache.org>
| 2022-02-04 10:15:58-08:00
When streaming sees a ClosedChannelException this triggers the disk failure policy
patch by David Capwell, Francisco Guerrero; reviewed by Caleb Rackliffe, Dinesh Joshi for CASSANDRA-17116
0448f15e3db392f2f60db332fabf6309aa3d5089 | Author: David Capwell <David Capwell>
| 2022-02-04 10:15:46-08:00
When streaming sees a ClosedChannelException this triggers the disk failure policy
patch by David Capwell, Francisco Guerrero; reviewed by Caleb Rackliffe, Dinesh Joshi for CASSANDRA-17116
6d5203615f7a9670cb1698b74123666bc25ba471 | Author: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
| 2022-02-04 00:25:14-05:00
Transfer parameters to the newly introduced configuration framework (7)
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
23138252f20891c26a3692664c6affaf99e86541 | Author: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
| 2022-02-03 23:49:50-05:00
Transfer parameters to the newly introduced configuration framework (6)
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
1315d0c96f4625a76296f58d431f97669e5178c2 | Author: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
| 2022-02-03 22:28:41-05:00
Transfer parameters to the newly introduced configuration framework (5)
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
ed48f3c017c5e572a523890bcd5b7c798d7eb358 | Author: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
| 2022-02-03 16:43:36-05:00
Transfer parameters to the newly introduced configuration framework (4)
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
755fd9446b084e659e98bd7336b9e910c2e12577 | Author: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
| 2022-02-03 14:39:48-05:00
Transfer parameters to the newly introduced configuration framework (3)
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
d85f7f7c2dd4b9bbdb44bc96235e6a8bc3ff3967 | Author: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
| 2022-02-03 00:19:28-05:00
Transfer parameters to the newly introduced configuration framework (2)
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
9ff28fc717e7926b5cf7c8acc85a35e0cfb43595 | Author: Jon Meredith <https://jonmeredith@apache.org>
| 2022-02-02 17:09:42-07:00
Fixes for intermittent in-JVM dtest failures
patch by Jon Meredith, Caleb Rackliffe, Marcus Eriksson, Benedict Elliott Smith <benedict@apache.org>; reviewed by Caleb Rackliffe for CASSANDRA-17256
b9e2ab75f8f6dedd45c6ad7a83b3160149869262 | Author: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
| 2022-02-02 12:47:41-05:00
Extend DurationSpec and DataStorageSpec for smallest unit and transfer denylist parameters to the new framework
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
a3258d66bcc9f946304c19d59e75d2721126303e | Author: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
| 2022-02-01 17:14:17-05:00
Transfer parameters to the newly introduced configuration framework (1)
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
5bb4bab12f8edfef95ed13cbabf8c0f377986065 | Author: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
| 2022-01-31 21:51:49-05:00
DataRate parameters transition to the new framework
Fix the DB descriptorRefTest which failed on the previous commit
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
85c202d8a8b037791db08c531f4f3c8336c82696 | Author: Marcus Eriksson <marcuse@apache.org>
| 2022-01-21 09:02:10+01:00
Lazy transaction log replica creation allows incorrect replica content divergence during anticompaction
Patch by marcuse; reviewed by Caleb Rackliffe for CASSANDRA-17273
db9f7a67ec4b03413c10034956e2cf18739ca4b1 | Author: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
| 2021-12-14 23:00:56-05:00
Add new custom types and unit tests for configuration
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
275f188660b66743bf3f055c8d7da438ad826061 | Author: Alex Petrov <oleksandr.petrov@gmail.com>
| 2021-11-25 08:45:00+01:00
Features:
* Implement lookbehind via tracker callbacks
* Improve DSL
* Rename maxLts to peek
* Split lts visitors from visitors
* Allow create table if not exists
* Allow sampler to be triggered at every LTS
* Allow local state validator to always run
* Add Staged Runner
* Add wait for token ranges
* Make keyspace DDL configurable
* Rename PartitionVisitor to Visitor
Bugfixes:
* Fix for queue draining
* Fix distribution of the single-op values
* Fix bug in schema helper: static columns are listed as duplicates
Patch by Alex Petrov for CASSANDRA-16262
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
3935906a685640b2f6a2058b38fdf45d917edfc9 | Author: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
| 2021-11-19 17:42:29-05:00
Fixes needed to support the new configuration framework and change of parameters
patch by Ekaterina Dimitrova, reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
562cb26010659830dd1192939ac815a0f6cb3502 | Author: Branimir Lambov <branimir.lambov@datastax.com>
| 2021-11-11 15:39:21+02:00
MemtableTrie using multiple buffers
The replaces the size doubling and copying required to grow the trie
with an allocation of a new buffer. This improves the cost of expansion
at the expense of increasing individual read and write costs.
patch by Branimir Lambov; reviewed by Jason Rutherglen, Jacek Lewandowski, Andres de la Peña and Caleb Rackliffe for CASSANDRA-17240
49e0c61107005b1a83799f7f1e6c0a855d159c29 | Author: Branimir Lambov <branimir.lambov@datastax.com>
| 2021-11-09 13:59:48+02:00
Further improves precision of memtable heap tracking
Partition key ByteBuffer and columns btree were not taken
into account and some ByteBuffers were not measured correctly.
Also fixes flakes in MemtableSizeTest caused by including
allocator pool in measurements and updates it to test all
memtable allocation types.
patch by Branimir Lambov; reviewed by Ekaterina Dimitrova, Andres de la Peña and Caleb Rackliffe for CASSANDRA-17240
10103d353c3d63505cb119cda0e38e692cdb1809 | Author: Josh McKenzie <jmckenzie@apache.org>
| 2021-09-30 12:10:46-04:00
Add required -f option to nodetool verify
Patch by Josh McKenzie; reviewed by Marcus Eriksson, Berenguer Blasi, and Caleb Rackliffe for CASSANDRA-17017
Co-authored by Josh McKenzie <jmckenzie@apache.org>
Co-authored by Chris Lohfink <clohfink@apple.com>
89c6addb505392ef3434597b61f83da25d13e3e2 | Author: Josh McKenzie <jmckenzie@apache.org>
| 2021-09-15 10:52:46-04:00
Prewarm role and credentials caches to avoid timeouts at startup
Patch by Blake Eggleston; reviewed by Sam Tunnicliffe, Jason Brown, and Caleb Rackliffe for CASSANDRA-16958
Co-authored by: Blake Eggleston <bdeggleston@gmail.com>
Co-authored by: Josh McKenzie <jmckenzie@apache.org>
f0280fb6f863582125bfd16b8a90c345972c4a8c | Author: Aleksey Yeschenko <aleksey@apache.org>
| 2021-09-01 12:22:31-04:00
Backport of CASSANDRA-16905 Further restrict schema column drop/recreate conversions
patch by Aleksey Yeschenko; reviewed by Blake Eggleston, Sam Tunnicliffe, and Caleb Rackliffe for CASSANDRA-16905
Co-authored by Aleksey Yeschenko (aleksey@apache.org)
Co-authored by Josh McKenzie (jmckenzie@apache.org)
60b54425edc0a328bc1baf00c2e5bf111d4b9da8 | Author: Jakub Żytka <jakub.zytka@datastax.com>
| 2021-05-11 10:01:12+02:00
Fix commitLogUpperBound initialization in AbstractMemtableWithCommitlog
so that it is always available when writeBarrier gets initialized.
Harden Memtable API so that it is apparent that getting commitLogUpperBound
is valid only after it is fully established.
patch by Jakub Żytka and Dan Jatnieks;
reviewed by Dan Jatnieks, Jeremiah D Jordan and Caleb Rackliffe for CASSANDRA-17587
7c55c73825e341315e520381968338d57afbb67a | Author: Branimir Lambov <branimir.lambov@datastax.com>
| 2021-01-20 15:42:36+02:00
Adds a trie-based memtable implementation
patch by Branimir Lambov; reviewed by Jason Rutherglen, Jacek Lewandowski, Andres de la Peña and Caleb Rackliffe for CASSANDRA-17240
7c55c73825e341315e520381968338d57afbb67a | Author: Branimir Lambov <branimir.lambov@datastax.com>
| 2021-01-20 15:42:36+02:00
Adds a trie-based memtable implementation
patch by Branimir Lambov; reviewed by Jason Rutherglen, Jacek Lewandowski, Andres de la Peña and Caleb Rackliffe for CASSANDRA-17240
e966c45afcf8bef47df245ccb851386e5ce60505 | Author: jacek-lewandowski <jacek.lewandowski@datastax.com>
| 2020-11-06 14:59:56+01:00
ByteComparable API
Provides an API for converting all values of types that can be used in
primary keys to byte sequences that can be compared lexicographically
by unsigned byte value (i.e. byte-comparable sequences) and back.
patch by Branimir Lambov, Dimitar Dimitrov and Jacek Lewandowski;
reviewed by Caleb Rackliffe, Dimitar Dimitrov, Jacek Lewandowski and Aleksey Yeschenko for CASSANDRA-6936
b4f1c6d250991fc27c5f87a2dc0fd81e7ad0d272 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2020-05-28 14:26:25-06:00
Safer handling of out-of-range tokens
patch by Caleb Rackliffe; reviewed by Mick Semb Wever for CASSANDRA-13704
Co-authored-by: Sam Tunnicliffe <sam@beobal.com>
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: Mick Semb Wever <mck@apache.org>
Co-authored-by: Ariel Weisberg <aweisberg@apple.com>
303ca55a5dc9079071cd5459aa9c9abf0b3b2991 | Author: Zhao Yang <zhaoyangsingapore@gmail.com>
| 2020-05-19 17:08:36+08:00
Add Index Group Interface for Storage Attached Index
patch by Zhao Yang; reviewed by Caleb Rackliffe and Andres de la Peña for CASSANDRA-16092
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: Andres de la Peña <a.penya.garcia@gmail.com>