CodeNarc Report

[MSG]Code block ends with a blank line.

[SRC]}

[MSG]File GPeriodServices.groovy does not end with a newline

[SRC]fixedAssetMaint = from("FixedAssetMaint").where("schedul..queryFirst()

[MSG]The String 'FixedAssetMaint' can be wrapped in single quotes instead of double quotes

[SRC]fixedAssetMaint = from("FixedAssetMaint").where("schedul..queryFirst()

[MSG]The String 'scheduleWorkEffortId' can be wrapped in single quotes instead of double quotes

[MSG]File FixedAssetMaintServices.groovy has consecutive blank lines

[SRC]* @return

[MSG]The javadoc @return tag is empty

[SRC]def createFixedAssetMaintUpdateWorkEffort() {

[MSG]Method "createFixedAssetMaintUpdateWorkEffort" has a dynamic return type

[SRC]def createFixedAssetMaintUpdateWorkEffort() {

[MSG]def for method return type should not be used

[SRC]

[MSG]Line ends with whitespace characters

[SRC]* @return

[MSG]The javadoc @return tag is empty

[SRC]def updateFixedAssetMaintAndWorkEffort() {

[MSG]Method "updateFixedAssetMaintAndWorkEffort" has a dynamic return type

[SRC]def updateFixedAssetMaintAndWorkEffort() {

[MSG]def for method return type should not be used

[SRC]* @return

[MSG]The javadoc @return tag is empty

[SRC]def createWorkEffortAndAssocWithParent() {

[MSG]Method "createWorkEffortAndAssocWithParent" has a dynamic return type

[SRC]def createWorkEffortAndAssocWithParent() {

[MSG]def for method return type should not be used

[SRC]* @return

[MSG]The javadoc @return tag is empty

[SRC]def assetMaintPermissionCheck() {

[MSG]Method "assetMaintPermissionCheck" has a dynamic return type

[SRC]def assetMaintPermissionCheck() {

[MSG]def for method return type should not be used

[SRC]facility = fixedAsset.getRelatedOne("LocatedAtFacility", false)

[MSG]The String 'LocatedAtFacility' can be wrapped in single quotes instead of double quotes

[SRC]fixedAssetIdents = from("FixedAssetIdent").where("fixedA...queryList()

[MSG]The String 'FixedAssetIdent' can be wrapped in single quotes instead of double quotes

[SRC]fixedAssetIdents = from("FixedAssetIdent").where("fixedA...queryList()

[MSG]The String 'fixedAssetId' can be wrapped in single quotes instead of double quotes

[SRC]fixedAssetIdentValue = ""

[MSG]The String '' can be wrapped in single quotes instead of double quotes

[SRC]fixedAssetIdentValue = fixedAssetIdentValue + " " + ident.idValue

[MSG]The String ' ' can be wrapped in single quotes instead of double quotes

[SRC]status = fixedAssetMaint.getRelatedOne("StatusItem", false)

[MSG]The String 'StatusItem' can be wrapped in single quotes instead of double quotes

[SRC]intervalUom = fixedAssetMaint.getRelatedOne("IntervalUom", false)

[MSG]The String 'IntervalUom' can be wrapped in single quotes instead of double quotes

[SRC]productMaint = from("ProductMaint").where("productId", i..).queryOne()

[MSG]The String 'ProductMaint' can be wrapped in single quotes instead of double quotes

[SRC]productMaint = from("ProductMaint").where("productId", i..).queryOne()

[MSG]The String 'productId' can be wrapped in single quotes instead of double quotes

[SRC]productMaint = from("ProductMaint").where("productId", i..).queryOne()

[MSG]The String 'productMaintSeqId' can be wrapped in single quotes instead of double quotes

[SRC]productMaintType = from("ProductMaintType").where("produ..).queryOne()

[MSG]The String 'ProductMaintType' can be wrapped in single quotes instead of double quotes

[SRC]productMaintType = from("ProductMaintType").where("produ..).queryOne()

[MSG]The String 'productMaintTypeId' can be wrapped in single quotes instead of double quotes

[SRC]productMeterTypeDesc = ""

[MSG]The String '' can be wrapped in single quotes instead of double quotes

[SRC]productMeterType = from("ProductMeterType").where("produ..).queryOne()

[MSG]The String 'ProductMeterType' can be wrapped in single quotes instead of double quotes

[SRC]productMeterType = from("ProductMeterType").where("produ..).queryOne()

[MSG]The String 'productMeterTypeId' can be wrapped in single quotes instead of double quotes

[SRC]scheduleWorkEffort = fixedAssetMaint.getRelatedOne("Sche..ort", false)

[MSG]The String 'ScheduleWorkEffort' can be wrapped in single quotes instead of double quotes

[SRC]if (!maintHistSeqId) {

[MSG]Code could use elvis operator: maintHistSeqId = maintHistSeqId ?: parameters.maintHistSeqId

[SRC]if (!fixedAssetId) {

[MSG]Code could use elvis operator: fixedAssetId = fixedAssetId ?: parameters.fixedAssetId

[SRC]if (!workEffortId) {

[MSG]Code could use elvis operator: workEffortId = workEffortId ?: parameters.workEffortId

[SRC]workEffort = from("WorkEffort").where("workEffortId", wo..).queryOne()

[MSG]The String 'WorkEffort' can be wrapped in single quotes instead of double quotes

[SRC]workEffort = from("WorkEffort").where("workEffortId", wo..).queryOne()

[MSG]The String 'workEffortId' can be wrapped in single quotes instead of double quotes

[SRC]if (!fixedAssetId) {

[MSG]Code could use elvis operator: fixedAssetId = fixedAssetId ?: workEffort.fixedAssetId

[SRC]parentWorkEffort = from("WorkEffortAssoc").where("workEf..queryFirst()

[MSG]The String 'WorkEffortAssoc' can be wrapped in single quotes instead of double quotes

[SRC]parentWorkEffort = from("WorkEffortAssoc").where("workEf..queryFirst()

[MSG]The String 'workEffortIdTo' can be wrapped in single quotes instead of double quotes

[SRC]parentWorkEffort = from("WorkEffortAssoc").where("workEf..queryFirst()

[MSG]The String 'WorkEffortAssoc' can be wrapped in single quotes instead of double quotes

[SRC]parentWorkEffort = from("WorkEffortAssoc").where("workEf..queryFirst()

[MSG]The String 'workEffortIdTo' can be wrapped in single quotes instead of double quotes

[SRC]if (!rootWorkEffortId) {

[MSG]Code could use elvis operator: rootWorkEffortId = rootWorkEffortId ?: workEffortId

[SRC]fixedAssetMaint = from("FixedAssetMaint").where("schedul..queryFirst()

[MSG]The String 'FixedAssetMaint' can be wrapped in single quotes instead of double quotes

[SRC]fixedAssetMaint = from("FixedAssetMaint").where("schedul..queryFirst()

[MSG]The String 'scheduleWorkEffortId' can be wrapped in single quotes instead of double quotes

[SRC]if (!fixedAssetId) {

[MSG]Code could use elvis operator: fixedAssetId = fixedAssetId ?: fixedAssetMaint.fixedAssetId

[SRC]fixedAsset = from("FixedAsset").where("fixedAssetId", fi..).queryOne()

[MSG]The String 'FixedAsset' can be wrapped in single quotes instead of double quotes

[SRC]fixedAsset = from("FixedAsset").where("fixedAssetId", fi..).queryOne()

[MSG]The String 'fixedAssetId' can be wrapped in single quotes instead of double quotes

[SRC]while (iterator = listIterator.next()) {

[MSG]Assignment used as conditional value, which always results in true. Use the == operator instead

[SRC]while (iterator = listIterator.next()) {

[MSG]Assignment used as conditional value, which always results in true. Use the == operator instead

[SRC]while (iterator = listIterator.next()) {

[MSG]Assignment used as conditional value, which always results in true. Use the == operator instead

[SRC]while (party = parties.next()) {

[MSG]Assignment used as conditional value, which always results in true. Use the == operator instead

[SRC]import org.apache.ofbiz.common.CommonWorkers

[SRC]import org.apache.ofbiz.content.content.ContentSearchSession

[SRC]import org.apache.ofbiz.content.content.ContentSearchSession

[SRC]import org.apache.ofbiz.content.content.ContentSearchEvents

[SRC]while (content = contents.next()) {

[MSG]Assignment used as conditional value, which always results in true. Use the == operator instead

[SRC]import org.apache.ofbiz.content.content.ContentKeywordIndex

[SRC]long contentsUpdated = contentCreatedList.stream().filte..'Y'}.count()

[MSG]The opening brace for the closure in class org.apache.ofbiz.content.content.None is not followed by a space or whitespace

[SRC]long contentsUpdated = contentCreatedList.stream().filte..'Y'}.count()

[MSG]The closing brace for the closure in class org.apache.ofbiz.content.content.None is not preceded by a space or whitespace

[SRC]* @param parentProductCategoryId

[MSG]The description for the javadoc @param tag is missing

[SRC]* @return

[MSG]The javadoc @return tag is empty

[SRC]* @param contentId

[MSG]The description for the javadoc @param tag is missing

[SRC]* @return

[MSG]The javadoc @return tag is empty

[MSG]Code block starts with a blank line.

[SRC]* @return

[MSG]The javadoc @return tag is empty

[SRC]dataResource.removeRelated("ElectronicText")

[MSG]The String 'ElectronicText' can be wrapped in single quotes instead of double quotes

[SRC]dataResource.removeRelated("ImageDataResource")

[MSG]The String 'ImageDataResource' can be wrapped in single quotes instead of double quotes

[SRC]dataResource.removeRelated("OtherDataResource")

[MSG]The String 'OtherDataResource' can be wrapped in single quotes instead of double quotes

[SRC]dataResource.removeRelated("VideoDataResource")

[MSG]The String 'VideoDataResource' can be wrapped in single quotes instead of double quotes

[SRC]dataResource.removeRelated("DataResourceRole")

[MSG]The String 'DataResourceRole' can be wrapped in single quotes instead of double quotes

[SRC]* @return

[MSG]The javadoc @return tag is empty

[SRC]textData : getElectronicTextResult.textData]

[MSG]The colon for the literal Map entry for key [textData] within class org.apache.ofbiz.content.content.None is not preceded by a match for regular expression [\S]

[SRC]* @return

[MSG]The javadoc @return tag is empty

[SRC]import org.apache.ofbiz.content.data.DataResourceWorker

[SRC]import org.apache.ofbiz.content.survey.SurveyWrapper

[SRC]import org.apache.ofbiz.content.survey.SurveyWrapper

[SRC]ebayConfigList = from("EbayConfig").queryList()

[MSG]The String 'EbayConfig' can be wrapped in single quotes instead of double quotes

[SRC]prodCatalog = from("ProdCatalog").where("prodCatalogId",..).queryOne()

[MSG]The String 'ProdCatalog' can be wrapped in single quotes instead of double quotes

[SRC]prodCatalog = from("ProdCatalog").where("prodCatalogId",..).queryOne()

[MSG]The String 'prodCatalogId' can be wrapped in single quotes instead of double quotes

[SRC]if (!topCategory) {

[MSG]Code could use elvis operator: topCategory = topCategory ?: CatalogWorker.getCatalogTopCategoryId(request, currentCatalogId)

[SRC]CategoryWorker.getRelatedCategories(request, "topLevelLi..egory, true)

[MSG]The String 'topLevelList' can be wrapped in single quotes instead of double quotes

[SRC]if (request.getAttribute("topLevelList")) {

[MSG]The String 'topLevelList' can be wrapped in single quotes instead of double quotes

[SRC]categoryList = request.getAttribute("topLevelList")

[MSG]The String 'topLevelList' can be wrapped in single quotes instead of double quotes

[SRC]categoryIds = EntityUtil.getFieldListFromEntityList(cate..ryId", true)

[MSG]The String 'productCategoryId' can be wrapped in single quotes instead of double quotes

[SRC]session.setAttribute("orderList", parameters.orderList)

[MSG]The String 'orderList' can be wrapped in single quotes instead of double quotes

[SRC]if (!"Y".equals(categoryCode.substring(0, 1)) && !"".equ..goryCode)) {

[MSG]Violation in class org.apache.ofbiz.ebay.None. Explicit call to Y.equals(categoryCode.substring(0, 1)) method can be rewritten as (Y == (categoryCode.substring(0, 1)))

[SRC]if (!"Y".equals(categoryCode.substring(0, 1)) && !"".equ..goryCode)) {

[MSG]Violation in class org.apache.ofbiz.ebay.None. Explicit call to .equals(categoryCode) method can be rewritten as ( == (categoryCode))

[MSG]Blank line precedes package declaration in file ProductsExportToEbayScript.groovy

[SRC]webSiteList = from("WebSite").where("productStoreId", pr...queryList()

[MSG]The String 'WebSite' can be wrapped in single quotes instead of double quotes

[SRC]webSiteList = from("WebSite").where("productStoreId", pr...queryList()

[MSG]The String 'productStoreId' can be wrapped in single quotes instead of double quotes

[SRC]webSite = from("WebSite").where("webSiteId", parameters...).queryOne()

[MSG]The String 'WebSite' can be wrapped in single quotes instead of double quotes

[SRC]webSite = from("WebSite").where("webSiteId", parameters...).queryOne()

[MSG]The String 'webSiteId' can be wrapped in single quotes instead of double quotes

[SRC]countryCode = "US"

[MSG]The String 'US' can be wrapped in single quotes instead of double quotes

[SRC]eBayConfig = from("EbayConfig").where("productStoreId", ..).queryOne()

[MSG]The String 'EbayConfig' can be wrapped in single quotes instead of double quotes

[SRC]eBayConfig = from("EbayConfig").where("productStoreId", ..).queryOne()

[MSG]The String 'productStoreId' can be wrapped in single quotes instead of double quotes

[SRC]context.webSiteUrl = webSite.getString("standardContentPrefix")

[MSG]The String 'standardContentPrefix' can be wrapped in single quotes instead of double quotes

[SRC]

[MSG]Line ends with whitespace characters

[SRC]

[MSG]Line ends with whitespace characters

[SRC]results = runService('getEbayCategories', [categoryCode ..uctStoreId])

[MSG]The colon for the literal Map entry for key [categoryCode] within class org.apache.ofbiz.ebay.None is not preceded by a match for regular expression [\S]

[SRC]results = runService('getEbayCategories', [categoryCode ..uctStoreId])

[MSG]The colon for the literal Map entry for key [userLogin] within class org.apache.ofbiz.ebay.None is not preceded by a match for regular expression [\S]

[SRC]results = runService('getEbayCategories', [categoryCode ..uctStoreId])

[MSG]The colon for the literal Map entry for key [productStoreId] within class org.apache.ofbiz.ebay.None is not preceded by a match for regular expression [\S]

[SRC]

[MSG]Line ends with whitespace characters

[SRC]

[MSG]Line ends with whitespace characters

[SRC]if (!"Y".equals(categoryCode.substring(0, 1)) && !"".equ..goryCode)) {

[MSG]The String 'Y' can be wrapped in single quotes instead of double quotes

[SRC]if (!"Y".equals(categoryCode.substring(0, 1)) && !"".equ..goryCode)) {

[MSG]The String '' can be wrapped in single quotes instead of double quotes

[SRC]context.hideExportOptions = "Y"

[MSG]The String 'Y' can be wrapped in single quotes instead of double quotes

[SRC]context.hideExportOptions = "N"

[MSG]The String 'N' can be wrapped in single quotes instead of double quotes

[SRC]context.hideExportOptions = "N"

[MSG]The String 'N' can be wrapped in single quotes instead of double quotes

[SRC]}

[MSG]Line ends with whitespace characters

[SRC]if (session.getAttribute("orderList")) {

[MSG]The String 'orderList' can be wrapped in single quotes instead of double quotes

[SRC]session.removeAttribute("orderList")

[MSG]The String 'orderList' can be wrapped in single quotes instead of double quotes

[SRC]return "success"

[MSG]The String 'success' can be wrapped in single quotes instead of double quotes

[SRC]if (catalogStyleSheet) globalContext.catalogStyleSheet =..ogStyleSheet

[MSG]The if statement lacks braces

[SRC]if (catalogHeaderLogo) globalContext.catalogHeaderLogo =..ogHeaderLogo

[MSG]The if statement lacks braces

[SRC]import java.util.*

[MSG]Wildcard (star) import

[SRC]import java.util.*

[SRC]import org.apache.ofbiz.base.util.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.entity.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.common.CommonWorkers

[MSG]The [org.apache.ofbiz.common.CommonWorkers] import is never referenced

[SRC]import org.apache.ofbiz.order.shoppingcart.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.webapp.control.*

[MSG]Wildcard (star) import

[SRC]globalContext.checkLoginUrl = LoginWorker.makeLoginUrl(r..checkLogin")

[MSG]The String 'checkLogin' can be wrapped in single quotes instead of double quotes

[SRC]import org.apache.ofbiz.base.util.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.common.CommonWorkers

[MSG]The [org.apache.ofbiz.common.CommonWorkers] import is never referenced

[SRC]import org.apache.ofbiz.webapp.control.*

[MSG]Wildcard (star) import

[SRC]context.autoUserLogin = session.getAttribute("autoUserLogin")

[MSG]The String 'autoUserLogin' can be wrapped in single quotes instead of double quotes

[SRC]context.autoLogoutUrl = LoginWorker.makeLoginUrl(request..autoLogout")

[MSG]The String 'autoLogout' can be wrapped in single quotes instead of double quotes

[SRC]previousParams = session.getAttribute("_PREVIOUS_PARAMS_")

[MSG]The String '_PREVIOUS_PARAMS_' can be wrapped in single quotes instead of double quotes

[SRC]previousParams = UtilHttp.stripNamedParamsFromQueryStrin.."PASSWORD"])

[MSG]The String 'USERNAME' can be wrapped in single quotes instead of double quotes

[SRC]previousParams = UtilHttp.stripNamedParamsFromQueryStrin.."PASSWORD"])

[MSG]The String 'PASSWORD' can be wrapped in single quotes instead of double quotes

[SRC]previousParams = "?" + previousParams

[MSG]The String '?' can be wrapped in single quotes instead of double quotes

[SRC]previousParams = ""

[MSG]The String '' can be wrapped in single quotes instead of double quotes

[SRC]import org.apache.ofbiz.product.catalog.*

[MSG]Wildcard (star) import

[SRC]request.setAttribute("productCategoryId", promoCat)

[MSG]The String 'productCategoryId' can be wrapped in single quotes instead of double quotes

[SRC]if ("EXT_OFFLINE".equals(paymentMethodTypeId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.None. Explicit call to EXT_OFFLINE.equals(paymentMethodTypeId) method can be rewritten as (EXT_OFFLINE == (paymentMethodTypeId))

[SRC]import java.util.ArrayList

[SRC]import java.util.ArrayList

[MSG]The [java.util.ArrayList] import is never referenced

[SRC]import java.util.HashMap

[SRC]import java.util.HashMap

[MSG]The [java.util.HashMap] import is never referenced

[SRC]import java.util.List

[SRC]import java.util.List

[MSG]The [java.util.List] import is never referenced

[SRC]import java.util.Map

[SRC]import java.util.Map

[MSG]The [java.util.Map] import is never referenced

[SRC]import org.apache.ofbiz.base.util.UtilMisc

[MSG]The [org.apache.ofbiz.base.util.UtilMisc] import is never referenced

[SRC]import org.apache.ofbiz.entity.Delegator

[MSG]The [org.apache.ofbiz.entity.Delegator] import is never referenced

[SRC]import org.apache.ofbiz.entity.GenericValue

[MSG]The [org.apache.ofbiz.entity.GenericValue] import is never referenced

[SRC]import org.apache.ofbiz.order.shoppingcart.ShoppingCart

[MSG]The [org.apache.ofbiz.order.shoppingcart.ShoppingCart] import is never referenced

[SRC]import org.apache.ofbiz.service.LocalDispatcher

[MSG]The [org.apache.ofbiz.service.LocalDispatcher] import is never referenced

[SRC]dispatcher = request.getAttribute("dispatcher")

[MSG]The String 'dispatcher' can be wrapped in single quotes instead of double quotes

[SRC]delegator = request.getAttribute("delegator")

[MSG]The String 'delegator' can be wrapped in single quotes instead of double quotes

[SRC]paymentMethodId = request.getAttribute("paymentMethodId")

[MSG]The String 'paymentMethodId' can be wrapped in single quotes instead of double quotes

[SRC]if ("EXT_OFFLINE".equals(paymentMethodTypeId)) {

[MSG]The String 'EXT_OFFLINE' can be wrapped in single quotes instead of double quotes

[SRC]paymentMethodId = "EXT_OFFLINE"

[MSG]The String 'EXT_OFFLINE' can be wrapped in single quotes instead of double quotes

[SRC]isSingleUsePayment = "Y".equalsIgnoreCase(singleUsePayment) ?: false

[MSG]The String 'Y' can be wrapped in single quotes instead of double quotes

[SRC]doAppendPayment = "Y".equalsIgnoreCase(appendPayment) ?: false

[MSG]The String 'Y' can be wrapped in single quotes instead of double quotes

[SRC]if ("Y".equalsIgnoreCase(addGiftCard)) {

[MSG]The String 'Y' can be wrapped in single quotes instead of double quotes

[SRC]selPaymentMethods = [paymentMethodTypeId : null]

[MSG]The colon for the literal Map entry for key [paymentMethodTypeId] within class org.apache.ofbiz.ecommerce.None is not preceded by a match for regular expression [\S]

[SRC]return "error"

[MSG]The String 'error' can be wrapped in single quotes instead of double quotes

[SRC]return "success"

[MSG]The String 'success' can be wrapped in single quotes instead of double quotes

[SRC]import org.apache.ofbiz.base.util.UtilMisc

[MSG]The [org.apache.ofbiz.base.util.UtilMisc] import is never referenced

[SRC]import org.apache.ofbiz.entity.condition.*

[MSG]Wildcard (star) import

[SRC]product = from("Product").where("productId", add_product..).queryOne()

[MSG]The String 'Product' can be wrapped in single quotes instead of double quotes

[SRC]product = from("Product").where("productId", add_product..).queryOne()

[MSG]The String 'productId' can be wrapped in single quotes instead of double quotes

[SRC]allgiftWraps = from("ProductFeature").where("productFeat...queryList()

[MSG]The String 'ProductFeature' can be wrapped in single quotes instead of double quotes

[SRC]allgiftWraps = from("ProductFeature").where("productFeat...queryList()

[MSG]The String 'productFeatureTypeId' can be wrapped in single quotes instead of double quotes

[SRC]allgiftWraps = from("ProductFeature").where("productFeat...queryList()

[MSG]The String 'GIFT_WRAP' can be wrapped in single quotes instead of double quotes

[SRC]allgiftWraps = from("ProductFeature").where("productFeat...queryList()

[MSG]The String 'defaultSequenceNum' can be wrapped in single quotes instead of double quotes

[SRC]allShoppingLists = from("ShoppingList").where(EntityCond..in.partyId),

[MSG]The String 'ShoppingList' can be wrapped in single quotes instead of double quotes

[SRC]allShoppingLists = from("ShoppingList").where(EntityCond..in.partyId),

[MSG]The String 'partyId' can be wrapped in single quotes instead of double quotes

[SRC]EntityCondition.makeCondition("listName", EntityOperator...queryList()

[MSG]The String 'listName' can be wrapped in single quotes instead of double quotes

[SRC]EntityCondition.makeCondition("listName", EntityOperator...queryList()

[MSG]The String 'auto-save' can be wrapped in single quotes instead of double quotes

[SRC]EntityCondition.makeCondition("listName", EntityOperator...queryList()

[MSG]The String 'listName' can be wrapped in single quotes instead of double quotes

[SRC]if(shoppingCartItems) {

[MSG]The if keyword within class org.apache.ofbiz.ecommerce.cart.None is not followed by a single space

[SRC]productCategoryMembers = from("ProductCategoryMember").w...queryList()

[MSG]The String 'ProductCategoryMember' can be wrapped in single quotes instead of double quotes

[SRC]productCategoryMembers = from("ProductCategoryMember").w...queryList()

[MSG]The String 'productId' can be wrapped in single quotes instead of double quotes

[SRC]productCategory = productCategoryMember.getRelatedOne("P..ory", false)

[MSG]The String 'ProductCategory' can be wrapped in single quotes instead of double quotes

[SRC]if (promoText && !"N".equals(productPromo.showToCustomer)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.cart.None. Explicit call to N.equals(productPromo.showToCustomer) method can be rewritten as (N == (productPromo.showToCustomer))

[SRC]randomIndex = Math.round(java.lang.Math.random() * (prod..- 1)) as int

[MSG]Using Math.random() is insecure. Use SecureRandom instead

[SRC]import org.apache.ofbiz.base.util.UtilMisc

[MSG]The [org.apache.ofbiz.base.util.UtilMisc] import is never referenced

[SRC]if (promoText && !"N".equals(productPromo.showToCustomer)) {

[MSG]The String 'N' can be wrapped in single quotes instead of double quotes

[SRC]randomIndex = Math.round(java.lang.Math.random() * (prod..- 1)) as int

[MSG]Specifying the package name is not necessary for java.lang.Math

[SRC]import org.apache.ofbiz.product.product.ProductContentWrapper

[MSG]The [org.apache.ofbiz.product.product.ProductContentWrapper] import is never referenced

[SRC]import org.apache.ofbiz.product.category.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.base.util.UtilValidate

[MSG]The [org.apache.ofbiz.base.util.UtilValidate] import is never referenced

[SRC]productCategoryId=parameters.category_id

[MSG]The operator "=" within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]productCategoryId=parameters.category_id

[MSG]The operator "=" within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a space or whitespace

[SRC]if(parentCategoryStr) {

[MSG]The if keyword within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a single space

[SRC]for(path in pathList) {

[MSG]The for keyword within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a single space

[SRC]category = from("ProductCategory").where("productCategor..).queryOne()

[MSG]The String 'ProductCategory' can be wrapped in single quotes instead of double quotes

[SRC]category = from("ProductCategory").where("productCategor..).queryOne()

[MSG]The String 'productCategoryId' can be wrapped in single quotes instead of double quotes

[SRC]

[MSG]Line ends with whitespace characters

[SRC]cateMap.title = categoryContentWrapper.get("DESCRIPTION", "html")

[MSG]The String 'DESCRIPTION' can be wrapped in single quotes instead of double quotes

[SRC]cateMap.title = categoryContentWrapper.get("DESCRIPTION", "html")

[MSG]The String 'html' can be wrapped in single quotes instead of double quotes

[SRC]

[MSG]Line ends with whitespace characters

[SRC]

[MSG]Line ends with whitespace characters

[SRC]currentCategory = from("ProductCategory").where("product..).queryOne()

[MSG]The String 'ProductCategory' can be wrapped in single quotes instead of double quotes

[SRC]currentCategory = from("ProductCategory").where("product..).queryOne()

[MSG]The String 'productCategoryId' can be wrapped in single quotes instead of double quotes

[SRC]context.currentCategoryName = currentCategoryContentWrap..ME", "html")

[MSG]The String 'CATEGORY_NAME' can be wrapped in single quotes instead of double quotes

[SRC]context.currentCategoryName = currentCategoryContentWrap..ME", "html")

[MSG]The String 'html' can be wrapped in single quotes instead of double quotes

[SRC]context.currentCategoryDescription = currentCategoryCont..ON", "html")

[MSG]The String 'DESCRIPTION' can be wrapped in single quotes instead of double quotes

[SRC]context.currentCategoryDescription = currentCategoryCont..ON", "html")

[MSG]The String 'html' can be wrapped in single quotes instead of double quotes

[SRC]import org.apache.ofbiz.base.util.UtilValidate

[MSG]The [org.apache.ofbiz.base.util.UtilValidate] import is never referenced

[SRC]import org.apache.ofbiz.base.util.UtilMisc

[MSG]The [org.apache.ofbiz.base.util.UtilMisc] import is never referenced

[SRC]import org.apache.ofbiz.product.catalog.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.product.category.*

[MSG]Wildcard (star) import

[SRC]prodCatalogCategoryList = CatalogWorker.getProdCatalogCa.._BEST_SELL")

[MSG]The String 'PCCT_BEST_SELL' can be wrapped in single quotes instead of double quotes

[SRC]productCategoryId = prodCatalogCategory.getString("productCategoryId")

[MSG]The String 'productCategoryId' can be wrapped in single quotes instead of double quotes

[SRC]childCategoryList = CategoryWorker.getRelatedCategoriesR..oryId, true)

[MSG]The String 'childCategoryList' can be wrapped in single quotes instead of double quotes

[SRC]if (!parameters.clearSearch || !"N".equals(parameters.clearSearch)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.catalog.None. Explicit call to N.equals(parameters.clearSearch) method can be rewritten as (N == (parameters.clearSearch))

[SRC]thisSubCategoryList.add([productCategoryId: subCategory...entWrapper])

[MSG]The line exceeds 150 characters. The line is 200 characters.

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The line exceeds 150 characters. The line is 276 characters.

[SRC]priceRangeConstraint = new ProductSearch.ListPriceRangeC..om(request))

[MSG]The line exceeds 150 characters. The line is 168 characters.

[SRC]priceRangeCount = ProductSearchSession.getCountForListPr.., delegator)

[MSG]The line exceeds 150 characters. The line is 157 characters.

[SRC]import org.apache.ofbiz.entity.util.EntityUtil

[MSG]The [org.apache.ofbiz.entity.util.EntityUtil] import is never referenced

[SRC]if (!searchCategoryId) {

[MSG]Code could use elvis operator: searchCategoryId = searchCategoryId ?: context.productCategoryId

[SRC]currentSearchCategory = from("ProductCategory").where("p..).queryOne()

[MSG]The String 'ProductCategory' can be wrapped in single quotes instead of double quotes

[SRC]currentSearchCategory = from("ProductCategory").where("p..).queryOne()

[MSG]The String 'productCategoryId' can be wrapped in single quotes instead of double quotes

[SRC]CategoryWorker.getRelatedCategories(request, "subCategor..ryId, false)

[MSG]The String 'subCategoryList' can be wrapped in single quotes instead of double quotes

[SRC]subCategoryList = request.getAttribute("subCategoryList")

[MSG]The String 'subCategoryList' can be wrapped in single quotes instead of double quotes

[SRC]context.productCategory = from("ProductCategory").where(..).queryOne()

[MSG]The statement on line 43 in class org.apache.ofbiz.ecommerce.catalog.None is at the incorrect indent level: Expected column 5 but was 4

[SRC]context.productCategory = from("ProductCategory").where(..).queryOne()

[MSG]The String 'ProductCategory' can be wrapped in single quotes instead of double quotes

[SRC]context.productCategory = from("ProductCategory").where(..).queryOne()

[MSG]The String 'productCategoryId' can be wrapped in single quotes instead of double quotes

[SRC]parameters.SEARCH_CATEGORY_ID = productCategoryId

[MSG]The statement on line 44 in class org.apache.ofbiz.ecommerce.catalog.None is at the incorrect indent level: Expected column 5 but was 4

[SRC]if (!parameters.clearSearch || !"N".equals(parameters.clearSearch)) {

[MSG]The String 'N' can be wrapped in single quotes instead of double quotes

[SRC]request.getSession().setAttribute("dispatcher",dispatcher)

[MSG]The parameter dispatcher in the call to method setAttribute within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]request.getSession().setAttribute("dispatcher",dispatcher)

[MSG]The String 'dispatcher' can be wrapped in single quotes instead of double quotes

[SRC]productCategoryRollups = from("ProductCategoryRollup").w...queryList()

[MSG]The String 'ProductCategoryRollup' can be wrapped in single quotes instead of double quotes

[SRC]productCategoryRollups = from("ProductCategoryRollup").w...queryList()

[MSG]The String 'productCategoryId' can be wrapped in single quotes instead of double quotes

[SRC]colors = ProductSearchSession.listCountByFeatureForType(.., delegator)

[MSG]The String 'COLOR' can be wrapped in single quotes instead of double quotes

[SRC]colorFeatureType = from("ProductFeatureType").where("pro..).queryOne()

[MSG]The String 'ProductFeatureType' can be wrapped in single quotes instead of double quotes

[SRC]colorFeatureType = from("ProductFeatureType").where("pro..).queryOne()

[MSG]The String 'productFeatureTypeId' can be wrapped in single quotes instead of double quotes

[SRC]colorFeatureType = from("ProductFeatureType").where("pro..).queryOne()

[MSG]The String 'COLOR' can be wrapped in single quotes instead of double quotes

[SRC]context.showColors=false

[MSG]The operator "=" within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]context.showColors=false

[MSG]The operator "=" within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a space or whitespace

[SRC]}

[MSG]Line ends with whitespace characters

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The String '0' can be wrapped in single quotes instead of double quotes

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The String '10' can be wrapped in single quotes instead of double quotes

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The String '10' can be wrapped in single quotes instead of double quotes

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The String '20' can be wrapped in single quotes instead of double quotes

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The String '20' can be wrapped in single quotes instead of double quotes

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The String '30' can be wrapped in single quotes instead of double quotes

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The String '30' can be wrapped in single quotes instead of double quotes

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The String '40' can be wrapped in single quotes instead of double quotes

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The String '40' can be wrapped in single quotes instead of double quotes

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The String '50' can be wrapped in single quotes instead of double quotes

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The String '50' can be wrapped in single quotes instead of double quotes

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The String '60' can be wrapped in single quotes instead of double quotes

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The String '60' can be wrapped in single quotes instead of double quotes

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The String '70' can be wrapped in single quotes instead of double quotes

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The String '70' can be wrapped in single quotes instead of double quotes

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The String '80' can be wrapped in single quotes instead of double quotes

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The String '80' can be wrapped in single quotes instead of double quotes

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The String '90' can be wrapped in single quotes instead of double quotes

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The String '90' can be wrapped in single quotes instead of double quotes

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The String '100' can be wrapped in single quotes instead of double quotes

[SRC]context.searchConstraintStrings = result.searchConstraintStrings

[MSG]The code could be more concise by using a with() or identity() block

[SRC]if (userLogin) priceParams.partyId = userLogin.partyId

[MSG]The if statement lacks braces

[SRC]if ("Y".equals(productStore.get("showPricesWithVatTax"))) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.catalog.None. Explicit call to Y.equals(productStore.get(showPricesWithVatTax)) method can be rewritten as (Y == (productStore.get(showPricesWithVatTax)))

[SRC]Map priceMap = runService('calcTaxForDisplay', ["basePri..uctStoreId])

[MSG]The line exceeds 150 characters. The line is 174 characters.

[SRC]if ("AGGREGATED".equals(miniProduct.productTypeId) || "A..ctTypeId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.catalog.None. Explicit call to AGGREGATED.equals(miniProduct.productTypeId) method can be rewritten as (AGGREGATED == (miniProduct.productTypeId))

[SRC]if ("AGGREGATED".equals(miniProduct.productTypeId) || "A..ctTypeId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.catalog.None. Explicit call to AGGREGATED_SERVICE.equals(miniProduct.productTypeId) method can be rewritten as (AGGREGATED_SERVICE == (miniProduct.productTypeId))

[SRC]if ("Y".equals(productStore.get("showPricesWithVatTax"))) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.catalog.None. Explicit call to Y.equals(productStore.get(showPricesWithVatTax)) method can be rewritten as (Y == (productStore.get(showPricesWithVatTax)))

[SRC]Map totalPriceMap = runService('calcTaxForDisplay', ["ba..uctStoreId])

[MSG]The line exceeds 150 characters. The line is 178 characters.

[SRC]import java.math.BigDecimal

[SRC]import java.util.Map

[SRC]import org.apache.ofbiz.base.util.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.entity.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.service.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.product.catalog.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.product.store.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.order.shoppingcart.*

[MSG]Wildcard (star) import

[SRC]miniProduct = request.getAttribute("miniProduct")

[MSG]The String 'miniProduct' can be wrapped in single quotes instead of double quotes

[SRC]optProductId = request.getAttribute("optProductId")

[MSG]The String 'optProductId' can be wrapped in single quotes instead of double quotes

[SRC]context.remove("totalPrice")

[MSG]The String 'totalPrice' can be wrapped in single quotes instead of double quotes

[SRC]miniProduct = from("Product").where("productId", optProd..).queryOne()

[MSG]The String 'Product' can be wrapped in single quotes instead of double quotes

[SRC]miniProduct = from("Product").where("productId", optProd..).queryOne()

[MSG]The String 'productId' can be wrapped in single quotes instead of double quotes

[SRC]priceParams = [product : miniProduct,

[MSG]The colon for the literal Map entry for key [product] within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a match for regular expression [\S]

[SRC]prodCatalogId : prodCatalogId,

[MSG]The colon for the literal Map entry for key [prodCatalogId] within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a match for regular expression [\S]

[SRC]webSiteId : webSiteId,

[MSG]The colon for the literal Map entry for key [webSiteId] within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a match for regular expression [\S]

[SRC]currencyUomId : cart.getCurrency(),

[MSG]The colon for the literal Map entry for key [currencyUomId] within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a match for regular expression [\S]

[SRC]autoUserLogin : autoUserLogin,

[MSG]The colon for the literal Map entry for key [autoUserLogin] within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a match for regular expression [\S]

[SRC]productStoreId : productStoreId]

[MSG]The colon for the literal Map entry for key [productStoreId] within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a match for regular expression [\S]

[SRC]if ("Y".equals(productStore.get("showPricesWithVatTax"))) {

[MSG]The String 'Y' can be wrapped in single quotes instead of double quotes

[SRC]if ("Y".equals(productStore.get("showPricesWithVatTax"))) {

[MSG]The String 'showPricesWithVatTax' can be wrapped in single quotes instead of double quotes

[SRC]Map priceMap = runService('calcTaxForDisplay', ["basePri..uctStoreId])

[MSG]The String 'basePrice' can be wrapped in single quotes instead of double quotes

[SRC]Map priceMap = runService('calcTaxForDisplay', ["basePri..uctStoreId])

[MSG]The String 'price' can be wrapped in single quotes instead of double quotes

[SRC]Map priceMap = runService('calcTaxForDisplay', ["basePri..uctStoreId])

[MSG]The String 'locale' can be wrapped in single quotes instead of double quotes

[SRC]Map priceMap = runService('calcTaxForDisplay', ["basePri..uctStoreId])

[MSG]The String 'productId' can be wrapped in single quotes instead of double quotes

[SRC]Map priceMap = runService('calcTaxForDisplay', ["basePri..uctStoreId])

[MSG]The String 'productStoreId' can be wrapped in single quotes instead of double quotes

[SRC]context.price = priceMap.get("priceWithTax")

[MSG]The String 'priceWithTax' can be wrapped in single quotes instead of double quotes

[SRC]context.price = priceResult.get("price")

[MSG]The String 'price' can be wrapped in single quotes instead of double quotes

[SRC]if ("AGGREGATED".equals(miniProduct.productTypeId) || "A..ctTypeId)) {

[MSG]The String 'AGGREGATED' can be wrapped in single quotes instead of double quotes

[SRC]if ("AGGREGATED".equals(miniProduct.productTypeId) || "A..ctTypeId)) {

[MSG]The String 'AGGREGATED_SERVICE' can be wrapped in single quotes instead of double quotes

[SRC]if ("Y".equals(productStore.get("showPricesWithVatTax"))) {

[MSG]The String 'Y' can be wrapped in single quotes instead of double quotes

[SRC]if ("Y".equals(productStore.get("showPricesWithVatTax"))) {

[MSG]The String 'showPricesWithVatTax' can be wrapped in single quotes instead of double quotes

[SRC]Map totalPriceMap = runService('calcTaxForDisplay', ["ba..uctStoreId])

[MSG]The String 'basePrice' can be wrapped in single quotes instead of double quotes

[SRC]Map totalPriceMap = runService('calcTaxForDisplay', ["ba..uctStoreId])

[MSG]The String 'locale' can be wrapped in single quotes instead of double quotes

[SRC]Map totalPriceMap = runService('calcTaxForDisplay', ["ba..uctStoreId])

[MSG]The String 'productId' can be wrapped in single quotes instead of double quotes

[SRC]Map totalPriceMap = runService('calcTaxForDisplay', ["ba..uctStoreId])

[MSG]The String 'productStoreId' can be wrapped in single quotes instead of double quotes

[SRC]context.totalPrice = totalPriceMap.get("priceWithTax")

[MSG]The String 'priceWithTax' can be wrapped in single quotes instead of double quotes

[SRC]context.miniProdFormName = request.getAttribute("miniProdFormName")

[MSG]The String 'miniProdFormName' can be wrapped in single quotes instead of double quotes

[SRC]context.miniProdQuantity = request.getAttribute("miniProdQuantity")

[MSG]The String 'miniProdQuantity' can be wrapped in single quotes instead of double quotes

[MSG]Code block ends with a blank line.

[SRC]productTags = from("ProductKeyword").where("keyword", pr...queryList()

[MSG]The line exceeds 150 characters. The line is 152 characters.

[SRC]double weight = 0

[MSG]The variable weight in class org.apache.ofbiz.ecommerce.catalog.None is of type double/Double. Prefer using BigDecimal.

[SRC]double fontSize = minFontSize + ((maxFontSize - minFontSize) * weight)

[MSG]The variable fontSize in class org.apache.ofbiz.ecommerce.catalog.None is of type double/Double. Prefer using BigDecimal.

[SRC]import java.util.List

[SRC]import java.util.List

[MSG]The [java.util.List] import is never referenced

[SRC]import org.apache.ofbiz.entity.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.entity.condition.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.entity.util.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.entity.util.EntityUtil

[MSG]The [org.apache.ofbiz.entity.util.EntityUtil] import is never referenced

[SRC]import org.apache.ofbiz.entity.transaction.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.base.util.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.base.util.string.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.content.content.*

[MSG]Wildcard (star) import

[SRC]import org.apache.commons.lang.StringEscapeUtils

[MSG]The [org.apache.commons.lang.StringEscapeUtils] import is never referenced

[SRC]int minFontSize = EntityUtilProperties.getPropertyAsInte..).intValue()

[MSG]The String 'ecommerce' can be wrapped in single quotes instead of double quotes

[SRC]int minFontSize = EntityUtilProperties.getPropertyAsInte..).intValue()

[MSG]The String 'tagcloud.min.fontsize' can be wrapped in single quotes instead of double quotes

[SRC]int maxFontSize = EntityUtilProperties.getPropertyAsInte..).intValue()

[MSG]The String 'ecommerce' can be wrapped in single quotes instead of double quotes

[SRC]int maxFontSize = EntityUtilProperties.getPropertyAsInte..).intValue()

[MSG]The String 'tagcloud.max.fontsize' can be wrapped in single quotes instead of double quotes

[SRC]int limitTagCloud = EntityUtilProperties.getPropertyAsIn..).intValue()

[MSG]The String 'ecommerce' can be wrapped in single quotes instead of double quotes

[SRC]int limitTagCloud = EntityUtilProperties.getPropertyAsIn..).intValue()

[MSG]The String 'tagcloud.limit' can be wrapped in single quotes instead of double quotes

[SRC]productKeywords = select("keyword", "keywordTypeId", "statusId")

[MSG]The String 'keyword' can be wrapped in single quotes instead of double quotes

[SRC]productKeywords = select("keyword", "keywordTypeId", "statusId")

[MSG]The String 'keywordTypeId' can be wrapped in single quotes instead of double quotes

[SRC]productKeywords = select("keyword", "keywordTypeId", "statusId")

[MSG]The String 'statusId' can be wrapped in single quotes instead of double quotes

[SRC].from("ProductKeyword")

[MSG]The String 'ProductKeyword' can be wrapped in single quotes instead of double quotes

[SRC].where(keywordTypeId : "KWT_TAG", statusId : "KW_APPROVED")

[MSG]The colon for the literal Map entry for key [keywordTypeId] within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a match for regular expression [\S]

[SRC].where(keywordTypeId : "KWT_TAG", statusId : "KW_APPROVED")

[MSG]The colon for the literal Map entry for key [statusId] within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a match for regular expression [\S]

[SRC].where(keywordTypeId : "KWT_TAG", statusId : "KW_APPROVED")

[MSG]The String 'KWT_TAG' can be wrapped in single quotes instead of double quotes

[SRC].where(keywordTypeId : "KWT_TAG", statusId : "KW_APPROVED")

[MSG]The String 'KW_APPROVED' can be wrapped in single quotes instead of double quotes

[SRC].orderBy("keyword")

[MSG]The String 'keyword' can be wrapped in single quotes instead of double quotes

[SRC]productTags = from("ProductKeyword").where("keyword", pr...queryList()

[MSG]The String 'ProductKeyword' can be wrapped in single quotes instead of double quotes

[SRC]productTags = from("ProductKeyword").where("keyword", pr...queryList()

[MSG]The String 'keyword' can be wrapped in single quotes instead of double quotes

[SRC]productTags = from("ProductKeyword").where("keyword", pr...queryList()

[MSG]The String 'keywordTypeId' can be wrapped in single quotes instead of double quotes

[SRC]productTags = from("ProductKeyword").where("keyword", pr...queryList()

[MSG]The String 'KWT_TAG' can be wrapped in single quotes instead of double quotes

[SRC]productTags = from("ProductKeyword").where("keyword", pr...queryList()

[MSG]The String 'statusId' can be wrapped in single quotes instead of double quotes

[SRC]productTags = from("ProductKeyword").where("keyword", pr...queryList()

[MSG]The String 'KW_APPROVED' can be wrapped in single quotes instead of double quotes

[SRC]tagList.sort{ a,b -> b.countTag <=> a.countTag }

[MSG]The closure parameter b within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]tagList.sort{ a,b -> b.countTag <=> a.countTag }

[MSG]The opening brace for the closure in class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]tagCloudList = tagCloudList.sort{it.tag}

[MSG]The opening brace for the closure in class org.apache.ofbiz.ecommerce.catalog.None is not followed by a space or whitespace

[SRC]tagCloudList = tagCloudList.sort{it.tag}

[MSG]The closing brace for the closure in class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]tagCloudList = tagCloudList.sort{it.tag}

[MSG]The opening brace for the closure in class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]List fillTree(rootCat ,CatLvl, parentCategoryId) {

[MSG]The parameter named CatLvl in method fillTree of class org.apache.ofbiz.ecommerce.catalog.None does not match [a-z][a-zA-Z0-9]*

[SRC]if(CatLvl==2)

[MSG]The if statement lacks braces

[SRC]else if(CatLvl==1)

[MSG]The else block lacks braces

[SRC]else if(CatLvl==1)

[MSG]The if statement lacks braces

[SRC]if(categoryContentWrapper.get("CATEGORY_NAME", "html").toString())

[MSG]The else block lacks braces

[SRC]if(categoryContentWrapper.get("CATEGORY_NAME", "html").toString())

[MSG]The if statement lacks braces

[SRC]if(categoryContentWrapper.get("DESCRIPTION", "html").toString())

[MSG]The else block lacks braces

[SRC]if(categoryContentWrapper.get("DESCRIPTION", "html").toString())

[MSG]The if statement lacks braces

[SRC]CategoryWorker.getRelatedCategories(request, "topLevelLi..est)), true)

[MSG]The line exceeds 150 characters. The line is 158 characters.

[SRC]import org.apache.ofbiz.base.util.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.product.catalog.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.product.category.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.entity.*

[MSG]Wildcard (star) import

[SRC]List fillTree(rootCat ,CatLvl, parentCategoryId) {

[MSG]"rootCat" parameter of "fillTree" method is dynamically typed

[SRC]List fillTree(rootCat ,CatLvl, parentCategoryId) {

[MSG]"CatLvl" parameter of "fillTree" method is dynamically typed

[SRC]List fillTree(rootCat ,CatLvl, parentCategoryId) {

[MSG]"parentCategoryId" parameter of "fillTree" method is dynamically typed

[SRC]List fillTree(rootCat ,CatLvl, parentCategoryId) {

[MSG]def for method parameter type should not be used

[SRC]List fillTree(rootCat ,CatLvl, parentCategoryId) {

[MSG]def for method parameter type should not be used

[SRC]List fillTree(rootCat ,CatLvl, parentCategoryId) {

[MSG]def for method parameter type should not be used

[SRC]if(rootCat) {

[MSG]The if keyword within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a single space

[SRC]rootCat.sort{ it.productCategoryId }

[MSG]The opening brace for the closure in class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]def listTree = []

[MSG]def for declaration should not be used

[SRC]def listTree = []

[MSG]The type is not specified for variable "listTree"

[SRC]for(root in rootCat) {

[MSG]The for keyword within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a single space

[SRC]preCatChilds = from("ProductCategoryRollup").where("pare...queryList()

[MSG]The String 'ProductCategoryRollup' can be wrapped in single quotes instead of double quotes

[SRC]preCatChilds = from("ProductCategoryRollup").where("pare...queryList()

[MSG]The String 'parentProductCategoryId' can be wrapped in single quotes instead of double quotes

[SRC]catChilds = EntityUtil.getRelated("CurrentProductCategor..hilds,false)

[MSG]The parameter null in the call to method getRelated within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]catChilds = EntityUtil.getRelated("CurrentProductCategor..hilds,false)

[MSG]The parameter preCatChilds in the call to method getRelated within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]catChilds = EntityUtil.getRelated("CurrentProductCategor..hilds,false)

[MSG]The parameter false in the call to method getRelated within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]catChilds = EntityUtil.getRelated("CurrentProductCategor..hilds,false)

[MSG]The String 'CurrentProductCategory' can be wrapped in single quotes instead of double quotes

[SRC]def childList = []

[MSG]def for declaration should not be used

[SRC]def childList = []

[MSG]The type is not specified for variable "childList"

[SRC]

[MSG]Line ends with whitespace characters

[SRC]if(catChilds) {

[MSG]The if keyword within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a single space

[SRC]if(CatLvl==2)

[MSG]The if keyword within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a single space

[SRC]if(CatLvl==2)

[MSG]The operator "==" within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]if(CatLvl==2)

[MSG]The operator "==" within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a space or whitespace

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The parameter (CatLvl + 1) in the call to method fillTree within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The operator "+" within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The operator "+" within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a space or whitespace

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The operator "+" within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The operator "+" within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a space or whitespace

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The operator "+" within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The operator "+" within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a space or whitespace

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The String '/' can be wrapped in single quotes instead of double quotes

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The String '' can be wrapped in single quotes instead of double quotes

[SRC]else if(CatLvl==1)

[MSG]The if keyword within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a single space

[SRC]else if(CatLvl==1)

[MSG]The operator "==" within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]else if(CatLvl==1)

[MSG]The operator "==" within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a space or whitespace

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The parameter (CatLvl + 1) in the call to method fillTree within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The operator "+" within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The operator "+" within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a space or whitespace

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The operator "+" within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The operator "+" within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a space or whitespace

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The String '/' can be wrapped in single quotes instead of double quotes

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The String '' can be wrapped in single quotes instead of double quotes

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The parameter (CatLvl + 1) in the call to method fillTree within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The operator "+" within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The operator "+" within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a space or whitespace

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The operator "+" within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The operator "+" within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a space or whitespace

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The operator "+" within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]childList = fillTree(catChilds,CatLvl+1, parentCategoryI..tCategoryId)

[MSG]The operator "+" within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a space or whitespace

[SRC]

[MSG]Line ends with whitespace characters

[SRC]productsInCat = from("ProductCategoryAndMember").where(...queryList()

[MSG]The String 'ProductCategoryAndMember' can be wrapped in single quotes instead of double quotes

[SRC]productsInCat = from("ProductCategoryAndMember").where(...queryList()

[MSG]The String 'productCategoryId' can be wrapped in single quotes instead of double quotes

[SRC]

[MSG]Line ends with whitespace characters

[SRC]if(productsInCat || childList) {

[MSG]The if keyword within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a single space

[SRC]def rootMap = [:]

[MSG]def for declaration should not be used

[SRC]def rootMap = [:]

[MSG]The type is not specified for variable "rootMap"

[SRC]category = from("ProductCategory").where("productCategor..).queryOne()

[MSG]The String 'ProductCategory' can be wrapped in single quotes instead of double quotes

[SRC]category = from("ProductCategory").where("productCategor..).queryOne()

[MSG]The String 'productCategoryId' can be wrapped in single quotes instead of double quotes

[SRC]context.title = categoryContentWrapper.get("CATEGORY_NAME", "html")

[MSG]The String 'CATEGORY_NAME' can be wrapped in single quotes instead of double quotes

[SRC]context.title = categoryContentWrapper.get("CATEGORY_NAME", "html")

[MSG]The String 'html' can be wrapped in single quotes instead of double quotes

[SRC]categoryDescription = categoryContentWrapper.get("DESCRI..ON", "html")

[MSG]The String 'DESCRIPTION' can be wrapped in single quotes instead of double quotes

[SRC]categoryDescription = categoryContentWrapper.get("DESCRI..ON", "html")

[MSG]The String 'html' can be wrapped in single quotes instead of double quotes

[SRC]

[MSG]Line ends with whitespace characters

[SRC]if(categoryContentWrapper.get("CATEGORY_NAME", "html").toString())

[MSG]The if keyword within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a single space

[SRC]if(categoryContentWrapper.get("CATEGORY_NAME", "html").toString())

[MSG]The String 'CATEGORY_NAME' can be wrapped in single quotes instead of double quotes

[SRC]if(categoryContentWrapper.get("CATEGORY_NAME", "html").toString())

[MSG]The String 'html' can be wrapped in single quotes instead of double quotes

[SRC]rootMap["categoryName"] = categoryContentWrapper.get("CA..ME", "html")

[MSG]The String 'categoryName' can be wrapped in single quotes instead of double quotes

[SRC]rootMap["categoryName"] = categoryContentWrapper.get("CA..ME", "html")

[MSG]The String 'CATEGORY_NAME' can be wrapped in single quotes instead of double quotes

[SRC]rootMap["categoryName"] = categoryContentWrapper.get("CA..ME", "html")

[MSG]The String 'html' can be wrapped in single quotes instead of double quotes

[SRC]rootMap["categoryName"] = root.categoryName

[MSG]The String 'categoryName' can be wrapped in single quotes instead of double quotes

[SRC]

[MSG]Line ends with whitespace characters

[SRC]if(categoryContentWrapper.get("DESCRIPTION", "html").toString())

[MSG]The if keyword within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a single space

[SRC]if(categoryContentWrapper.get("DESCRIPTION", "html").toString())

[MSG]The String 'DESCRIPTION' can be wrapped in single quotes instead of double quotes

[SRC]if(categoryContentWrapper.get("DESCRIPTION", "html").toString())

[MSG]The String 'html' can be wrapped in single quotes instead of double quotes

[SRC]rootMap["categoryDescription"] = categoryContentWrapper...ON", "html")

[MSG]The String 'categoryDescription' can be wrapped in single quotes instead of double quotes

[SRC]rootMap["categoryDescription"] = categoryContentWrapper...ON", "html")

[MSG]The String 'DESCRIPTION' can be wrapped in single quotes instead of double quotes

[SRC]rootMap["categoryDescription"] = categoryContentWrapper...ON", "html")

[MSG]The String 'html' can be wrapped in single quotes instead of double quotes

[SRC]rootMap["categoryDescription"] = root.description

[MSG]The String 'categoryDescription' can be wrapped in single quotes instead of double quotes

[SRC]

[MSG]Line ends with whitespace characters

[SRC]rootMap["productCategoryId"] = root.productCategoryId

[MSG]The String 'productCategoryId' can be wrapped in single quotes instead of double quotes

[SRC]rootMap["parentCategoryId"] = parentCategoryId

[MSG]The String 'parentCategoryId' can be wrapped in single quotes instead of double quotes

[SRC]rootMap["child"] = childList

[MSG]The String 'child' can be wrapped in single quotes instead of double quotes

[SRC]CategoryWorker.getRelatedCategories(request, "topLevelLi..est)), true)

[MSG]The String 'topLevelList' can be wrapped in single quotes instead of double quotes

[SRC]curCategoryId = parameters.category_id ?: parameters.CATEGORY_ID ?: ""

[MSG]The String '' can be wrapped in single quotes instead of double quotes

[SRC]request.setAttribute("curCategoryId", curCategoryId)

[MSG]The String 'curCategoryId' can be wrapped in single quotes instead of double quotes

[SRC]categoryList = request.getAttribute("topLevelList")

[MSG]The String 'topLevelList' can be wrapped in single quotes instead of double quotes

[SRC]completedTree = fillTree(categoryList, 1, "")

[MSG]The String '' can be wrapped in single quotes instead of double quotes

[SRC]if (!"AND".equals(searchOperator) && !"OR".equals(searchOperator)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.content.None. Explicit call to AND.equals(searchOperator) method can be rewritten as (AND == (searchOperator))

[SRC]if (!"AND".equals(searchOperator) && !"OR".equals(searchOperator)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.content.None. Explicit call to OR.equals(searchOperator) method can be rewritten as (OR == (searchOperator))

[SRC]import org.apache.ofbiz.base.util.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.product.catalog.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.product.feature.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.product.product.*

[MSG]Wildcard (star) import

[SRC]if (!"AND".equals(searchOperator) && !"OR".equals(searchOperator)) {

[MSG]The String 'AND' can be wrapped in single quotes instead of double quotes

[SRC]if (!"AND".equals(searchOperator) && !"OR".equals(searchOperator)) {

[MSG]The String 'OR' can be wrapped in single quotes instead of double quotes

[SRC]searchOperator = "OR"

[MSG]The statement on line 31 in class org.apache.ofbiz.ecommerce.content.None is at the incorrect indent level: Expected column 5 but was 3

[SRC]searchOperator = "OR"

[MSG]The String 'OR' can be wrapped in single quotes instead of double quotes

[SRC]} else {

[MSG]The else block is empty

[SRC]import java.util.ArrayList

[SRC]import java.util.ArrayList

[MSG]The [java.util.ArrayList] import is never referenced

[SRC]import java.util.Collection

[SRC]import java.util.Collection

[MSG]The [java.util.Collection] import is never referenced

[SRC]import java.util.HashMap

[SRC]import java.util.HashMap

[MSG]The [java.util.HashMap] import is never referenced

[SRC]import java.util.Iterator

[SRC]import java.util.Iterator

[MSG]The [java.util.Iterator] import is never referenced

[SRC]import java.util.LinkedList

[SRC]import java.util.LinkedList

[MSG]The [java.util.LinkedList] import is never referenced

[SRC]import java.util.List

[SRC]import java.util.List

[MSG]The [java.util.List] import is never referenced

[SRC]import java.util.Map

[SRC]import java.util.Map

[MSG]The [java.util.Map] import is never referenced

[SRC]import java.util.Set

[SRC]import java.util.Set

[MSG]The [java.util.Set] import is never referenced

[SRC]import java.util.TreeSet

[SRC]import java.util.TreeSet

[MSG]The [java.util.TreeSet] import is never referenced

[SRC]import org.apache.ofbiz.base.util.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.entity.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.security.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.service.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.entity.model.*

[MSG]Wildcard (star) import

[SRC]import javax.servlet.*

[MSG]Wildcard (star) import

[SRC]import javax.servlet.http.*

[MSG]Wildcard (star) import

[SRC]entityName = "ContentDataResourceView"

[MSG]The String 'ContentDataResourceView' can be wrapped in single quotes instead of double quotes

[SRC]lookupCaches = session.getAttribute("lookupCaches")

[MSG]The String 'lookupCaches' can be wrapped in single quotes instead of double quotes

[SRC]session.setAttribute("lookupCaches", lookupCaches)

[MSG]The String 'lookupCaches' can be wrapped in single quotes instead of double quotes

[SRC]context.put("mrvList", mrvList)

[MSG]The String 'mrvList' can be wrapped in single quotes instead of double quotes

[SRC]return

[MSG]Do not return null from a catch block

[SRC]if ("any".equals(paramMap.anyOrAll)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.content.None. Explicit call to any.equals(paramMap.anyOrAll) method can be rewritten as (any == (paramMap.anyOrAll))

[SRC]logInfo("in search searchFeature3, combQuery:" + combQuery.toString())

[MSG]Calling toString() on [combQuery] in class org.apache.ofbiz.ecommerce.content.None is unnecessary

[SRC]import org.apache.ofbiz.base.util.Debug

[MSG]The [org.apache.ofbiz.base.util.Debug] import is never referenced

[SRC]import org.apache.lucene.search.*

[MSG]Wildcard (star) import

[SRC]siteId = paramMap.siteId ?: "WebStoreCONTENT"

[MSG]The String 'WebStoreCONTENT' can be wrapped in single quotes instead of double quotes

[SRC]Directory directory = FSDirectory.open(new File(SearchWo..)).toPath())

[MSG]The String 'content' can be wrapped in single quotes instead of double quotes

[SRC]context.errorMessageList.add(UtilProperties.getMessage("..d", locale))

[MSG]The String 'ContentErrorUiLabels' can be wrapped in single quotes instead of double quotes

[SRC]context.errorMessageList.add(UtilProperties.getMessage("..d", locale))

[MSG]The String 'ContentSearchNotIndexed' can be wrapped in single quotes instead of double quotes

[SRC]termQuery = new TermQuery(new Term("site", siteId.toString()))

[MSG]The String 'site' can be wrapped in single quotes instead of double quotes

[SRC]QueryParser parser = new QueryParser("content", analyzer)

[MSG]The String 'content' can be wrapped in single quotes instead of double quotes

[SRC]if ("any".equals(paramMap.anyOrAll)) {

[MSG]The String 'any' can be wrapped in single quotes instead of double quotes

[SRC]termQuery = new TermQuery(new Term("feature", value))

[MSG]The String 'feature' can be wrapped in single quotes instead of double quotes

[SRC]logInfo("in search searchFeature3, combQuery:" + combQuery.toString())

[MSG]The String 'in search searchFeature3, combQuery:' can be wrapped in single quotes instead of double quotes

[SRC]logInfo("in search, hits:" + collector.getTotalHits())

[MSG]The String 'in search, hits:' can be wrapped in single quotes instead of double quotes

[SRC]contentId = doc.get("contentId")

[MSG]The String 'contentId' can be wrapped in single quotes instead of double quotes

[SRC]content = from("Content").where("contentId", contentId)...).queryOne()

[MSG]The String 'Content' can be wrapped in single quotes instead of double quotes

[SRC]content = from("Content").where("contentId", contentId)...).queryOne()

[MSG]The String 'contentId' can be wrapped in single quotes instead of double quotes

[SRC]if (!tryEntity) userLoginData = UtilHttp.getParameterMap(request)

[MSG]The if statement lacks braces

[SRC]if (!userLoginData) userLoginData = [:]

[MSG]The if statement lacks braces

[SRC]import java.util.HashMap

[SRC]import java.util.HashMap

[MSG]The [java.util.HashMap] import is never referenced

[SRC]donePage = parameters.DONE_PAGE ?: "viewprofile"

[MSG]The String 'viewprofile' can be wrapped in single quotes instead of double quotes

[SRC]if (!userLoginData) userLoginData = [:]

[MSG]Code could use elvis operator: userLoginData = userLoginData ?: [:]

[SRC]partyAndContactMechList = from("PartyAndContactMech").wh...queryList()

[MSG]The line exceeds 150 characters. The line is 169 characters.

[SRC]import java.lang.*

[MSG]Wildcard (star) import

[SRC]import java.lang.*

[SRC]import java.util.*

[MSG]Wildcard (star) import

[SRC]import java.util.*

[SRC]import org.apache.ofbiz.base.util.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.entity.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.entity.util.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.entity.condition.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.party.contact.ContactMechWorker

[MSG]The [org.apache.ofbiz.party.contact.ContactMechWorker] import is never referenced

[SRC]import org.apache.ofbiz.product.store.ProductStoreWorker

[MSG]The [org.apache.ofbiz.product.store.ProductStoreWorker] import is never referenced

[SRC]import org.apache.ofbiz.accounting.payment.PaymentWorker

[MSG]The [org.apache.ofbiz.accounting.payment.PaymentWorker] import is never referenced

[SRC]exprList.add(EntityCondition.makeCondition("webSiteId", .. webSiteId))

[MSG]The String 'webSiteId' can be wrapped in single quotes instead of double quotes

[SRC]exprListThruDate.add(EntityCondition.makeCondition("thru..UALS, null))

[MSG]The String 'thruDate' can be wrapped in single quotes instead of double quotes

[SRC]exprListThruDate.add(EntityCondition.makeCondition("thru..imestamp()))

[MSG]The String 'thruDate' can be wrapped in single quotes instead of double quotes

[SRC]webSiteContactList = from("WebSiteContactList").where(ex...queryList()

[MSG]The String 'WebSiteContactList' can be wrapped in single quotes instead of double quotes

[SRC]contactList = webSiteContactList.getRelatedOne("ContactList", false)

[MSG]The String 'ContactList' can be wrapped in single quotes instead of double quotes

[SRC]contactListType = contactList.getRelatedOne("ContactListType", false)

[MSG]The String 'ContactListType' can be wrapped in single quotes instead of double quotes

[SRC]partyAndContactMechList = from("PartyAndContactMech").wh...queryList()

[MSG]The String 'PartyAndContactMech' can be wrapped in single quotes instead of double quotes

[SRC]partyAndContactMechList = from("PartyAndContactMech").wh...queryList()

[MSG]The String 'partyId' can be wrapped in single quotes instead of double quotes

[SRC]partyAndContactMechList = from("PartyAndContactMech").wh...queryList()

[MSG]The String 'contactMechTypeId' can be wrapped in single quotes instead of double quotes

[SRC]partyAndContactMechList = from("PartyAndContactMech").wh...queryList()

[MSG]The String 'EMAIL_ADDRESS' can be wrapped in single quotes instead of double quotes

[SRC]partyAndContactMechList = from("PartyAndContactMech").wh...queryList()

[MSG]The String '-fromDate' can be wrapped in single quotes instead of double quotes

[SRC]import org.apache.ofbiz.entity.condition.EntityOperator

[MSG]The [org.apache.ofbiz.entity.condition.EntityOperator] import is never referenced

[SRC]import org.apache.ofbiz.entity.condition.EntityCondition

[MSG]The [org.apache.ofbiz.entity.condition.EntityCondition] import is never referenced

[SRC]reviews = from("ProductReview").where("userLoginId", use...queryList()

[MSG]The statement on line 26 in class org.apache.ofbiz.ecommerce.customer.None is at the incorrect indent level: Expected column 5 but was 3

[SRC]reviews = from("ProductReview").where("userLoginId", use...queryList()

[MSG]The String 'ProductReview' can be wrapped in single quotes instead of double quotes

[SRC]reviews = from("ProductReview").where("userLoginId", use...queryList()

[MSG]The String 'userLoginId' can be wrapped in single quotes instead of double quotes

[SRC]context.reviews = reviews

[MSG]The statement on line 28 in class org.apache.ofbiz.ecommerce.customer.None is at the incorrect indent level: Expected column 5 but was 3

[SRC]import org.apache.ofbiz.base.util.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.entity.Delegator

[MSG]The [org.apache.ofbiz.entity.Delegator] import is never referenced

[SRC]import org.apache.ofbiz.entity.GenericValue

[MSG]The [org.apache.ofbiz.entity.GenericValue] import is never referenced

[SRC]surveyAppl = from("ProductStoreSurveyAppl").where("produ..).queryOne()

[MSG]The String 'ProductStoreSurveyAppl' can be wrapped in single quotes instead of double quotes

[SRC]surveyAppl = from("ProductStoreSurveyAppl").where("produ..).queryOne()

[MSG]The String 'productStoreSurveyId' can be wrapped in single quotes instead of double quotes

[SRC]survey = surveyAppl.getRelatedOne("Survey", false)

[MSG]The String 'Survey' can be wrapped in single quotes instead of double quotes

[SRC]paramMap = [productStoreSurveyId : productStoreSurveyId]

[MSG]The colon for the literal Map entry for key [productStoreSurveyId] within class org.apache.ofbiz.ecommerce.customer.None is not preceded by a match for regular expression [\S]

[SRC]paymentMethod = from("PaymentMethod").where("partyId", p..queryFirst()

[MSG]The line exceeds 150 characters. The line is 163 characters.

[SRC]if (billToContactMechId && billToContactMechId.equals(sh..ctMechId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.customer.None. Explicit call to billToContactMechId.equals(shipToContactMechId) method can be rewritten as (billToContactMechId == (shipToContactMechId))

[SRC]import org.apache.ofbiz.entity.condition.EntityCondition

[MSG]The [org.apache.ofbiz.entity.condition.EntityCondition] import is never referenced

[SRC]party = userLogin.getRelatedOne("Party", false)

[MSG]The String 'Party' can be wrapped in single quotes instead of double quotes

[SRC]contactMech = EntityUtil.getFirst(ContactHelper.getConta..SS", false))

[MSG]The String 'BILLING_LOCATION' can be wrapped in single quotes instead of double quotes