CodeNarc Report

[SRC]}else if("Any".equals(parameters.statusId)){

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to Any.equals(parameters.statusId) method can be rewritten as (Any == (parameters.statusId))

[SRC]def performFindResults = runService('performFind', ["ent..quenceNum"])

[MSG]The line exceeds 150 characters. The line is 157 characters.

[SRC]if ("N".equals(parameters.sequence)) { // re-order category list item

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to N.equals(parameters.sequence) method can be rewritten as (N == (parameters.sequence))

[SRC]if("".equals(parameters.statusId)){

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to .equals(parameters.statusId) method can be rewritten as ( == (parameters.statusId))

[SRC]unplannedList = select("custRequestId", "custSequenceNum...queryList()

[MSG]The line exceeds 150 characters. The line is 258 characters.

[SRC]if ("N".equals(parameters.UnplannedSequence)) { // re-or..ry list item

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to N.equals(parameters.UnplannedSequence) method can be rewritten as (N == (parameters.UnplannedSequence))

[SRC]projectAndTaskList = from("ProjectSprintBacklogAndTask")...queryList()

[MSG]The line exceeds 150 characters. The line is 166 characters.

[SRC]if ("RF_SCRUM_MEETINGS".equals(custRequestTypeId) && "CR..StatusId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to RF_SCRUM_MEETINGS.equals(custRequestTypeId) method can be rewritten as (RF_SCRUM_MEETINGS == (custRequestTypeId))

[SRC]if ("RF_SCRUM_MEETINGS".equals(custRequestTypeId) && "CR..StatusId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to CRQ_REVIEWED.equals(backlogStatusId) method can be rewritten as (CRQ_REVIEWED == (backlogStatusId))

[SRC]if (!"AND".equals(searchOperator) && !"OR".equals(searchOperator)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.content.None. Explicit call to AND.equals(searchOperator) method can be rewritten as (AND == (searchOperator))

[SRC]if (!"AND".equals(searchOperator) && !"OR".equals(searchOperator)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.content.None. Explicit call to OR.equals(searchOperator) method can be rewritten as (OR == (searchOperator))

[SRC]if (!"AND".equals(searchOperator) && !"OR".equals(searchOperator)) {

[MSG]Violation in class org.apache.ofbiz.lucene.content.None. Explicit call to AND.equals(searchOperator) method can be rewritten as (AND == (searchOperator))

[SRC]if (!"AND".equals(searchOperator) && !"OR".equals(searchOperator)) {

[MSG]Violation in class org.apache.ofbiz.lucene.content.None. Explicit call to OR.equals(searchOperator) method can be rewritten as (OR == (searchOperator))

[SRC]def module = "BacklogNotifications.groovy"

[MSG]The variable [module] in class org.apache.ofbiz.scrum.None is not used

[SRC]backlogList = select("productId", "workEffortId", "custR...queryList()

[MSG]The line exceeds 150 characters. The line is 175 characters.

[SRC]if ("CRQ_ACCEPTED".equals(custRequest.statusId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to CRQ_ACCEPTED.equals(custRequest.statusId) method can be rewritten as (CRQ_ACCEPTED == (custRequest.statusId))

[SRC]if (custStatusList.size() > 2 && "CRQ_REVIEWED".equals(c..statusId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to CRQ_REVIEWED.equals(custStatusList[1].statusId) method can be rewritten as (CRQ_REVIEWED == (custStatusList[1].statusId))

[SRC]if (partyId && !"_NA_".equals(partyId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to _NA_.equals(partyId) method can be rewritten as (_NA_ == (partyId))

[SRC]partyContactMech = from("PartyContactMech").where("party..queryFirst()

[MSG]The line exceeds 150 characters. The line is 172 characters.

[SRC]if ("CREDIT_CARD".equals(paymentMethod.paymentMethodTypeId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to CREDIT_CARD.equals(paymentMethod.paymentMethodTypeId) method can be rewritten as (CREDIT_CARD == (paymentMethod.paymentMethodTypeId))

[SRC]} else if ("EFT_ACCOUNT".equals(paymentMethod.paymentMethodTypeId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to EFT_ACCOUNT.equals(paymentMethod.paymentMethodTypeId) method can be rewritten as (EFT_ACCOUNT == (paymentMethod.paymentMethodTypeId))

[SRC]} else if ("GIFT_CARD".equals(paymentMethod.paymentMethodTypeId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to GIFT_CARD.equals(paymentMethod.paymentMethodTypeId) method can be rewritten as (GIFT_CARD == (paymentMethod.paymentMethodTypeId))

[SRC]if (!tryEntity) userLoginData = UtilHttp.getParameterMap(request)

[MSG]The if statement lacks braces

[SRC]if (!userLoginData) userLoginData = [:]

[MSG]The if statement lacks braces

[SRC]if ("OrderAdjustment".equals(valueObj.getEntityName())) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to OrderAdjustment.equals(valueObj.getEntityName()) method can be rewritten as (OrderAdjustment == (valueObj.getEntityName()))

[SRC]isDemoStore = !"N".equals(productStore.isDemoStore)

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to N.equals(productStore.isDemoStore) method can be rewritten as (N == (productStore.isDemoStore))

[SRC]if (paymentAddress) context.paymentAddress = paymentAddress

[MSG]The if statement lacks braces

[SRC]if (shipmentMethodType) context.shipMethDescription = sh...description

[MSG]The if statement lacks braces

[SRC]while (party = parties.next()) {

[MSG]Assignment used as conditional value, which always results in true. Use the == operator instead

[SRC]partyAndContactMechList = from("PartyAndContactMech").wh...queryList()

[MSG]The line exceeds 150 characters. The line is 169 characters.

[SRC]if (!contentId)

[MSG]The if statement lacks braces

[SRC]if (!contentId)

[MSG]The if statement lacks braces

[SRC]while (content = contents.next()) {

[MSG]Assignment used as conditional value, which always results in true. Use the == operator instead

[SRC]if (!sPassed.equals(sCached)) {

[MSG]The if statement is empty

[SRC]if (!sPassed.equals(sCached)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.forum.None. Explicit call to sPassed.equals(sCached) method can be rewritten as (sPassed == (sCached))

[SRC]if (s) suffix = "_" + s

[MSG]The if statement lacks braces

[SRC]if ("_ELECTRONIC_TEXT".equals(suffix)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.forum.None. Explicit call to _ELECTRONIC_TEXT.equals(suffix) method can be rewritten as (_ELECTRONIC_TEXT == (suffix))

[SRC]if (s) suffix += "_" + s

[MSG]The if statement lacks braces

[SRC]// NOTE: if there was an error, then don't look up and f..tomagically)

[MSG]The line exceeds 150 characters. The line is 182 characters.

[SRC]emailPartyContactDetail = from("PartyContactDetailByPurp..queryFirst()

[MSG]The line exceeds 150 characters. The line is 168 characters.

[SRC]homePhonePartyContactDetail = from("PartyContactDetailBy..queryFirst()

[MSG]The line exceeds 150 characters. The line is 169 characters.

[SRC]workPhonePartyContactDetail = from("PartyContactDetailBy..queryFirst()

[MSG]The line exceeds 150 characters. The line is 169 characters.

[SRC]if (contactMech && "POSTAL_ADDRESS".equals(contactMech.c..chTypeId)) {

[MSG]Violation in class org.apache.ofbiz.webpos.search.None. Explicit call to POSTAL_ADDRESS.equals(contactMech.contactMechTypeId) method can be rewritten as (POSTAL_ADDRESS == (contactMech.contactMechTypeId))

[SRC]if (contactMech && "POSTAL_ADDRESS".equals(contactMech.c..chTypeId)) {

[MSG]Violation in class org.apache.ofbiz.webpos.search.None. Explicit call to POSTAL_ADDRESS.equals(contactMech.contactMechTypeId) method can be rewritten as (POSTAL_ADDRESS == (contactMech.contactMechTypeId))

[SRC]while (iterator = listIterator.next()) {

[MSG]Assignment used as conditional value, which always results in true. Use the == operator instead

[SRC]while (iterator = listIterator.next()) {

[MSG]Assignment used as conditional value, which always results in true. Use the == operator instead

[SRC]while (iterator = listIterator.next()) {

[MSG]Assignment used as conditional value, which always results in true. Use the == operator instead

[SRC]if (catalogStyleSheet) globalContext.catalogStyleSheet =..ogStyleSheet

[MSG]The if statement lacks braces

[SRC]if (catalogHeaderLogo) globalContext.catalogHeaderLogo =..ogHeaderLogo

[MSG]The if statement lacks braces

[SRC]if ("SUMMARY".equals(mapKey)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.forum.None. Explicit call to SUMMARY.equals(mapKey) method can be rewritten as (SUMMARY == (mapKey))

[SRC]if ("SUMMARY".equals(mapKey)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.forum.None. Explicit call to SUMMARY.equals(mapKey) method can be rewritten as (SUMMARY == (mapKey))

[SRC]paymentMethod = from("PaymentMethod").where("partyId", p..queryFirst()

[MSG]The line exceeds 150 characters. The line is 163 characters.

[SRC]if (billToContactMechId && billToContactMechId.equals(sh..ctMechId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.customer.None. Explicit call to billToContactMechId.equals(shipToContactMechId) method can be rewritten as (billToContactMechId == (shipToContactMechId))

[SRC]if (preContactMechTypeId) context.preContactMechTypeId =..ctMechTypeId

[MSG]The if statement lacks braces

[SRC]if (paymentMethodId) context.paymentMethodId = paymentMethodId

[MSG]The if statement lacks braces

[SRC]if (!tryEntity) contactMechData = parameters

[MSG]The if statement lacks braces

[SRC]if (!contactMechData) contactMechData = [:]

[MSG]The if statement lacks braces

[SRC]if (contactMechData) context.contactMechData = contactMechData

[MSG]The if statement lacks braces

[SRC]if (!tryEntity) partyContactMechData = parameters

[MSG]The if statement lacks braces

[SRC]if (!partyContactMechData) partyContactMechData = [:]

[MSG]The if statement lacks braces

[SRC]if (partyContactMechData) context.partyContactMechData =..tactMechData

[MSG]The if statement lacks braces

[SRC]if (!tryEntity) postalAddressData = parameters

[MSG]The if statement lacks braces

[SRC]if (!postalAddressData) postalAddressData = [:]

[MSG]The if statement lacks braces

[SRC]if (postalAddressData) context.postalAddressData = postalAddressData

[MSG]The if statement lacks braces

[SRC]if (!tryEntity) telecomNumberData = parameters

[MSG]The if statement lacks braces

[SRC]if (!telecomNumberData) telecomNumberData = [:]

[MSG]The if statement lacks braces

[SRC]if (telecomNumberData) context.telecomNumberData = telecomNumberData

[MSG]The if statement lacks braces

[SRC]if (!timesheet) return

[MSG]The if statement lacks braces

[SRC]if (estimatedMilliSeconds > 0)

[MSG]The if statement lacks braces

[SRC]lastTimeEntryOfTasks = from("TimeEntry").where("workEffo...queryList()

[MSG]The line exceeds 150 characters. The line is 155 characters.

[SRC]if (lastTimeEntryOfTasks.size() != 0) lastTimeEntry = la..ryOfTasks[0]

[MSG]The if statement lacks braces

[SRC]workEffortPartyAssigns = EntityUtil.filterByDate(entryWo..ull, false))

[MSG]The line exceeds 150 characters. The line is 153 characters.

[SRC]if ("SCAS_COMPLETED".equals(workEffortPartyAssign.statusId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to SCAS_COMPLETED.equals(workEffortPartyAssign.statusId) method can be rewritten as (SCAS_COMPLETED == (workEffortPartyAssign.statusId))

[SRC]if ("STS_COMPLETED".equals(entryWorkEffort.currentStatusId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to STS_COMPLETED.equals(entryWorkEffort.currentStatusId) method can be rewritten as (STS_COMPLETED == (entryWorkEffort.currentStatusId))

[SRC]if (aHours > 0.00)

[MSG]The if statement lacks braces

[SRC](!lastTimeEntry.workEffortId.equals(timeEntry.workEffortId) ||

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to lastTimeEntry.workEffortId.equals(timeEntry.workEffortId) method can be rewritten as (lastTimeEntry.workEffortId == (timeEntry.workEffortId))

[SRC]!lastTimeEntry.rateTypeId.equals(timeEntry.rateTypeId))) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to lastTimeEntry.rateTypeId.equals(timeEntry.rateTypeId) method can be rewritten as (lastTimeEntry.rateTypeId == (timeEntry.rateTypeId))

[SRC]if ("d0".equals(dayNumber)) day0Total += hours

[MSG]The if statement lacks braces

[SRC]if ("d0".equals(dayNumber)) day0Total += hours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to d0.equals(dayNumber) method can be rewritten as (d0 == (dayNumber))

[SRC]if ("d1".equals(dayNumber)) day1Total += hours

[MSG]The if statement lacks braces

[SRC]if ("d1".equals(dayNumber)) day1Total += hours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to d1.equals(dayNumber) method can be rewritten as (d1 == (dayNumber))

[SRC]if ("d2".equals(dayNumber)) day2Total += hours

[MSG]The if statement lacks braces

[SRC]if ("d2".equals(dayNumber)) day2Total += hours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to d2.equals(dayNumber) method can be rewritten as (d2 == (dayNumber))

[SRC]if ("d3".equals(dayNumber)) day3Total += hours

[MSG]The if statement lacks braces

[SRC]if ("d3".equals(dayNumber)) day3Total += hours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to d3.equals(dayNumber) method can be rewritten as (d3 == (dayNumber))

[SRC]if ("d4".equals(dayNumber)) day4Total += hours

[MSG]The if statement lacks braces

[SRC]if ("d4".equals(dayNumber)) day4Total += hours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to d4.equals(dayNumber) method can be rewritten as (d4 == (dayNumber))

[SRC]if ("d5".equals(dayNumber)) day5Total += hours

[MSG]The if statement lacks braces

[SRC]if ("d5".equals(dayNumber)) day5Total += hours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to d5.equals(dayNumber) method can be rewritten as (d5 == (dayNumber))

[SRC]if ("d6".equals(dayNumber)) day6Total += hours

[MSG]The if statement lacks braces

[SRC]if ("d6".equals(dayNumber)) day6Total += hours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to d6.equals(dayNumber) method can be rewritten as (d6 == (dayNumber))

[SRC]if ("pd0".equals(dayNumber)) pDay0Total += planHours

[MSG]The if statement lacks braces

[SRC]if ("pd0".equals(dayNumber)) pDay0Total += planHours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to pd0.equals(dayNumber) method can be rewritten as (pd0 == (dayNumber))

[SRC]if ("pd1".equals(dayNumber)) pDay1Total += planHours

[MSG]The if statement lacks braces

[SRC]if ("pd1".equals(dayNumber)) pDay1Total += planHours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to pd1.equals(dayNumber) method can be rewritten as (pd1 == (dayNumber))

[SRC]if ("pd2".equals(dayNumber)) pDay2Total += planHours

[MSG]The if statement lacks braces

[SRC]if ("pd2".equals(dayNumber)) pDay2Total += planHours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to pd2.equals(dayNumber) method can be rewritten as (pd2 == (dayNumber))

[SRC]if ("pd3".equals(dayNumber)) pDay3Total += planHours

[MSG]The if statement lacks braces

[SRC]if ("pd3".equals(dayNumber)) pDay3Total += planHours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to pd3.equals(dayNumber) method can be rewritten as (pd3 == (dayNumber))

[SRC]if ("pd4".equals(dayNumber)) pDay4Total += planHours

[MSG]The if statement lacks braces

[SRC]if ("pd4".equals(dayNumber)) pDay4Total += planHours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to pd4.equals(dayNumber) method can be rewritten as (pd4 == (dayNumber))

[SRC]if ("pd5".equals(dayNumber)) pDay5Total += planHours

[MSG]The if statement lacks braces

[SRC]if ("pd5".equals(dayNumber)) pDay5Total += planHours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to pd5.equals(dayNumber) method can be rewritten as (pd5 == (dayNumber))

[SRC]if ("pd6".equals(dayNumber)) pDay6Total += planHours

[MSG]The if statement lacks braces

[SRC]if ("pd6".equals(dayNumber)) pDay6Total += planHours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to pd6.equals(dayNumber) method can be rewritten as (pd6 == (dayNumber))

[SRC]["userLogin": parameters.userLogin, "partyId": lastEmplL..y.fromDate])

[MSG]The line exceeds 150 characters. The line is 179 characters.

[SRC]while ((emplLeaveMap = emplLeave.next())) {

[MSG]Assignment used as conditional value, which always results in true. Use the == operator instead

[SRC]!lastEmplLeaveEntry.leaveTypeId.equals(emplLeaveEntry.leaveTypeId) ||

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to lastEmplLeaveEntry.leaveTypeId.equals(emplLeaveEntry.leaveTypeId) method can be rewritten as (lastEmplLeaveEntry.leaveTypeId == (emplLeaveEntry.leaveTypeId))

[SRC]!lastEmplLeaveEntry.partyId.equals(emplLeaveEntry.partyId))) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to lastEmplLeaveEntry.partyId.equals(emplLeaveEntry.partyId) method can be rewritten as (lastEmplLeaveEntry.partyId == (emplLeaveEntry.partyId))

[SRC]["userLogin": parameters.userLogin, "partyId": emplLeave..y.fromDate])

[MSG]The line exceeds 150 characters. The line is 159 characters.

[SRC]["userLogin": parameters.userLogin, "partyId": emplLeave..y.fromDate])

[MSG]The line exceeds 150 characters. The line is 163 characters.

[SRC]if ("d0".equals(leaveDayNumber)) day0Total += leaveHours

[MSG]The if statement lacks braces

[SRC]if ("d0".equals(leaveDayNumber)) day0Total += leaveHours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to d0.equals(leaveDayNumber) method can be rewritten as (d0 == (leaveDayNumber))

[SRC]if ("d1".equals(leaveDayNumber)) day1Total += leaveHours

[MSG]The if statement lacks braces

[SRC]if ("d1".equals(leaveDayNumber)) day1Total += leaveHours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to d1.equals(leaveDayNumber) method can be rewritten as (d1 == (leaveDayNumber))

[SRC]if ("d2".equals(leaveDayNumber)) day2Total += leaveHours

[MSG]The if statement lacks braces

[SRC]if ("d2".equals(leaveDayNumber)) day2Total += leaveHours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to d2.equals(leaveDayNumber) method can be rewritten as (d2 == (leaveDayNumber))

[SRC]if ("d3".equals(leaveDayNumber)) day3Total += leaveHours

[MSG]The if statement lacks braces

[SRC]if ("d3".equals(leaveDayNumber)) day3Total += leaveHours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to d3.equals(leaveDayNumber) method can be rewritten as (d3 == (leaveDayNumber))

[SRC]if ("d4".equals(leaveDayNumber)) day4Total += leaveHours

[MSG]The if statement lacks braces

[SRC]if ("d4".equals(leaveDayNumber)) day4Total += leaveHours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to d4.equals(leaveDayNumber) method can be rewritten as (d4 == (leaveDayNumber))

[SRC]if ("d5".equals(leaveDayNumber)) day5Total += leaveHours

[MSG]The if statement lacks braces

[SRC]if ("d5".equals(leaveDayNumber)) day5Total += leaveHours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to d5.equals(leaveDayNumber) method can be rewritten as (d5 == (leaveDayNumber))

[SRC]if ("d6".equals(leaveDayNumber)) day6Total += leaveHours

[MSG]The if statement lacks braces

[SRC]if ("d6".equals(leaveDayNumber)) day6Total += leaveHours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to d6.equals(leaveDayNumber) method can be rewritten as (d6 == (leaveDayNumber))

[SRC]["userLogin": parameters.userLogin, "partyId": emplLeave..y.fromDate])

[MSG]The line exceeds 150 characters. The line is 163 characters.

[SRC]if ("pd0".equals(leavePlanDay)) pDay0Total += leavePlanHours

[MSG]The if statement lacks braces

[SRC]if ("pd0".equals(leavePlanDay)) pDay0Total += leavePlanHours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to pd0.equals(leavePlanDay) method can be rewritten as (pd0 == (leavePlanDay))

[SRC]if ("pd1".equals(leavePlanDay)) pDay1Total += leavePlanHours

[MSG]The if statement lacks braces

[SRC]if ("pd1".equals(leavePlanDay)) pDay1Total += leavePlanHours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to pd1.equals(leavePlanDay) method can be rewritten as (pd1 == (leavePlanDay))

[SRC]if ("pd2".equals(leavePlanDay)) pDay2Total += leavePlanHours

[MSG]The if statement lacks braces

[SRC]if ("pd2".equals(leavePlanDay)) pDay2Total += leavePlanHours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to pd2.equals(leavePlanDay) method can be rewritten as (pd2 == (leavePlanDay))

[SRC]if ("pd3".equals(leavePlanDay)) pDay3Total += leavePlanHours

[MSG]The if statement lacks braces

[SRC]if ("pd3".equals(leavePlanDay)) pDay3Total += leavePlanHours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to pd3.equals(leavePlanDay) method can be rewritten as (pd3 == (leavePlanDay))

[SRC]if ("pd4".equals(leavePlanDay)) pDay4Total += leavePlanHours

[MSG]The if statement lacks braces

[SRC]if ("pd4".equals(leavePlanDay)) pDay4Total += leavePlanHours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to pd4.equals(leavePlanDay) method can be rewritten as (pd4 == (leavePlanDay))

[SRC]if ("pd5".equals(leavePlanDay)) pDay5Total += leavePlanHours

[MSG]The if statement lacks braces

[SRC]if ("pd5".equals(leavePlanDay)) pDay5Total += leavePlanHours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to pd5.equals(leavePlanDay) method can be rewritten as (pd5 == (leavePlanDay))

[SRC]if ("pd6".equals(leavePlanDay)) pDay6Total += leavePlanHours

[MSG]The if statement lacks braces

[SRC]if ("pd6".equals(leavePlanDay)) pDay6Total += leavePlanHours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to pd6.equals(leavePlanDay) method can be rewritten as (pd6 == (leavePlanDay))

[SRC]if (!"TIMESHEET_COMPLETED".equals(timesheet.statusId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to TIMESHEET_COMPLETED.equals(timesheet.statusId) method can be rewritten as (TIMESHEET_COMPLETED == (timesheet.statusId))

[SRC]timesheets = new LinkedList()

[MSG]LinkedList objects are better instantiated using the form "[] as Queue"

[SRC]while ((emplLeaveMap = emplLeaveList.next())) {

[MSG]Assignment used as conditional value, which always results in true. Use the == operator instead

[SRC]["userLogin": parameters.userLogin, "partyId": emplLeave..y.fromDate])

[MSG]The line exceeds 150 characters. The line is 163 characters.

[SRC]projectAndTaskList = from("ProjectSprintBacklogAndTask")...queryList()

[MSG]The line exceeds 150 characters. The line is 199 characters.

[SRC]if ("RF_SCRUM_MEETINGS".equals(custRequestTypeId) && "CR..StatusId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to RF_SCRUM_MEETINGS.equals(custRequestTypeId) method can be rewritten as (RF_SCRUM_MEETINGS == (custRequestTypeId))

[SRC]if ("RF_SCRUM_MEETINGS".equals(custRequestTypeId) && "CR..StatusId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to CRQ_REVIEWED.equals(backlogStatusId) method can be rewritten as (CRQ_REVIEWED == (backlogStatusId))

[SRC]custRequestList = from("CustRequest").where("custRequest...queryList()

[MSG]The line exceeds 150 characters. The line is 160 characters.

[SRC]if (productId.equals(productOut)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to productId.equals(productOut) method can be rewritten as (productId == (productOut))

[SRC]partyAssignmentTaskList = from("WorkEffortPartyAssignmen...queryList()

[MSG]The line exceeds 150 characters. The line is 156 characters.

[SRC]partyContactMech = from("PartyContactMech").where("party..queryFirst()

[MSG]The line exceeds 150 characters. The line is 155 characters.

[SRC]if (!tryEntity) creditCardData = parameters

[MSG]The if statement lacks braces

[SRC]if (!creditCardData) creditCardData = [:]

[MSG]The if statement lacks braces

[SRC]if (creditCardData) context.creditCardData = creditCardData

[MSG]The if statement lacks braces

[SRC]if (!tryEntity) giftCardData = parameters

[MSG]The if statement lacks braces

[SRC]if (!giftCardData) giftCardData = [:]

[MSG]The if statement lacks braces

[SRC]if (giftCardData) context.giftCardData = giftCardData

[MSG]The if statement lacks braces

[SRC]if (!tryEntity) eftAccountData = parameters

[MSG]The if statement lacks braces

[SRC]if (!eftAccountData) eftAccountData = [:]

[MSG]The if statement lacks braces

[SRC]if (eftAccountData) context.eftAccountData = eftAccountData

[MSG]The if statement lacks braces

[SRC]if (!tryEntity) paymentMethodData = parameters

[MSG]The if statement lacks braces

[SRC]if (!paymentMethodData) paymentMethodData = [:]

[MSG]The if statement lacks braces

[SRC]if (paymentMethodData) context.paymentMethodData = paymentMethodData

[MSG]The if statement lacks braces

[SRC]if (!security.hasEntityPermission("PARTYMGR", "_VIEW", s...partyId)) {

[MSG]The line exceeds 150 characters. The line is 217 characters.

[SRC]if (!security.hasEntityPermission("PARTYMGR", "_VIEW", s...partyId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.customer.None. Explicit call to userLogin.partyId.equals(context.paymentMethod.partyId) method can be rewritten as (userLogin.partyId == (context.paymentMethod.partyId))

[SRC]if (!tryEntity) personData = UtilHttp.getParameterMap(request)

[MSG]The if statement lacks braces

[SRC]if (!personData) personData = [:]

[MSG]The if statement lacks braces

[SRC]if ("PERSON".equals(party.partyTypeId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.customer.None. Explicit call to PERSON.equals(party.partyTypeId) method can be rewritten as (PERSON == (party.partyTypeId))

[SRC]if (userLogin)

[MSG]Opening brace should be on the same line as 'if'

[SRC]calcPriceOutMap = runService('calculateProductPrice', [p..: userLogin,

[MSG]The line exceeds 150 characters. The line is 181 characters.

[SRC]if ("ASSET_USAGE".equals(product.productTypeId) || "ASSE..ctTypeId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.shoppinglist.None. Explicit call to ASSET_USAGE.equals(product.productTypeId) method can be rewritten as (ASSET_USAGE == (product.productTypeId))

[SRC]if ("ASSET_USAGE".equals(product.productTypeId) || "ASSE..ctTypeId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.shoppinglist.None. Explicit call to ASSET_USAGE_OUT_IN.equals(product.productTypeId) method can be rewritten as (ASSET_USAGE_OUT_IN == (product.productTypeId))

[SRC]if ("Y".equals(product.isVirtual)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.shoppinglist.None. Explicit call to Y.equals(product.isVirtual) method can be rewritten as (Y == (product.isVirtual))

[SRC]childShoppingLists = from("ShoppingList").where("partyId...queryList()

[MSG]The line exceeds 150 characters. The line is 169 characters.

[SRC]childShoppingListPriceMap = runService('calculateShoppin..rencyUomId])

[MSG]The line exceeds 150 characters. The line is 254 characters.

[SRC]context.canView = userLogin.partyId.equals(shoppingList.partyId)

[MSG]Violation in class org.apache.ofbiz.ecommerce.shoppinglist.None. Explicit call to userLogin.partyId.equals(shoppingList.partyId) method can be rewritten as (userLogin.partyId == (shoppingList.partyId))

[SRC]if ("SLT_AUTO_REODR".equals(shoppingListType?.shoppingListTypeId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.shoppinglist.None. Explicit call to SLT_AUTO_REODR.equals(shoppingListType?.shoppingListTypeId) method can be rewritten as (SLT_AUTO_REODR == (shoppingListType?.shoppingListTypeId))

[SRC]if (userLogin.partyId.equals(shoppingList.partyId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.shoppinglist.None. Explicit call to userLogin.partyId.equals(shoppingList.partyId) method can be rewritten as (userLogin.partyId == (shoppingList.partyId))

[SRC]if (!timesheet) return

[MSG]The if statement lacks braces

[SRC]workEffortPartyAssigns = EntityUtil.filterByDate(entryWo..ull, false))

[MSG]The line exceeds 150 characters. The line is 153 characters.

[SRC]if ("PAS_COMPLETED".equals(workEffortPartyAssign.statusId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to PAS_COMPLETED.equals(workEffortPartyAssign.statusId) method can be rewritten as (PAS_COMPLETED == (workEffortPartyAssign.statusId))

[SRC](!lastTimeEntry.workEffortId.equals(timeEntry.workEffortId) ||

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to lastTimeEntry.workEffortId.equals(timeEntry.workEffortId) method can be rewritten as (lastTimeEntry.workEffortId == (timeEntry.workEffortId))

[SRC]!lastTimeEntry.rateTypeId.equals(timeEntry.rateTypeId))) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to lastTimeEntry.rateTypeId.equals(timeEntry.rateTypeId) method can be rewritten as (lastTimeEntry.rateTypeId == (timeEntry.rateTypeId))

[SRC]if ("d0".equals(dayNumber)) day0Total += hours

[MSG]The if statement lacks braces

[SRC]if ("d0".equals(dayNumber)) day0Total += hours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to d0.equals(dayNumber) method can be rewritten as (d0 == (dayNumber))

[SRC]if ("d1".equals(dayNumber)) day1Total += hours

[MSG]The if statement lacks braces

[SRC]if ("d1".equals(dayNumber)) day1Total += hours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to d1.equals(dayNumber) method can be rewritten as (d1 == (dayNumber))

[SRC]if ("d2".equals(dayNumber)) day2Total += hours

[MSG]The if statement lacks braces

[SRC]if ("d2".equals(dayNumber)) day2Total += hours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to d2.equals(dayNumber) method can be rewritten as (d2 == (dayNumber))

[SRC]if ("d3".equals(dayNumber)) day3Total += hours

[MSG]The if statement lacks braces

[SRC]if ("d3".equals(dayNumber)) day3Total += hours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to d3.equals(dayNumber) method can be rewritten as (d3 == (dayNumber))

[SRC]if ("d4".equals(dayNumber)) day4Total += hours

[MSG]The if statement lacks braces

[SRC]if ("d4".equals(dayNumber)) day4Total += hours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to d4.equals(dayNumber) method can be rewritten as (d4 == (dayNumber))

[SRC]if ("d5".equals(dayNumber)) day5Total += hours

[MSG]The if statement lacks braces

[SRC]if ("d5".equals(dayNumber)) day5Total += hours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to d5.equals(dayNumber) method can be rewritten as (d5 == (dayNumber))

[SRC]if ("d6".equals(dayNumber)) day6Total += hours

[MSG]The if statement lacks braces

[SRC]if ("d6".equals(dayNumber)) day6Total += hours

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to d6.equals(dayNumber) method can be rewritten as (d6 == (dayNumber))

[SRC]if (!"TIMESHEET_COMPLETED".equals(timesheet.statusId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to TIMESHEET_COMPLETED.equals(timesheet.statusId) method can be rewritten as (TIMESHEET_COMPLETED == (timesheet.statusId))

[SRC]timesheets = new LinkedList()

[MSG]LinkedList objects are better instantiated using the form "[] as Queue"

[SRC]if (!timesheet) return

[MSG]The if statement lacks braces

[SRC]workEffortPartyAssigns = EntityUtil.filterByDate(entryWo..ull, false))

[MSG]The line exceeds 150 characters. The line is 153 characters.

[SRC]if ("PAS_COMPLETED".equals(workEffortPartyAssign.statusId)) {

[MSG]Violation in class org.apache.ofbiz.projectmgr.None. Explicit call to PAS_COMPLETED.equals(workEffortPartyAssign.statusId) method can be rewritten as (PAS_COMPLETED == (workEffortPartyAssign.statusId))

[SRC](!lastTimeEntry.workEffortId.equals(timeEntry.workEffortId) ||

[MSG]Violation in class org.apache.ofbiz.projectmgr.None. Explicit call to lastTimeEntry.workEffortId.equals(timeEntry.workEffortId) method can be rewritten as (lastTimeEntry.workEffortId == (timeEntry.workEffortId))

[SRC]!lastTimeEntry.rateTypeId.equals(timeEntry.rateTypeId))) {

[MSG]Violation in class org.apache.ofbiz.projectmgr.None. Explicit call to lastTimeEntry.rateTypeId.equals(timeEntry.rateTypeId) method can be rewritten as (lastTimeEntry.rateTypeId == (timeEntry.rateTypeId))

[SRC]if ("d0".equals(dayNumber)) day0Total += hours

[MSG]The if statement lacks braces

[SRC]if ("d0".equals(dayNumber)) day0Total += hours

[MSG]Violation in class org.apache.ofbiz.projectmgr.None. Explicit call to d0.equals(dayNumber) method can be rewritten as (d0 == (dayNumber))

[SRC]if ("d1".equals(dayNumber)) day1Total += hours

[MSG]The if statement lacks braces

[SRC]if ("d1".equals(dayNumber)) day1Total += hours

[MSG]Violation in class org.apache.ofbiz.projectmgr.None. Explicit call to d1.equals(dayNumber) method can be rewritten as (d1 == (dayNumber))

[SRC]if ("d2".equals(dayNumber)) day2Total += hours

[MSG]The if statement lacks braces

[SRC]if ("d2".equals(dayNumber)) day2Total += hours

[MSG]Violation in class org.apache.ofbiz.projectmgr.None. Explicit call to d2.equals(dayNumber) method can be rewritten as (d2 == (dayNumber))

[SRC]if ("d3".equals(dayNumber)) day3Total += hours

[MSG]The if statement lacks braces

[SRC]if ("d3".equals(dayNumber)) day3Total += hours

[MSG]Violation in class org.apache.ofbiz.projectmgr.None. Explicit call to d3.equals(dayNumber) method can be rewritten as (d3 == (dayNumber))

[SRC]if ("d4".equals(dayNumber)) day4Total += hours

[MSG]The if statement lacks braces

[SRC]if ("d4".equals(dayNumber)) day4Total += hours

[MSG]Violation in class org.apache.ofbiz.projectmgr.None. Explicit call to d4.equals(dayNumber) method can be rewritten as (d4 == (dayNumber))

[SRC]if ("d5".equals(dayNumber)) day5Total += hours

[MSG]The if statement lacks braces

[SRC]if ("d5".equals(dayNumber)) day5Total += hours

[MSG]Violation in class org.apache.ofbiz.projectmgr.None. Explicit call to d5.equals(dayNumber) method can be rewritten as (d5 == (dayNumber))

[SRC]if ("d6".equals(dayNumber)) day6Total += hours

[MSG]The if statement lacks braces

[SRC]if ("d6".equals(dayNumber)) day6Total += hours

[MSG]Violation in class org.apache.ofbiz.projectmgr.None. Explicit call to d6.equals(dayNumber) method can be rewritten as (d6 == (dayNumber))

[SRC]if (!"TIMESHEET_COMPLETED".equals(timesheet.statusId)) {

[MSG]Violation in class org.apache.ofbiz.projectmgr.None. Explicit call to TIMESHEET_COMPLETED.equals(timesheet.statusId) method can be rewritten as (TIMESHEET_COMPLETED == (timesheet.statusId))

[SRC]timesheets = new LinkedList()

[MSG]LinkedList objects are better instantiated using the form "[] as Queue"

[SRC]int countImplTask=0, countImplTaskComplete=0, countInsta..ntTestTask=0

[MSG]The line exceeds 150 characters. The line is 157 characters.

[SRC]def module = "FindProductBacklogItem.groovy"

[MSG]The variable [module] in class org.apache.ofbiz.scrum.None is not used

[SRC]if ("Y".equals(parameters.noConditionFind)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to Y.equals(parameters.noConditionFind) method can be rewritten as (Y == (parameters.noConditionFind))

[SRC]backlogList = select("custRequestId","custRequestTypeId"..romPartyId")

[MSG]The line exceeds 150 characters. The line is 231 characters.

[SRC]if ("N".equals(parameters.sequence)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to N.equals(parameters.sequence) method can be rewritten as (N == (parameters.sequence))

[SRC]final String module = "GetThirdPartyLogins.groovy"

[MSG]The variable [module] in class org.apache.ofbiz.passport.login.None is not used

[SRC]storeLoginMethDetail = from(storeLoginMeth.loginMethType..ueryFirst();

[MSG]The line exceeds 150 characters. The line is 173 characters.

[SRC]if (!contentIdTo || !"TEMPLATE_MASTER".equals(contentIdTo)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.forum.None. Explicit call to TEMPLATE_MASTER.equals(contentIdTo) method can be rewritten as (TEMPLATE_MASTER == (contentIdTo))

[SRC]ScriptUtil.executeScript('component://product/src/main/g..ll, context)

[MSG]The line exceeds 150 characters. The line is 158 characters.

[SRC]while (product = products.next()) {

[MSG]Assignment used as conditional value, which always results in true. Use the == operator instead

[SRC]} catch (Exception exc) {}

[MSG]The catch block is empty

[SRC]if (!parameters.clearSearch || !"N".equals(parameters.clearSearch)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.catalog.None. Explicit call to N.equals(parameters.clearSearch) method can be rewritten as (N == (parameters.clearSearch))

[SRC]thisSubCategoryList.add([productCategoryId: subCategory...entWrapper])

[MSG]The line exceeds 150 characters. The line is 200 characters.

[SRC]availablePriceRangeList = [[low: "0", high: "10"], [low:..igh: "100"]]

[MSG]The line exceeds 150 characters. The line is 276 characters.

[SRC]priceRangeConstraint = new ProductSearch.ListPriceRangeC..om(request))

[MSG]The line exceeds 150 characters. The line is 168 characters.

[SRC]priceRangeCount = ProductSearchSession.getCountForListPr.., delegator)

[MSG]The line exceeds 150 characters. The line is 157 characters.

[SRC]if ("Any".equals(statusId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to Any.equals(statusId) method can be rewritten as (Any == (statusId))

[SRC]if ("PRODUCT_ACTIVE".equals(statusId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to PRODUCT_ACTIVE.equals(statusId) method can be rewritten as (PRODUCT_ACTIVE == (statusId))

[SRC]if ("SCRUM_PRODUCT_OWNER".equals(groupId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to SCRUM_PRODUCT_OWNER.equals(groupId) method can be rewritten as (SCRUM_PRODUCT_OWNER == (groupId))

[SRC]productAndRoleList = from("ProductRole").where("productI...queryList()

[MSG]The line exceeds 150 characters. The line is 158 characters.

[SRC]if (productIdInner.equals(product.productId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to productIdInner.equals(product.productId) method can be rewritten as (productIdInner == (product.productId))

[SRC]} else if ("SCRUM_STAKEHOLDER".equals(groupId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to SCRUM_STAKEHOLDER.equals(groupId) method can be rewritten as (SCRUM_STAKEHOLDER == (groupId))

[SRC]productRoleList = from("ProductRole").where("partyId", s...queryList()

[MSG]The line exceeds 150 characters. The line is 187 characters.

[SRC]if (stakeholderProduct.equals(product.productId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to stakeholderProduct.equals(product.productId) method can be rewritten as (stakeholderProduct == (product.productId))

[SRC]productAndRoleList = from("ProductAndRole").where("produ...queryList()

[MSG]The line exceeds 150 characters. The line is 235 characters.

[SRC]} else if ("SCRUM_MASTER".equals(groupId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to SCRUM_MASTER.equals(groupId) method can be rewritten as (SCRUM_MASTER == (groupId))

[SRC]productRoleList = from("ProductAndRole").where("productI...queryList()

[MSG]The line exceeds 150 characters. The line is 229 characters.

[SRC]projects = from("WorkEffortAndProduct").where("productId...queryList()

[MSG]The line exceeds 150 characters. The line is 183 characters.

[SRC]projectPartyAssignment = from("WorkEffortPartyAssignment...queryList()

[MSG]The line exceeds 150 characters. The line is 176 characters.

[SRC]allSprintList = from("WorkEffort").where("workEffortPare...queryList()

[MSG]The line exceeds 150 characters. The line is 160 characters.

[SRC]allSprintList.each { SprintListMap ->

[MSG]The parameter named SprintListMap in method <closure> of class org.apache.ofbiz.scrum.None does not match [a-z][a-zA-Z0-9]*

[SRC]workEffortPartyAssignment = from("WorkEffortPartyAssignm...queryList()

[MSG]The line exceeds 150 characters. The line is 167 characters.

[SRC]projects = from("WorkEffortAndProduct").where("productId...queryList()

[MSG]The line exceeds 150 characters. The line is 179 characters.

[SRC]allSprintList = from("WorkEffort").where("workEffortPare...queryList()

[MSG]The line exceeds 150 characters. The line is 160 characters.

[SRC]allSprintList.each { SprintListMap ->

[MSG]The parameter named SprintListMap in method <closure> of class org.apache.ofbiz.scrum.None does not match [a-z][a-zA-Z0-9]*

[SRC]workEffortPartyAssignment = from("WorkEffortPartyAssignm...queryList()

[MSG]The line exceeds 150 characters. The line is 167 characters.

[SRC]workEffortPartyAssignment = from("WorkEffortPartyAssignm...queryList()

[MSG]The line exceeds 150 characters. The line is 171 characters.

[SRC]if(addAllProducts)

[MSG]The if statement lacks braces

[SRC]resultAssign = from("WorkEffortPartyAssignment").where("...queryList()

[MSG]The line exceeds 150 characters. The line is 153 characters.

[SRC]|| ((security.hasEntityPermission("PROJECTMGR", "_ROLE_A..ltAssign)) {

[MSG]The line exceeds 150 characters. The line is 169 characters.

[SRC]partyAndSecurityGroupList = select("partyId", "groupId")...queryList()

[MSG]The line exceeds 150 characters. The line is 157 characters.

[SRC]if (product != null) productName = product.internalName

[MSG]The if statement lacks braces

[SRC]if ("SCRUM_PRODUCT_OWNER".equals(groupId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to SCRUM_PRODUCT_OWNER.equals(groupId) method can be rewritten as (SCRUM_PRODUCT_OWNER == (groupId))

[SRC]productAndRoleList = from("ProductRole").where("productI...queryList()

[MSG]The line exceeds 150 characters. The line is 177 characters.

[SRC]productAndRoleList = from("ProductRole").where("productI...queryList()

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to partyAndSecurityGroupList.getAt(0) method can be rewritten as partyAndSecurityGroupList[(0)]

[SRC]}else if("SCRUM_STAKEHOLDER".equals(groupId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to SCRUM_STAKEHOLDER.equals(groupId) method can be rewritten as (SCRUM_STAKEHOLDER == (groupId))

[SRC]productRoleList = from("ProductRole").where("partyId", s...queryList()

[MSG]The line exceeds 150 characters. The line is 182 characters.

[SRC]if (stakeholderProduct.equals(sprint.productId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to stakeholderProduct.equals(sprint.productId) method can be rewritten as (stakeholderProduct == (sprint.productId))

[SRC]} else if("SCRUM_MASTER".equals(groupId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to SCRUM_MASTER.equals(groupId) method can be rewritten as (SCRUM_MASTER == (groupId))

[SRC]projectPartyAssignment = from("WorkEffortPartyAssignment...queryList()

[MSG]The line exceeds 150 characters. The line is 159 characters.

[SRC]allSprintList.each { SprintListMap ->

[MSG]The parameter named SprintListMap in method <closure> of class org.apache.ofbiz.scrum.None does not match [a-z][a-zA-Z0-9]*

[SRC]workEffortPartyAssignment = from("WorkEffortPartyAssignm...queryList()

[MSG]The line exceeds 150 characters. The line is 158 characters.

[SRC]allSprintList.each { SprintListMap ->

[MSG]The parameter named SprintListMap in method <closure> of class org.apache.ofbiz.scrum.None does not match [a-z][a-zA-Z0-9]*

[SRC]workEffortPartyAssignment = from("WorkEffortPartyAssignm...queryList()

[MSG]The line exceeds 150 characters. The line is 154 characters.

[SRC]|| security.hasEntityPermission("SCRUM_PROJECT", "_ROLE_..W", session)

[MSG]The line exceeds 150 characters. The line is 153 characters.

[SRC]if ("SCRUM_PRODUCT_OWNER".equals(groupId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to SCRUM_PRODUCT_OWNER.equals(groupId) method can be rewritten as (SCRUM_PRODUCT_OWNER == (groupId))

[SRC]productAndRoleList = from("ProductRole").where("productI...queryList()

[MSG]The line exceeds 150 characters. The line is 181 characters.

[SRC]productAndRoleList = from("ProductRole").where("productI...queryList()

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to partyAndSecurityGroupList.getAt(0) method can be rewritten as partyAndSecurityGroupList[(0)]

[SRC]}else if("SCRUM_STAKEHOLDER".equals(groupId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to SCRUM_STAKEHOLDER.equals(groupId) method can be rewritten as (SCRUM_STAKEHOLDER == (groupId))

[SRC]productRoleList = from("ProductRole").where("partyId", s...queryList()

[MSG]The line exceeds 150 characters. The line is 190 characters.

[SRC]if (stakeholderProduct.equals(sprint.productId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to stakeholderProduct.equals(sprint.productId) method can be rewritten as (stakeholderProduct == (sprint.productId))

[SRC]productAndRoleList = from("ProductAndRole").where("produ...queryList()

[MSG]The line exceeds 150 characters. The line is 237 characters.

[SRC]} else if("SCRUM_MASTER".equals(groupId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to SCRUM_MASTER.equals(groupId) method can be rewritten as (SCRUM_MASTER == (groupId))

[SRC]productRoleList = from("ProductAndRole").where("productI...queryList()

[MSG]The line exceeds 150 characters. The line is 231 characters.

[SRC]projectPartyAssignment = from("WorkEffortPartyAssignment...queryList()

[MSG]The line exceeds 150 characters. The line is 167 characters.

[SRC]allSprintList.each { SprintListMap ->

[MSG]The parameter named SprintListMap in method <closure> of class org.apache.ofbiz.scrum.None does not match [a-z][a-zA-Z0-9]*

[SRC]workEffortPartyAssignment = from("WorkEffortPartyAssignm...queryList()

[MSG]The line exceeds 150 characters. The line is 166 characters.

[SRC]allSprintList.each { SprintListMap ->

[MSG]The parameter named SprintListMap in method <closure> of class org.apache.ofbiz.scrum.None does not match [a-z][a-zA-Z0-9]*

[SRC]workEffortPartyAssignment = from("WorkEffortPartyAssignm...queryList()

[MSG]The line exceeds 150 characters. The line is 158 characters.

[SRC]|| security.hasEntityPermission("SCRUM_PROJECT", "_ROLE_..W", session)

[MSG]The line exceeds 150 characters. The line is 157 characters.

[SRC]allProjects = select("workEffortId").from("WorkEffortAnd...queryList()

[MSG]The line exceeds 150 characters. The line is 187 characters.

[SRC]if (!"N".equals(result.enabled)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to N.equals(result.enabled) method can be rewritten as (N == (result.enabled))

[SRC]while ((emplLeaveMap = emplLeaveList.next())) {

[MSG]Assignment used as conditional value, which always results in true. Use the == operator instead

[SRC]["userLogin": parameters.userLogin, "partyId": emplLeave..y.fromDate])

[MSG]The line exceeds 150 characters. The line is 167 characters.

[SRC]unplannedBacklogList = from("UnPlannedBacklogsAndTasks")...queryList()

[MSG]The line exceeds 150 characters. The line is 159 characters.

[SRC]if (userLogin) priceParams.partyId = userLogin.partyId

[MSG]The if statement lacks braces

[SRC]if ("Y".equals(productStore.get("showPricesWithVatTax"))) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.catalog.None. Explicit call to Y.equals(productStore.get(showPricesWithVatTax)) method can be rewritten as (Y == (productStore.get(showPricesWithVatTax)))

[SRC]Map priceMap = runService('calcTaxForDisplay', ["basePri..uctStoreId])

[MSG]The line exceeds 150 characters. The line is 174 characters.

[SRC]if ("AGGREGATED".equals(miniProduct.productTypeId) || "A..ctTypeId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.catalog.None. Explicit call to AGGREGATED.equals(miniProduct.productTypeId) method can be rewritten as (AGGREGATED == (miniProduct.productTypeId))

[SRC]if ("AGGREGATED".equals(miniProduct.productTypeId) || "A..ctTypeId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.catalog.None. Explicit call to AGGREGATED_SERVICE.equals(miniProduct.productTypeId) method can be rewritten as (AGGREGATED_SERVICE == (miniProduct.productTypeId))

[SRC]if ("Y".equals(productStore.get("showPricesWithVatTax"))) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.catalog.None. Explicit call to Y.equals(productStore.get(showPricesWithVatTax)) method can be rewritten as (Y == (productStore.get(showPricesWithVatTax)))

[SRC]Map totalPriceMap = runService('calcTaxForDisplay', ["ba..uctStoreId])

[MSG]The line exceeds 150 characters. The line is 178 characters.

[SRC]} else {

[MSG]The else block is empty

[SRC]context.createAllowPassword = "Y".equals(productStore.allowPassword)

[MSG]Violation in class org.apache.ofbiz.ecommerce.customer.None. Explicit call to Y.equals(productStore.allowPassword) method can be rewritten as (Y == (productStore.allowPassword))

[SRC]context.getUsername = !"Y".equals(productStore.usePrimar..ailUsername)

[MSG]Violation in class org.apache.ofbiz.ecommerce.customer.None. Explicit call to Y.equals(productStore.usePrimaryEmailUsername) method can be rewritten as (Y == (productStore.usePrimaryEmailUsername))

[SRC]if ("SUPPLIER".equals(partyRole.roleTypeId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to SUPPLIER.equals(partyRole.roleTypeId) method can be rewritten as (SUPPLIER == (partyRole.roleTypeId))

[SRC]downloadOrderRoleAndProductContentInfoList = from("Order...queryList()

[MSG]The line exceeds 150 characters. The line is 239 characters.

[SRC]// we have a special case here where for an anonymous or..y check here

[MSG]The line exceeds 150 characters. The line is 178 characters.

[SRC]// This is another special case, when Order is placed by..rder Manager

[MSG]The line exceeds 150 characters. The line is 159 characters.

[SRC]filteredOrderPaymentPreferences = EntityUtil.filterByCon.._OFFLINE"]))

[MSG]The line exceeds 150 characters. The line is 189 characters.

[SRC]filteredOrderStatusList = EntityUtil.filterByCondition(o.._CREATED"]))

[MSG]The line exceeds 150 characters. The line is 203 characters.

[SRC]filteredOrderStatusList = EntityUtil.filterByCondition(o..APPROVED"]))

[MSG]The line exceeds 150 characters. The line is 186 characters.

[SRC]if ("ORDER_COMPLETED".equals(orderStatus.statusId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to ORDER_COMPLETED.equals(orderStatus.statusId) method can be rewritten as (ORDER_COMPLETED == (orderStatus.statusId))

[SRC]if ("PURCHASE_ORDER".equals(orderHeader?.orderTypeId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to PURCHASE_ORDER.equals(orderHeader?.orderTypeId) method can be rewritten as (PURCHASE_ORDER == (orderHeader?.orderTypeId))

[SRC]if (orderHeader && (!"anonymous".equals(orderHeader.crea..usView)))) {

[MSG]The line exceeds 150 characters. The line is 152 characters.

[SRC]if (orderHeader && (!"anonymous".equals(orderHeader.crea..usView)))) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to anonymous.equals(orderHeader.createdBy) method can be rewritten as (anonymous == (orderHeader.createdBy))

[SRC]if (orderHeader && (!"anonymous".equals(orderHeader.crea..usView)))) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to anonymous.equals(orderHeader.createdBy) method can be rewritten as (anonymous == (orderHeader.createdBy))

[SRC]if (orderHeader && (!"anonymous".equals(orderHeader.crea..usView)))) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to Y.equals(allowAnonymousView) method can be rewritten as (Y == (allowAnonymousView))

[SRC]logWarning("Warning: in OrderStatus.groovy before gettin..Id")) + "]")

[MSG]The line exceeds 150 characters. The line is 237 characters.

[SRC]if (productStore) isDemoStore = !"N".equals(productStore.isDemoStore)

[MSG]The if statement lacks braces

[SRC]if (productStore) isDemoStore = !"N".equals(productStore.isDemoStore)

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to N.equals(productStore.isDemoStore) method can be rewritten as (N == (productStore.isDemoStore))

[SRC]orderPaymentPreferences = EntityUtil.filterByAnd(orderHe..ANCELLED")])

[MSG]The line exceeds 150 characters. The line is 213 characters.

[SRC]if (paymentAddress) context.paymentAddress = paymentAddress

[MSG]The if statement lacks braces

[SRC]orderShipmentInfoSummaryList = select("shipmentId", "shi.."boxNumber")

[MSG]The line exceeds 150 characters. The line is 173 characters.

[SRC]customerPoNumberSet = new TreeSet()

[MSG]TreeSet objects are better instantiated using the form "[] as SortedSet"

[SRC]if (correspondingPoId && !"(none)".equals(correspondingPoId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to (none).equals(correspondingPoId) method can be rewritten as ((none) == (correspondingPoId))

[SRC]if (!"RETURN_CANCELLED".equals(rh.statusId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to RETURN_CANCELLED.equals(rh.statusId) method can be rewritten as (RETURN_CANCELLED == (rh.statusId))

[SRC]departmentPointList = ContentManagementWorker.getPermitt..ATE", null )

[MSG]The line exceeds 150 characters. The line is 172 characters.

[SRC]if (partyId && !"_NA_".equals(partyId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to _NA_.equals(partyId) method can be rewritten as (_NA_ == (partyId))

[SRC]partyContactMech = from("PartyContactMech").where("party..queryFirst()

[MSG]The line exceeds 150 characters. The line is 172 characters.

[SRC]if ("CREDIT_CARD".equals(paymentMethod?.paymentMethodTypeId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to CREDIT_CARD.equals(paymentMethod?.paymentMethodTypeId) method can be rewritten as (CREDIT_CARD == (paymentMethod?.paymentMethodTypeId))

[SRC]} else if ("EFT_ACCOUNT".equals(paymentMethod?.paymentMethodTypeId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to EFT_ACCOUNT.equals(paymentMethod?.paymentMethodTypeId) method can be rewritten as (EFT_ACCOUNT == (paymentMethod?.paymentMethodTypeId))

[SRC]} else if ("GIFT_CARD".equals(paymentMethod?.paymentMethodTypeId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to GIFT_CARD.equals(paymentMethod?.paymentMethodTypeId) method can be rewritten as (GIFT_CARD == (paymentMethod?.paymentMethodTypeId))

[SRC]if ("GIFT_CARD".equals(paymentMethodTypeId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to GIFT_CARD.equals(paymentMethodTypeId) method can be rewritten as (GIFT_CARD == (paymentMethodTypeId))

[SRC]if ("add".equals(mode)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.forum.None. Explicit call to add.equals(mode) method can be rewritten as (add == (mode))

[SRC]if ("complex".equals(permissionType)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.forum.None. Explicit call to complex.equals(permissionType) method can be rewritten as (complex == (permissionType))

[SRC]if (!currentValue || !"Content".equals(entityName)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.forum.None. Explicit call to Content.equals(entityName) method can be rewritten as (Content == (entityName))

[SRC]if (!currentValue || !"Content".equals(entityName)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.forum.None. Explicit call to Content.equals(entityName) method can be rewritten as (Content == (entityName))

[SRC]if ("add".equals(mode)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.forum.None. Explicit call to add.equals(mode) method can be rewritten as (add == (mode))

[SRC]if ("Content".equals(currentValue?.getEntityName())) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.forum.None. Explicit call to Content.equals(currentValue?.getEntityName()) method can be rewritten as (Content == (currentValue?.getEntityName()))

[SRC]if ("granted".equals(permissionStatus)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.forum.None. Explicit call to granted.equals(permissionStatus) method can be rewritten as (granted == (permissionStatus))

[SRC]productTags = from("ProductKeyword").where("keyword", pr...queryList()

[MSG]The line exceeds 150 characters. The line is 152 characters.

[SRC]double weight = 0

[MSG]The variable weight in class org.apache.ofbiz.ecommerce.catalog.None is of type double/Double. Prefer using BigDecimal.

[SRC]double fontSize = minFontSize + ((maxFontSize - minFontSize) * weight)

[MSG]The variable fontSize in class org.apache.ofbiz.ecommerce.catalog.None is of type double/Double. Prefer using BigDecimal.

[SRC]if ("EXT_OFFLINE".equals(paymentMethodTypeId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.None. Explicit call to EXT_OFFLINE.equals(paymentMethodTypeId) method can be rewritten as (EXT_OFFLINE == (paymentMethodTypeId))

[SRC]while (entryItem = entryIterator.next()) {

[MSG]Assignment used as conditional value, which always results in true. Use the == operator instead

[SRC]if ("INVOICE_IN_PROCESS".equals(invoice.getString("statusId"))) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to INVOICE_IN_PROCESS.equals(invoice.getString(statusId)) method can be rewritten as (INVOICE_IN_PROCESS == (invoice.getString(statusId)))

[SRC]if ("N".equals(includeMeeting)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to N.equals(includeMeeting) method can be rewritten as (N == (includeMeeting))

[SRC]List fillTree(rootCat ,CatLvl, parentCategoryId) {

[MSG]The parameter named CatLvl in method fillTree of class org.apache.ofbiz.ecommerce.catalog.None does not match [a-z][a-zA-Z0-9]*

[SRC]if(CatLvl==2)

[MSG]The if statement lacks braces

[SRC]else if(CatLvl==1)

[MSG]The else block lacks braces

[SRC]else if(CatLvl==1)

[MSG]The if statement lacks braces

[SRC]if(categoryContentWrapper.get("CATEGORY_NAME", "html").toString())

[MSG]The else block lacks braces

[SRC]if(categoryContentWrapper.get("CATEGORY_NAME", "html").toString())

[MSG]The if statement lacks braces

[SRC]if(categoryContentWrapper.get("DESCRIPTION", "html").toString())

[MSG]The else block lacks braces

[SRC]if(categoryContentWrapper.get("DESCRIPTION", "html").toString())

[MSG]The if statement lacks braces

[SRC]CategoryWorker.getRelatedCategories(request, "topLevelLi..est)), true)

[MSG]The line exceeds 150 characters. The line is 158 characters.

[SRC]resultsIdTo = runService('getPartyEmail', ["partyId" : d.. userLogin])

[MSG]The line exceeds 150 characters. The line is 154 characters.

[SRC]resultsIdFrom = runService('getPartyEmail', ["partyId" :.. userLogin])

[MSG]The line exceeds 150 characters. The line is 158 characters.

[SRC]if (!"Y".equals(categoryCode.substring(0, 1)) && !"".equ..goryCode)) {

[MSG]Violation in class org.apache.ofbiz.ebay.None. Explicit call to Y.equals(categoryCode.substring(0, 1)) method can be rewritten as (Y == (categoryCode.substring(0, 1)))

[SRC]if (!"Y".equals(categoryCode.substring(0, 1)) && !"".equ..goryCode)) {

[MSG]Violation in class org.apache.ofbiz.ebay.None. Explicit call to .equals(categoryCode) method can be rewritten as ( == (categoryCode))

[SRC]while (entryItem = entryIterator.next()) {

[MSG]Assignment used as conditional value, which always results in true. Use the == operator instead

[SRC]if ("INVOICE_IN_PROCESS".equals(invoice.getString("statusId"))) {

[MSG]Violation in class org.apache.ofbiz.projectmgr.None. Explicit call to INVOICE_IN_PROCESS.equals(invoice.getString(statusId)) method can be rewritten as (INVOICE_IN_PROCESS == (invoice.getString(statusId)))

[SRC]if ("INTERNAL_ORGANIZATIO".equals(member.roleTypeId)) {

[MSG]Violation in class org.apache.ofbiz.projectmgr.None. Explicit call to INTERNAL_ORGANIZATIO.equals(member.roleTypeId) method can be rewritten as (INTERNAL_ORGANIZATIO == (member.roleTypeId))

[SRC]if ("CLIENT_BILLING".equals(member.roleTypeId)) {

[MSG]Violation in class org.apache.ofbiz.projectmgr.None. Explicit call to CLIENT_BILLING.equals(member.roleTypeId) method can be rewritten as (CLIENT_BILLING == (member.roleTypeId))

[SRC]if (fromPartyId && toPartyId && fromPartyId.equals(toPartyId)) {

[MSG]Violation in class org.apache.ofbiz.projectmgr.None. Explicit call to fromPartyId.equals(toPartyId) method can be rewritten as (fromPartyId == (toPartyId))

[SRC]// NOTE: if there was an error, then don't look up and f..tomagically)

[MSG]The line exceeds 150 characters. The line is 182 characters.

[SRC]emailPartyContactDetail = from("PartyContactDetailByPurp..queryFirst()

[MSG]The line exceeds 150 characters. The line is 168 characters.

[SRC]homePhonePartyContactDetail = from("PartyContactDetailBy..queryFirst()

[MSG]The line exceeds 150 characters. The line is 169 characters.

[SRC]workPhonePartyContactDetail = from("PartyContactDetailBy..queryFirst()

[MSG]The line exceeds 150 characters. The line is 167 characters.

[SRC]if (cartPartyId && !"_NA_".equals(cartPartyId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to _NA_.equals(cartPartyId) method can be rewritten as (_NA_ == (cartPartyId))

[SRC]shippingPartyContactDetail = from("PartyContactDetailByP..queryFirst()

[MSG]The line exceeds 150 characters. The line is 166 characters.

[SRC]if ("CREDIT_CARD".equals(paymentMethod?.paymentMethodTypeId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to CREDIT_CARD.equals(paymentMethod?.paymentMethodTypeId) method can be rewritten as (CREDIT_CARD == (paymentMethod?.paymentMethodTypeId))

[MSG]package=org.apache.ofbiz.order.orderReturn

[SRC]typeMap = new HashMap()

[MSG]HashMap objects are normally instantiated using the form "[:]"

[SRC]if (!"granted".equals(permissionStatus)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.forum.None. Explicit call to granted.equals(permissionStatus) method can be rewritten as (granted == (permissionStatus))

[MSG]package=org.apache.ofbiz.order.orderReturn

[MSG]package=org.apache.ofbiz.order.orderReturn

[MSG]package=org.apache.ofbiz.order.orderReturn

[SRC]return

[MSG]Do not return null from a catch block

[SRC]if ("any".equals(paramMap.anyOrAll)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.content.None. Explicit call to any.equals(paramMap.anyOrAll) method can be rewritten as (any == (paramMap.anyOrAll))

[SRC]logInfo("in search searchFeature3, combQuery:" + combQuery.toString())

[MSG]Calling toString() on [combQuery] in class org.apache.ofbiz.ecommerce.content.None is unnecessary

[SRC]return

[MSG]Do not return null from a catch block

[SRC]if ("any".equals(parameters.any_or_all)) {

[MSG]Violation in class org.apache.ofbiz.lucene.content.None. Explicit call to any.equals(parameters.any_or_all) method can be rewritten as (any == (parameters.any_or_all))

[SRC]return

[MSG]Do not return null from a catch block

[SRC]return

[MSG]Do not return null from a catch block

[SRC]if (partyId && !"_NA_".equals(partyId)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.order.None. Explicit call to _NA_.equals(partyId) method can be rewritten as (_NA_ == (partyId))

[SRC]shippingPartyContactDetail = from("PartyContactDetailByP..queryFirst()

[MSG]The line exceeds 150 characters. The line is 162 characters.

[SRC]// NOTE: these parameters are a special case because the..over them...

[MSG]The line exceeds 150 characters. The line is 162 characters.

[SRC]if ("CASH".equals(paymentInfo.paymentMethodTypeId)) {

[MSG]Violation in class org.apache.ofbiz.webpos.cart.None. Explicit call to CASH.equals(paymentInfo.paymentMethodTypeId) method can be rewritten as (CASH == (paymentInfo.paymentMethodTypeId))

[SRC]else if ("PERSONAL_CHECK".equals(paymentInfo.paymentMethodTypeId)) {

[MSG]Violation in class org.apache.ofbiz.webpos.cart.None. Explicit call to PERSONAL_CHECK.equals(paymentInfo.paymentMethodTypeId) method can be rewritten as (PERSONAL_CHECK == (paymentInfo.paymentMethodTypeId))

[SRC]else if ("GIFT_CARD".equals(paymentInfo.paymentMethodTypeId)) {

[MSG]Violation in class org.apache.ofbiz.webpos.cart.None. Explicit call to GIFT_CARD.equals(paymentInfo.paymentMethodTypeId) method can be rewritten as (GIFT_CARD == (paymentInfo.paymentMethodTypeId))

[SRC]else if ("CREDIT_CARD".equals(paymentInfo.paymentMethodTypeId)) {

[MSG]Violation in class org.apache.ofbiz.webpos.cart.None. Explicit call to CREDIT_CARD.equals(paymentInfo.paymentMethodTypeId) method can be rewritten as (CREDIT_CARD == (paymentInfo.paymentMethodTypeId))

[SRC]if (promoText && !"N".equals(productPromo.showToCustomer)) {

[MSG]Violation in class org.apache.ofbiz.ecommerce.cart.None. Explicit call to N.equals(productPromo.showToCustomer) method can be rewritten as (N == (productPromo.showToCustomer))

[SRC]randomIndex = Math.round(java.lang.Math.random() * (prod..- 1)) as int

[MSG]Using Math.random() is insecure. Use SecureRandom instead

[SRC]CategoryWorker.getRelatedCategories(request, "topLevelLi..est)), true)

[MSG]The line exceeds 150 characters. The line is 158 characters.

[SRC]if ("SPRINT_CLOSED".equals(currentStatus)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to SPRINT_CLOSED.equals(currentStatus) method can be rewritten as (SPRINT_CLOSED == (currentStatus))

[SRC]if ("CRQ_REVIEWED".equals(custMap.statusId)){

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to CRQ_REVIEWED.equals(custMap.statusId) method can be rewritten as (CRQ_REVIEWED == (custMap.statusId))

[SRC]if (!"SCRUM_SPRINT".equals(workEffMap.workEffortTypeId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to SCRUM_SPRINT.equals(workEffMap.workEffortTypeId) method can be rewritten as (SCRUM_SPRINT == (workEffMap.workEffortTypeId))

[SRC]if ("STS_CREATED".equals(workEffMap.currentStatusId)){

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to STS_CREATED.equals(workEffMap.currentStatusId) method can be rewritten as (STS_CREATED == (workEffMap.currentStatusId))

[SRC]if ("SCRUM_SPRINT".equals(workEffortMap.workEffortTypeId..StatusId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to SCRUM_SPRINT.equals(workEffortMap.workEffortTypeId) method can be rewritten as (SCRUM_SPRINT == (workEffortMap.workEffortTypeId))

[SRC]if ("SCRUM_SPRINT".equals(workEffortMap.workEffortTypeId..StatusId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to SPRINT_ACTIVE.equals(workEffortMap.currentStatusId) method can be rewritten as (SPRINT_ACTIVE == (workEffortMap.currentStatusId))

[SRC]//${projectId} - ${projectName} - ${sprintName} - ${groo..{taskId}]"/>

[MSG]The line exceeds 150 characters. The line is 215 characters.

[SRC]taskUnplanList = from("ProjectSprintBacklogTaskAndParty"...queryList()

[MSG]The line exceeds 150 characters. The line is 194 characters.

[SRC]if ("RF_SCRUM_MEETINGS".equals(taskPlanMap.custRequestTypeId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to RF_SCRUM_MEETINGS.equals(taskPlanMap.custRequestTypeId) method can be rewritten as (RF_SCRUM_MEETINGS == (taskPlanMap.custRequestTypeId))

[SRC]if (!"SCAS_COMPLETED".equals(workEffPartyAssignedMap.statusId)) {

[MSG]Violation in class org.apache.ofbiz.scrum.None. Explicit call to SCAS_COMPLETED.equals(workEffPartyAssignedMap.statusId) method can be rewritten as (SCAS_COMPLETED == (workEffPartyAssignedMap.statusId))

[SRC]showOld = "true".equals(parameters.SHOW_OLD)

[MSG]Violation in class org.apache.ofbiz.ecommerce.customer.None. Explicit call to true.equals(parameters.SHOW_OLD) method can be rewritten as (true == (parameters.SHOW_OLD))

[SRC]result = runService('getOrderedSummaryInformation', [par.. userLogin])

[MSG]The line exceeds 150 characters. The line is 226 characters.

[SRC]if (countryGeo) it.countryGeoName = countryGeo.getString("geoName")

[MSG]The if statement lacks braces

[SRC]if (stateProvinceGeo) it.stateProvinceGeoName = statePro..g("geoName")

[MSG]The if statement lacks braces

[SRC]def inputFields = [:]

[MSG]def for declaration should not be used

[SRC]def inputFields = [:]

[MSG]The type is not specified for variable "inputFields"

[SRC]def custRequestAndItems = []

[MSG]def for declaration should not be used

[SRC]def custRequestAndItems = []

[MSG]The type is not specified for variable "custRequestAndItems"

[SRC]if(parameters.statusId == null){

[MSG]The closing brace for the block in class org.apache.ofbiz.scrum.None is not followed by a space or whitespace

[SRC]if(parameters.statusId == null){

[MSG]The if keyword within class org.apache.ofbiz.scrum.None is not followed by a single space

[SRC]if(parameters.statusId == null){

[MSG]The opening brace for the block in class org.apache.ofbiz.scrum.None is not preceded by a space or whitespace

[SRC]parameters.statusId = ""

[MSG]The String '' can be wrapped in single quotes instead of double quotes

[SRC]}else if("Any".equals(parameters.statusId)){

[MSG]The if keyword within class org.apache.ofbiz.scrum.None is not followed by a single space

[SRC]}else if("Any".equals(parameters.statusId)){

[MSG]The opening brace for the block in class org.apache.ofbiz.scrum.None is not preceded by a space or whitespace

[SRC]}else if("Any".equals(parameters.statusId)){

[MSG]The String 'Any' can be wrapped in single quotes instead of double quotes

[SRC]parameters.statusId = ""

[MSG]The String '' can be wrapped in single quotes instead of double quotes

[SRC]inputFields.custRequestTypeId = "RF_PROD_BACKLOG"

[MSG]The String 'RF_PROD_BACKLOG' can be wrapped in single quotes instead of double quotes

[SRC]def performFindResults = runService('performFind', ["ent..quenceNum"])

[MSG]def for declaration should not be used

[SRC]def performFindResults = runService('performFind', ["ent..quenceNum"])

[MSG]The type is not specified for variable "performFindResults"

[SRC]def performFindResults = runService('performFind', ["ent..quenceNum"])

[MSG]The String 'entityName' can be wrapped in single quotes instead of double quotes

[SRC]def performFindResults = runService('performFind', ["ent..quenceNum"])

[MSG]The String 'CustRequestAndCustRequestItem' can be wrapped in single quotes instead of double quotes

[SRC]def performFindResults = runService('performFind', ["ent..quenceNum"])

[MSG]The String 'inputFields' can be wrapped in single quotes instead of double quotes

[SRC]def performFindResults = runService('performFind', ["ent..quenceNum"])

[MSG]The String 'orderBy' can be wrapped in single quotes instead of double quotes

[SRC]def performFindResults = runService('performFind', ["ent..quenceNum"])

[MSG]The String 'custSequenceNum' can be wrapped in single quotes instead of double quotes

[SRC]logError(e, "Failure in " + module)

[MSG]The String 'Failure in ' can be wrapped in single quotes instead of double quotes

[SRC]logError(e)

[MSG]The statement on line 47 in class org.apache.ofbiz.scrum.None is at the incorrect indent level: Expected column 13 but was 17

[SRC]def countSequence = 1

[MSG]def for declaration should not be used

[SRC]def countSequence = 1

[MSG]The type is not specified for variable "countSequence"

[SRC]def custRequestAndCustRequestItems = []

[MSG]def for declaration should not be used

[SRC]def custRequestAndCustRequestItems = []

[MSG]The type is not specified for variable "custRequestAndCustRequestItems"

[SRC]custRequestAndItems.each() { custRequestAndItem ->

[MSG]Violation in class org.apache.ofbiz.scrum.None. Parentheses in the 'each' method call are unnecessary and can be removed.

[SRC]def tempCustRequestAndItem = [:]

[MSG]def for declaration should not be used

[SRC]def tempCustRequestAndItem = [:]

[MSG]The type is not specified for variable "tempCustRequestAndItem"

[SRC]custWorkEffortList = from("CustRequestWorkEffort").where...queryList()

[MSG]The String 'CustRequestWorkEffort' can be wrapped in single quotes instead of double quotes

[SRC]custWorkEffortList = from("CustRequestWorkEffort").where...queryList()

[MSG]The String 'custRequestId' can be wrapped in single quotes instead of double quotes

[SRC]custWorkEffortList.each() { custWorkEffortMap ->

[MSG]Violation in class org.apache.ofbiz.scrum.None. Parentheses in the 'each' method call are unnecessary and can be removed.

[SRC]result = runService('getScrumActualHour', ["taskId" : cu.. userLogin])

[MSG]The map entry partyId:null within class org.apache.ofbiz.scrum.None is not preceded by a space or whitespace

[SRC]result = runService('getScrumActualHour', ["taskId" : cu.. userLogin])

[MSG]The colon for the literal Map entry for key [taskId] within class org.apache.ofbiz.scrum.None is not preceded by a match for regular expression [\S]

[SRC]result = runService('getScrumActualHour', ["taskId" : cu.. userLogin])

[MSG]The colon for the literal Map entry for key [partyId] within class org.apache.ofbiz.scrum.None is not preceded by a match for regular expression [\S]

[SRC]result = runService('getScrumActualHour', ["taskId" : cu.. userLogin])

[MSG]The colon for the literal Map entry for key [userLogin] within class org.apache.ofbiz.scrum.None is not preceded by a match for regular expression [\S]

[SRC]result = runService('getScrumActualHour', ["taskId" : cu.. userLogin])

[MSG]The String 'taskId' can be wrapped in single quotes instead of double quotes

[SRC]result = runService('getScrumActualHour', ["taskId" : cu.. userLogin])

[MSG]The String 'partyId' can be wrapped in single quotes instead of double quotes

[SRC]result = runService('getScrumActualHour', ["taskId" : cu.. userLogin])

[MSG]The String 'userLogin' can be wrapped in single quotes instead of double quotes

[SRC]if(actualHours) {

[MSG]The if keyword within class org.apache.ofbiz.scrum.None is not followed by a single space

[SRC]if ("N".equals(parameters.sequence)) { // re-order category list item

[MSG]The String 'N' can be wrapped in single quotes instead of double quotes

[SRC]custRequestAndCustRequestItems = UtilMisc.sortMaps(custR..RequestId"])

[MSG]The String 'parentCustRequestId' can be wrapped in single quotes instead of double quotes

[SRC]if("".equals(parameters.statusId)){

[MSG]The if keyword within class org.apache.ofbiz.scrum.None is not followed by a single space

[SRC]if("".equals(parameters.statusId)){

[MSG]The opening brace for the block in class org.apache.ofbiz.scrum.None is not preceded by a space or whitespace

[SRC]if("".equals(parameters.statusId)){

[MSG]The String '' can be wrapped in single quotes instead of double quotes

[SRC]parameters.statusId = "Any"

[MSG]The String 'Any' can be wrapped in single quotes instead of double quotes

[SRC]conditionList.add(EntityCondition.makeCondition("custReq..N_BACKLOG"))

[MSG]The String 'custRequestTypeId' can be wrapped in single quotes instead of double quotes

[SRC]conditionList.add(EntityCondition.makeCondition("custReq..N_BACKLOG"))

[MSG]The String 'RF_UNPLAN_BACKLOG' can be wrapped in single quotes instead of double quotes

[SRC]conditionList.add(EntityCondition.makeCondition("product...productId))

[MSG]The String 'productId' can be wrapped in single quotes instead of double quotes

[SRC]orConditionList.add(EntityCondition.makeCondition("statu.._ACCEPTED"))

[MSG]The String 'statusId' can be wrapped in single quotes instead of double quotes

[SRC]orConditionList.add(EntityCondition.makeCondition("statu.._ACCEPTED"))

[MSG]The String 'CRQ_ACCEPTED' can be wrapped in single quotes instead of double quotes

[SRC]orConditionList.add(EntityCondition.makeCondition("statu.._REOPENED"))

[MSG]The String 'statusId' can be wrapped in single quotes instead of double quotes

[SRC]orConditionList.add(EntityCondition.makeCondition("statu.._REOPENED"))

[MSG]The String 'CRQ_REOPENED' can be wrapped in single quotes instead of double quotes

[SRC]unplannedList = select("custRequestId", "custSequenceNum...queryList()

[MSG]The String 'custRequestId' can be wrapped in single quotes instead of double quotes

[SRC]unplannedList = select("custRequestId", "custSequenceNum...queryList()

[MSG]The String 'custSequenceNum' can be wrapped in single quotes instead of double quotes

[SRC]unplannedList = select("custRequestId", "custSequenceNum...queryList()

[MSG]The String 'statusId' can be wrapped in single quotes instead of double quotes

[SRC]unplannedList = select("custRequestId", "custSequenceNum...queryList()

[MSG]The String 'description' can be wrapped in single quotes instead of double quotes

[SRC]unplannedList = select("custRequestId", "custSequenceNum...queryList()

[MSG]The String 'custEstimatedMilliSeconds' can be wrapped in single quotes instead of double quotes

[SRC]unplannedList = select("custRequestId", "custSequenceNum...queryList()

[MSG]The String 'custRequestName' can be wrapped in single quotes instead of double quotes

[SRC]unplannedList = select("custRequestId", "custSequenceNum...queryList()

[MSG]The String 'parentCustRequestId' can be wrapped in single quotes instead of double quotes

[SRC]unplannedList = select("custRequestId", "custSequenceNum...queryList()

[MSG]The String 'CustRequestAndCustRequestItem' can be wrapped in single quotes instead of double quotes

[SRC]unplannedList = select("custRequestId", "custSequenceNum...queryList()

[MSG]The String 'custSequenceNum' can be wrapped in single quotes instead of double quotes

[SRC]def countSequenceUnplanned = 1

[MSG]def for declaration should not be used

[SRC]def countSequenceUnplanned = 1

[MSG]The type is not specified for variable "countSequenceUnplanned"

[SRC]def unplanBacklogItems = []

[MSG]def for declaration should not be used

[SRC]def unplanBacklogItems = []

[MSG]The type is not specified for variable "unplanBacklogItems"

[SRC]unplannedList.each() { unplannedItem ->

[MSG]Violation in class org.apache.ofbiz.scrum.None. Parentheses in the 'each' method call are unnecessary and can be removed.

[SRC]def tempUnplanned = [:]

[MSG]def for declaration should not be used

[SRC]def tempUnplanned = [:]

[MSG]The type is not specified for variable "tempUnplanned"

[SRC]unplanCustWorkEffortList = from("CustRequestWorkEffort")...queryList()

[MSG]The String 'CustRequestWorkEffort' can be wrapped in single quotes instead of double quotes

[SRC]unplanCustWorkEffortList = from("CustRequestWorkEffort")...queryList()

[MSG]The String 'custRequestId' can be wrapped in single quotes instead of double quotes

[SRC]unplanCustWorkEffortList.each() { custWorkEffortMap ->

[MSG]Violation in class org.apache.ofbiz.scrum.None. Parentheses in the 'each' method call are unnecessary and can be removed.

[SRC]result = runService('getScrumActualHour', ["taskId" : cu.. userLogin])

[MSG]The map entry partyId:null within class org.apache.ofbiz.scrum.None is not preceded by a space or whitespace

[SRC]result = runService('getScrumActualHour', ["taskId" : cu.. userLogin])

[MSG]The colon for the literal Map entry for key [taskId] within class org.apache.ofbiz.scrum.None is not preceded by a match for regular expression [\S]

[SRC]result = runService('getScrumActualHour', ["taskId" : cu.. userLogin])

[MSG]The colon for the literal Map entry for key [partyId] within class org.apache.ofbiz.scrum.None is not preceded by a match for regular expression [\S]

[SRC]result = runService('getScrumActualHour', ["taskId" : cu.. userLogin])

[MSG]The colon for the literal Map entry for key [userLogin] within class org.apache.ofbiz.scrum.None is not preceded by a match for regular expression [\S]

[SRC]result = runService('getScrumActualHour', ["taskId" : cu.. userLogin])

[MSG]The String 'taskId' can be wrapped in single quotes instead of double quotes

[SRC]result = runService('getScrumActualHour', ["taskId" : cu.. userLogin])

[MSG]The String 'partyId' can be wrapped in single quotes instead of double quotes

[SRC]result = runService('getScrumActualHour', ["taskId" : cu.. userLogin])

[MSG]The String 'userLogin' can be wrapped in single quotes instead of double quotes

[SRC]if(actualHours) {

[MSG]The if keyword within class org.apache.ofbiz.scrum.None is not followed by a single space

[SRC]if ("N".equals(parameters.UnplannedSequence)) { // re-or..ry list item

[MSG]The String 'N' can be wrapped in single quotes instead of double quotes

[SRC]unplanBacklogItems = UtilMisc.sortMaps(unplanBacklogItem..RequestId"])

[MSG]The String 'parentCustRequestId' can be wrapped in single quotes instead of double quotes

[SRC]projectAndTaskList = from("ProjectSprintBacklogAndTask")...queryList()

[MSG]The parameter taskCurrentStatusId in the call to method where within class org.apache.ofbiz.scrum.None is not preceded by a space or whitespace

[SRC]projectAndTaskList = from("ProjectSprintBacklogAndTask")...queryList()

[MSG]The String 'ProjectSprintBacklogAndTask' can be wrapped in single quotes instead of double quotes

[SRC]projectAndTaskList = from("ProjectSprintBacklogAndTask")...queryList()

[MSG]The String 'sprintTypeId' can be wrapped in single quotes instead of double quotes

[SRC]projectAndTaskList = from("ProjectSprintBacklogAndTask")...queryList()

[MSG]The String 'SCRUM_SPRINT' can be wrapped in single quotes instead of double quotes

[SRC]projectAndTaskList = from("ProjectSprintBacklogAndTask")...queryList()

[MSG]The String 'taskCurrentStatusId' can be wrapped in single quotes instead of double quotes

[SRC]projectAndTaskList = from("ProjectSprintBacklogAndTask")...queryList()

[MSG]The String 'STS_CREATED' can be wrapped in single quotes instead of double quotes

[SRC]projectAndTaskList = from("ProjectSprintBacklogAndTask")...queryList()

[MSG]The String 'taskId DESC' can be wrapped in single quotes instead of double quotes

[SRC]userLoginId = userLogin.partyId

[MSG]The statement on line 26 in class org.apache.ofbiz.scrum.None is at the incorrect indent level: Depending on your chaining style, expected one of [5, 9, 13] or one of [23, 27, 31] columns, but was 1

[SRC]partyAssignmentProjectList = from("WorkEffortPartyAssign...queryList()

[MSG]The String 'WorkEffortPartyAssignment' can be wrapped in single quotes instead of double quotes

[SRC]partyAssignmentProjectList = from("WorkEffortPartyAssign...queryList()

[MSG]The String 'workEffortId' can be wrapped in single quotes instead of double quotes

[SRC]partyAssignmentProjectList = from("WorkEffortPartyAssign...queryList()

[MSG]The String 'partyId' can be wrapped in single quotes instead of double quotes

[SRC]partyAssignmentSprintList = from("WorkEffortPartyAssignm...queryList()

[MSG]The String 'WorkEffortPartyAssignment' can be wrapped in single quotes instead of double quotes

[SRC]partyAssignmentSprintList = from("WorkEffortPartyAssignm...queryList()

[MSG]The String 'workEffortId' can be wrapped in single quotes instead of double quotes

[SRC]partyAssignmentSprintList = from("WorkEffortPartyAssignm...queryList()

[MSG]The String 'partyId' can be wrapped in single quotes instead of double quotes

[SRC]partyAssignmentTaskList = from("WorkEffortPartyAssignmen...queryList()

[MSG]The String 'WorkEffortPartyAssignment' can be wrapped in single quotes instead of double quotes

[SRC]partyAssignmentTaskList = from("WorkEffortPartyAssignmen...queryList()

[MSG]The String 'workEffortId' can be wrapped in single quotes instead of double quotes

[SRC]if (!partyAssignmentTaskMap) {

[MSG]Testing the negative condition first can make an if statement confusing

[SRC]if ("RF_SCRUM_MEETINGS".equals(custRequestTypeId) && "CR..StatusId)) {

[MSG]The String 'RF_SCRUM_MEETINGS' can be wrapped in single quotes instead of double quotes

[SRC]if ("RF_SCRUM_MEETINGS".equals(custRequestTypeId) && "CR..StatusId)) {

[MSG]The String 'CRQ_REVIEWED' can be wrapped in single quotes instead of double quotes

[SRC]import org.apache.ofbiz.base.util.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.product.catalog.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.product.feature.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.product.product.*

[MSG]Wildcard (star) import

[SRC]if (!"AND".equals(searchOperator) && !"OR".equals(searchOperator)) {

[MSG]The String 'AND' can be wrapped in single quotes instead of double quotes

[SRC]if (!"AND".equals(searchOperator) && !"OR".equals(searchOperator)) {

[MSG]The String 'OR' can be wrapped in single quotes instead of double quotes

[SRC]searchOperator = "OR"

[MSG]The statement on line 31 in class org.apache.ofbiz.ecommerce.content.None is at the incorrect indent level: Expected column 5 but was 3

[SRC]searchOperator = "OR"

[MSG]The String 'OR' can be wrapped in single quotes instead of double quotes

[SRC]searchOperator = request.getParameter("SEARCH_OPERATOR")

[MSG]The String 'SEARCH_OPERATOR' can be wrapped in single quotes instead of double quotes

[SRC]if (!"AND".equals(searchOperator) && !"OR".equals(searchOperator)) {

[MSG]The String 'AND' can be wrapped in single quotes instead of double quotes

[SRC]if (!"AND".equals(searchOperator) && !"OR".equals(searchOperator)) {

[MSG]The String 'OR' can be wrapped in single quotes instead of double quotes

[SRC]searchOperator = "OR"

[MSG]The statement on line 29 in class org.apache.ofbiz.lucene.content.None is at the incorrect indent level: Expected column 5 but was 3

[SRC]searchOperator = "OR"

[MSG]The String 'OR' can be wrapped in single quotes instead of double quotes

[SRC]import org.apache.ofbiz.product.category.*

[MSG]Wildcard (star) import

[SRC]productCategoryId=parameters.category_id

[MSG]The operator "=" within class org.apache.ofbiz.ecommerce.catalog.None is not preceded by a space or whitespace

[SRC]productCategoryId=parameters.category_id

[MSG]The operator "=" within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a space or whitespace

[SRC]if(parentCategoryStr) {

[MSG]The if keyword within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a single space

[SRC]for(path in pathList) {

[MSG]The for keyword within class org.apache.ofbiz.ecommerce.catalog.None is not followed by a single space

[SRC]category = from("ProductCategory").where("productCategor..).queryOne()

[MSG]The String 'ProductCategory' can be wrapped in single quotes instead of double quotes

[SRC]category = from("ProductCategory").where("productCategor..).queryOne()

[MSG]The String 'productCategoryId' can be wrapped in single quotes instead of double quotes

[SRC]cateMap.title = categoryContentWrapper.get("DESCRIPTION", "html")

[MSG]The String 'DESCRIPTION' can be wrapped in single quotes instead of double quotes

[SRC]cateMap.title = categoryContentWrapper.get("DESCRIPTION", "html")

[MSG]The String 'html' can be wrapped in single quotes instead of double quotes

[SRC]currentCategory = from("ProductCategory").where("product..).queryOne()

[MSG]The String 'ProductCategory' can be wrapped in single quotes instead of double quotes

[SRC]currentCategory = from("ProductCategory").where("product..).queryOne()

[MSG]The String 'productCategoryId' can be wrapped in single quotes instead of double quotes

[SRC]context.currentCategoryName = currentCategoryContentWrap..ME", "html")

[MSG]The String 'CATEGORY_NAME' can be wrapped in single quotes instead of double quotes

[SRC]context.currentCategoryName = currentCategoryContentWrap..ME", "html")

[MSG]The String 'html' can be wrapped in single quotes instead of double quotes

[SRC]context.currentCategoryDescription = currentCategoryCont..ON", "html")

[MSG]The String 'DESCRIPTION' can be wrapped in single quotes instead of double quotes

[SRC]context.currentCategoryDescription = currentCategoryCont..ON", "html")

[MSG]The String 'html' can be wrapped in single quotes instead of double quotes

[SRC]import org.apache.ofbiz.order.shoppingcart.*

[MSG]Wildcard (star) import

[SRC]cart = session.getAttribute("shoppingCart")

[MSG]The String 'shoppingCart' can be wrapped in single quotes instead of double quotes

[SRC]context.shipAddr = "Y"

[MSG]The String 'Y' can be wrapped in single quotes instead of double quotes

[SRC]trailClassMap.shipAddr = "submenutextright"

[MSG]The String 'submenutextright' can be wrapped in single quotes instead of double quotes

[SRC]context.shipOptions = "Y"

[MSG]The String 'Y' can be wrapped in single quotes instead of double quotes

[SRC]trailClassMap.shipAddr = "submenutext"

[MSG]The String 'submenutext' can be wrapped in single quotes instead of double quotes

[SRC]trailClassMap.shipOptions = "submenutextright"

[MSG]The String 'submenutextright' can be wrapped in single quotes instead of double quotes

[SRC]context.billing = "Y"

[MSG]The String 'Y' can be wrapped in single quotes instead of double quotes

[SRC]trailClassMap.shipOptions = "submenutext"

[MSG]The String 'submenutext' can be wrapped in single quotes instead of double quotes

[SRC]trailClassMap.paymentType = "submenutextright"

[MSG]The String 'submenutextright' can be wrapped in single quotes instead of double quotes

[SRC]expires_in : expireTimeString,

[MSG]The colon for the literal Map entry for key [expires_in] within class org.apache.ofbiz.example.None is not preceded by a match for regular expression [\S]

[SRC]token_type : 'Bearer',]

[MSG]The colon for the literal Map entry for key [token_type] within class org.apache.ofbiz.example.None is not preceded by a match for regular expression [\S]

[MSG]File BacklogNotifications.groovy has consecutive blank lines

[SRC]def module = "BacklogNotifications.groovy"

[MSG]def for declaration should not be used

[SRC]def module = "BacklogNotifications.groovy"

[MSG]The type is not specified for variable "module"

[SRC]def module = "BacklogNotifications.groovy"

[MSG]The String 'BacklogNotifications.groovy' can be wrapped in single quotes instead of double quotes

[SRC]custRequest = from("CustRequest").where("custRequestId",..).queryOne()

[MSG]The String 'CustRequest' can be wrapped in single quotes instead of double quotes

[SRC]custRequest = from("CustRequest").where("custRequestId",..).queryOne()

[MSG]The String 'custRequestId' can be wrapped in single quotes instead of double quotes

[SRC]person = from("PartyNameView").where("partyId", partyIdTo).queryOne()

[MSG]The String 'PartyNameView' can be wrapped in single quotes instead of double quotes

[SRC]person = from("PartyNameView").where("partyId", partyIdTo).queryOne()

[MSG]The String 'partyId' can be wrapped in single quotes instead of double quotes

[SRC]backlogList = select("productId", "workEffortId", "custR...queryList()

[MSG]The String 'productId' can be wrapped in single quotes instead of double quotes

[SRC]backlogList = select("productId", "workEffortId", "custR...queryList()

[MSG]The String 'workEffortId' can be wrapped in single quotes instead of double quotes

[SRC]backlogList = select("productId", "workEffortId", "custR...queryList()

[MSG]The String 'custRequestId' can be wrapped in single quotes instead of double quotes

[SRC]backlogList = select("productId", "workEffortId", "custR...queryList()

[MSG]The String 'ProductBacklog' can be wrapped in single quotes instead of double quotes

[SRC]backlogList = select("productId", "workEffortId", "custR...queryList()

[MSG]The String 'workEffortTypeId' can be wrapped in single quotes instead of double quotes

[SRC]backlogList = select("productId", "workEffortId", "custR...queryList()

[MSG]The String 'SCRUM_SPRINT' can be wrapped in single quotes instead of double quotes

[SRC]backlogList = select("productId", "workEffortId", "custR...queryList()

[MSG]The String 'custRequestId' can be wrapped in single quotes instead of double quotes

[SRC]product = from("Product").where("productId", backlogList..).queryOne()

[MSG]The String 'Product' can be wrapped in single quotes instead of double quotes

[SRC]product = from("Product").where("productId", backlogList..).queryOne()

[MSG]The String 'productId' can be wrapped in single quotes instead of double quotes

[SRC]sprint = from("WorkEffort").where("workEffortId", backlo..).queryOne()

[MSG]The String 'WorkEffort' can be wrapped in single quotes instead of double quotes

[SRC]sprint = from("WorkEffort").where("workEffortId", backlo..).queryOne()

[MSG]The String 'workEffortId' can be wrapped in single quotes instead of double quotes

[SRC]backlogList = select("productId", "workEffortId", "custR...queryList()

[MSG]The String 'productId' can be wrapped in single quotes instead of double quotes

[SRC]backlogList = select("productId", "workEffortId", "custR...queryList()

[MSG]The String 'workEffortId' can be wrapped in single quotes instead of double quotes

[SRC]backlogList = select("productId", "workEffortId", "custR...queryList()

[MSG]The String 'custRequestId' can be wrapped in single quotes instead of double quotes

[SRC]backlogList = select("productId", "workEffortId", "custR...queryList()

[MSG]The String 'ProductBacklog' can be wrapped in single quotes instead of double quotes

[SRC]backlogList = select("productId", "workEffortId", "custR...queryList()

[MSG]The String 'custRequestId' can be wrapped in single quotes instead of double quotes

[SRC]product = from("Product").where("productId", backlogList..).queryOne()

[MSG]The String 'Product' can be wrapped in single quotes instead of double quotes

[SRC]product = from("Product").where("productId", backlogList..).queryOne()

[MSG]The String 'productId' can be wrapped in single quotes instead of double quotes

[SRC]if ("CRQ_ACCEPTED".equals(custRequest.statusId)) {

[MSG]The String 'CRQ_ACCEPTED' can be wrapped in single quotes instead of double quotes

[SRC]custStatusList = custRequest.getRelated("CustRequestStat..Id"], false)

[MSG]The String 'CustRequestStatus' can be wrapped in single quotes instead of double quotes

[SRC]custStatusList = custRequest.getRelated("CustRequestStat..Id"], false)

[MSG]The String '-custRequestStatusId' can be wrapped in single quotes instead of double quotes

[SRC]if (custStatusList.size() > 2 && "CRQ_REVIEWED".equals(c..statusId)) {

[MSG]The String 'CRQ_REVIEWED' can be wrapped in single quotes instead of double quotes

[SRC]import org.apache.ofbiz.base.util.UtilValidate

[MSG]The [org.apache.ofbiz.base.util.UtilValidate] import is never referenced

[SRC]import org.apache.ofbiz.base.util.UtilMisc

[MSG]The [org.apache.ofbiz.base.util.UtilMisc] import is never referenced

[SRC]import org.apache.ofbiz.product.catalog.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.product.category.*

[MSG]Wildcard (star) import

[SRC]prodCatalogCategoryList = CatalogWorker.getProdCatalogCa.._BEST_SELL")

[MSG]The String 'PCCT_BEST_SELL' can be wrapped in single quotes instead of double quotes

[SRC]productCategoryId = prodCatalogCategory.getString("productCategoryId")

[MSG]The String 'productCategoryId' can be wrapped in single quotes instead of double quotes

[SRC]childCategoryList = CategoryWorker.getRelatedCategoriesR..oryId, true)

[MSG]The String 'childCategoryList' can be wrapped in single quotes instead of double quotes

[SRC]import org.apache.ofbiz.entity.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.entity.util.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.base.util.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.accounting.payment.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.order.shoppingcart.*

[MSG]Wildcard (star) import

[SRC]import org.apache.ofbiz.party.contact.*

[MSG]Wildcard (star) import

[SRC]cart = session.getAttribute("shoppingCart")

[MSG]The String 'shoppingCart' can be wrapped in single quotes instead of double quotes

[SRC]payType = "GC"

[MSG]The String 'GC' can be wrapped in single quotes instead of double quotes

[SRC]request.removeAttribute("_EVENT_MESSAGE_")

[MSG]The String '_EVENT_MESSAGE_' can be wrapped in single quotes instead of double quotes

[SRC]if (partyId && !"_NA_".equals(partyId)) {

[MSG]The String '_NA_' can be wrapped in single quotes instead of double quotes

[SRC]party = from("Party").where("partyId", partyId).queryOne()

[MSG]The String 'Party' can be wrapped in single quotes instead of double quotes

[SRC]party = from("Party").where("partyId", partyId).queryOne()

[MSG]The String 'partyId' can be wrapped in single quotes instead of double quotes

[SRC]person = party.getRelatedOne("Person", false)

[MSG]The String 'Person' can be wrapped in single quotes instead of double quotes

[SRC]context.paymentMethodList = EntityUtil.filterByDate(part..ull, false))

[MSG]The String 'PaymentMethod' can be wrapped in single quotes instead of double quotes

[SRC]postalAddress = from("PostalAddress").where("contactMech..).queryOne()

[MSG]The String 'PostalAddress' can be wrapped in single quotes instead of double quotes

[SRC]postalAddress = from("PostalAddress").where("contactMech..).queryOne()

[MSG]The String 'contactMechId' can be wrapped in single quotes instead of double quotes

[SRC]context.useEntityFields = "Y"

[MSG]The String 'Y' can be wrapped in single quotes instead of double quotes

[SRC]partyContactMech = from("PartyContactMech").where("party..queryFirst()

[MSG]The String 'PartyContactMech' can be wrapped in single quotes instead of double quotes

[SRC]partyContactMech = from("PartyContactMech").where("party..queryFirst()

[MSG]The String 'partyId' can be wrapped in single quotes instead of double quotes

[SRC]partyContactMech = from("PartyContactMech").where("party..queryFirst()

[MSG]The String 'contactMechId' can be wrapped in single quotes instead of double quotes

[SRC]partyContactMech = from("PartyContactMech").where("party..queryFirst()

[MSG]The String '-fromDate' can be wrapped in single quotes instead of double quotes

[SRC]paymentMethod = from("PaymentMethod").where("paymentMeth..).queryOne()

[MSG]The String 'PaymentMethod' can be wrapped in single quotes instead of double quotes

[SRC]paymentMethod = from("PaymentMethod").where("paymentMeth..).queryOne()

[MSG]The String 'paymentMethodId' can be wrapped in single quotes instead of double quotes

[SRC]if ("CREDIT_CARD".equals(paymentMethod.paymentMethodTypeId)) {

[MSG]The String 'CREDIT_CARD' can be wrapped in single quotes instead of double quotes

[SRC]account = paymentMethod.getRelatedOne("CreditCard", false)

[MSG]The String 'CreditCard' can be wrapped in single quotes instead of double quotes