44 Collaborator |
Brandon Williams , Aleksey Yeschenko , Mick Semb Wever , Marcus Eriksson , Benedict Elliott Smith , Sam Tunnicliffe , Yuki Morishita , Benjamin Lerer , Štefan Miklošovič , Alex Petrov , Berenguer Blasi , Ekaterina Dimitrova , David Capwell , Josh McKenzie , Andrés de la Peña , Paulo Motta , Caleb Rackliffe , Blake Eggleston , Yifan Cai , Dinesh Joshi , Francisco Guerrero , Jeff Jirsa , Zhao Yang , Jordan West , Doug Rohrer , Maxim Muzafarov , Andy Tolbert , Abe Ratnofsky , Jyothsna Konisa , Bernardo Botella , Maulin Vasavada , Alexander Dejanovski , Matt Fleming , Daniel Jatnieks , Dan Jatnieks , Stephen Mallette , Natnael Adere , Nachiket Patil , jkonisa , Mohammad Aburadeh , Francisco Guerrero Hernandez , Marcus Eriksson, Jon Meredith , Kamalesh Palanisamy , Benedict Elliott Smith |
58 Patch |
77 Review |
9ebe0aa08ae616f49983e2800eee190921f2edf3,
9157d98e4cc5c00d74cef6128c16659ff43f3585,
b9586501a6b6cdfe465302448018785652c9b966,
bde4fa0013eb8cec5b1d88b21ca4463bc07272bb,
914484dfd86d5145118032a61c04bc3cdb632fb3,
ae995eb3d3cc1c98f61db0d071522b6f09443927,
602ffcbf3e4ead4732fdf46d506165f63d80a9a4,
1a5302608f3506c4940fa170976336081ddd4a88,
09c1e67598d7a0dc7da7bebee358fbc96d84680a,
cd9bed0aeadd94136a8a6c6ed284cc4684b0666c,
853ae8c84049be875921a40c9d5924724cc72792,
3a4fff38b5d89650d6ac96df22d850a0935d7730,
4e0aad3319f90eaf7a5e5aed1fd3c5bb7a949fbd,
22ec7eee7f340e8333055b2b10646cfe00cb6a84,
f65f1237800b5e884309bbb1bb69d1302466ee80,
6748b8b7ead6fff7820045ebbfe23f6c050f2efe,
7bde2c23abacf60d156de7c444f136dcfe9fe276,
5e39c54678b0d70145b5c699593eb9ce7fa7706a,
008bf8607c55926d0aadb4602a8a854d396c7657,
ba0555e965699d64099870c0288b31d1a15b2698,
2fdbda6ac98f161513f80e7bbab4ea8ca1c8528a,
ce6a65cb294af3b68ab2f4bba7945b097de42576,
fa7185ef02c313ff322fcc50d2de03186b9f96a7,
94580a272e77439e4150926a1bd1e723a36236e6,
647ec92db17e1b1a3677e7880849a29c0c30adde,
431c692b884395b16beadac1d10f7e674b3e7ed5,
9ff28fc717e7926b5cf7c8acc85a35e0cfb43595,
b1a8a56c563b85ab9a34d3bbf9c16278dd441157,
071ecb52465837c90520423c2bc80eb886936953,
4d4e1e88d095e10d53b59bf004a59709c3cee186,
2fba5c80ce7bf71d04c62043ffa1088b9e832d83,
6fa5300682fbfcbaaae9d4593a015c18ab34df1f,
838bd8cae6d125cfb055dbf6bfc5a2d4e13cdfcb,
2d80e9904b46474b3a7cc135690c27511a234713,
b74d7370cc89fa899f47f50c825ddaed2dd05c3f,
1b04702f351861e6fef8cf64fd26f65ec90e4c70,
7637acc3d762047f2a478855eb4d239b4f314cd8,
919a8964a83511d96766c3e53ba603e77bca626c,
f293376aa8dd315a208ef2f03bdcb7a84dcc675c,
db5832120f0fe9ad799ca0b5b16bbcf6f7404580,
a062ff5f9f0d3221deaaaaf8fccbcd21e933e7cd,
c9b41c1f8ad03719918c4d3c29719056ae6b3995,
c230ec9ed07b9077ce8422bce8db4e94d5b644cb,
678ca3fc29c38b64a110dcf40693aa7840b0585c,
09f83fa023cbe57e90287e7d93560f1cb0edb4c4,
f9ddaf1841147fc284e802739ca42403aa2816ae,
0a860b9b3e66be443b2236454c0f8c97c936a6dc,
c4db3f89a9a07c45c78da9b5b3f802a6f8b51531,
02c6d6540c6ab108b763a639146e74e9f8d0dd40,
311891f35e538f4a8be0309f6d7045fef59dee71,
860de83a02f3b7711e842a58a073802b9920a1a1,
02cc5df0ed64ba1e746fdb2662f4442fa308abf4,
58a5ce14ba80a0a4eeef0f6b18e58d63113e1159,
8dcaa12baa97ce870f23ff9045f968f2fa28b2cc,
d8164c643395e3b6579a2fe6ce6ff0423df2f520,
e07d53aaec94a498028d988f7d2c7ae7e6b620d0,
36e25140a013843faf91be938c3301495957ed1d,
7ddfe52d51639817c6c5be86c0c8e317e33620eb |
b6eb5890da38642fc7af7d39c83f7ec01f33d78f,
6a640b0c4e6e3aecca08c749250e2dfec18063ab,
bfcb21fbebfef14fbfe626bfd39d66f5e5c51018,
8bfe0e5878c64ed25591aae50643187bc8ab7241,
6ffa43f68b8d10ca84d4a00bf81269527b4e14df,
b47bee42d3b15020fbae72b173e873fa57c8e0c8,
c6d7d070c59d81db8949683d3e5670b909efb48c,
4f232324ba030ff640a790b4029d9f722e96872b,
1c7e7db2d062e54c38a05e073caa40889188657c,
4a2a585ec012f2bbeea4d9c3aebbab04cc08a370,
f078c02cb58bddd735490b07548f7352f0eb09aa,
43ec1843918aba9e81d3c2dc1433a1ef4740a51f,
853ae8c84049be875921a40c9d5924724cc72792,
4444721b6de555352bf0ac3ef7e36f94dc832f41,
40f9ca60f103783aa481bc9a91b92fd55b4ea625,
0a0e06847bf10aa88a3a30c239c507a64f949d74,
4a555f47ee943ce9fd70862cc8127d707e3507a2,
5be1038c5d38af32d3cbb0545d867f21304f3a46,
36e16ee3c911c710129fcf3a69595038c3dbd385,
b2660bcf78ccf08a3a0ae39a8c9ffb397efef9ff,
ca75ffe4d09a3e7b26a56345c0bdacaa284eaab7,
d6aee7e08c658db9d394a6b7e3e27791b4d6854f,
0e855c4b7c157b7ba63bb7377bc441260d76556f,
3e0b94565acc64e903d73af3a14b23c875abc5b3,
5e39c54678b0d70145b5c699593eb9ce7fa7706a,
fe28f482db0e1bc81936a62d0564e9657f428d2a,
7119cf8be1c32fa6ac015456965ae27a17cd828c,
7da28ef37848d14c0ff4597dfc6e116bd9febce6,
557b8e9982ad0964191abde810ef5c77a536f70a,
6247c9d966d7e3886fef0c7486013578407b37e4,
a00d8fd5ba9d73a377d1a11e6f540c56d66e9c8f,
fb8bf30c6d1b6f893a77a74b9e8b4223e5497dd4,
ed3901823a5fe9f8838d8b592a1b7703b12e810b,
ce515a3d77c2042575827e8bdb1da639fc957491,
559b17f71d3207158d34b1dd2414a531e362af20,
74bb6d8496d5a2a5b89a843ba764fe37b65ee331,
57ab3afcf16970047d3df4656241cf0705e94bee,
3d9365096bc579d10e417278576d650611105120,
3655b26adf8d3b94095924920d05cc1a16d0f4c0,
b1a8a56c563b85ab9a34d3bbf9c16278dd441157,
92dc415902654c0e69de47205af62b9bb4532809,
8e225c55c49493f00fc9bc0b5809ab026d60c767,
4f09733d28398207bc16ace92cda6e1ffeb99644,
24dcc280c2e442eea27e7129c4c948eb6199ed91,
84ec1dc97d6358bd569d5467cb150abd0fc8939b,
aaf72a7decf6964f00adb871333571de66c166a3,
f9d41ff83655ead37ac6083d7ee43f2c35a346da,
2b6799a3941353444d964c769415937920099b18,
4b3f07fc74089151efeff7a8fdfa9c414a1f0d6a,
8cd02afce972ecaf0e0cf0fe09c610d67d9af9c5,
2bd07ecab6121ebfc8a192243c5c6fb41eb85515,
51e762c5dbe63ac5bdd853945ce6462772e59820,
a1285ac92ded45ab6e9f6c7c98917daf14a4a320,
e675a74d7303f10694e571594538a0462002051f,
5879813db7e5c9485a393cf79473b77be38ad5b3,
876ac8c6111697c8105899889bf794438110bc74,
67f0c3491a4a1966603ace4fe110b7cfc5b64e9c,
ce270081bc0bc8ffa0a7e1e5c04f30b5c1875a84,
79e693e16e2152097c5b27d2d7aaa1763e34f594,
da3806795fe7cf8412249a0fab9934e071a7511e,
91bcbb28733437a7a5fedb16984d4de2fa70b049,
bd1b84dc3b5667c969e6d0277eb40a8e475e149a,
23ba48aa935d3f81e66b65285fa8e7972f94dcfe,
0697489f7455fa078cb454776b98236f18f82dd4,
219eb86fd22805d419667c791af4419cd2b3d00a,
528e3ad00b78f3cc03f27248914249798f2c0aa9,
624d01660bdad4dc924717f4c602ce6241c0c825,
25fd7bd84f1931d2a44e90e629f794c4cd11aa46,
57a2a8613d2595b8650c24ef1cf3bb0055202409,
25aa10c9c12c294ff5998d481a0618193c66b5c2,
c55d727bbe8d66e87497d6c8b6301a767b11bb4c,
3a4e00615b14275e5dac535a304add9e1cf4e4eb,
e0c10fd76b38dea49ad3159fd4690e0ed4b55e1f,
174cf761f7897443080b8a840b649b7eab17ae25,
23d722ee3a7b91bfe5ee6fe64d090ff247e80438,
1e3bc4c3b34eae563547899645bfb3f0a1948c79,
d59833f2223a85a4dc3f4ea597384588d5d008df |
9157d98e4cc5c00d74cef6128c16659ff43f3585 | Author: Jon Meredith <jonmeredith@apache.org>
| 2024-04-25 13:53:28-06:00
Streaming exception race creates corrupt transaction log files that prevent restart
patch by Jon Meredith; reviewed by Caleb Rackliffe, David Capwell for CASSANDRA-18736
6a640b0c4e6e3aecca08c749250e2dfec18063ab | Author: Mohammad Aburadeh <mohmmad_aburadeh@hotmail.com>
| 2024-04-01 19:04:03+00:00
Change logging to TRACE when failing to get peer certificates
Patch by Mohammad Aburadeh; reviewed by brandonwilliams and jonmeredith
for CASSANDRA-19508
b9586501a6b6cdfe465302448018785652c9b966 | Author: Jon Meredith <jonmeredith@apache.org>
| 2023-09-21 16:07:29-06:00
Internode legacy SSL storage port certificate is not hot reloaded on update
patch by Jon Meredith; reviewed by Dinesh Joshi, Francisco Guerrero for CASSANDRA-18681
bde4fa0013eb8cec5b1d88b21ca4463bc07272bb | Author: Jon Meredith <jonmeredith@apache.org>
| 2023-08-28 16:10:41-06:00
Waiting indefinitely on ReceivedMessage response in StreamSession#receive() can cause deadlock
patch by Jon Meredith; reviewed by Caleb Rackliffe, David Capwell for CASSANDRA-18733
6ffa43f68b8d10ca84d4a00bf81269527b4e14df | Author: Francisco Guerrero <frank.guerrero@gmail.com>
| 2023-08-25 11:10:48-06:00
Support Dynamic Port Allocation for in-jvm dtest framework
patch by Francisco Guerrero; reviewed by Dinesh Joshi, Jon Meredith, Yifan Cai for CASSANDRA-18722
b47bee42d3b15020fbae72b173e873fa57c8e0c8 | Author: Andy Tolbert <6889771+tolbertam@users.noreply.github.com>
| 2023-08-18 09:33:57-05:00
Allow empty keystore_password in encryption_options
patch by Andy Tolbert; reviewed by Jon Meredith and Stefan Miklosovic for CASSANDRA-18778
f078c02cb58bddd735490b07548f7352f0eb09aa | Author: jkonisa <jkonisa@apple.com>
| 2023-05-22 22:15:22-07:00
Adding Mutual TLS authenticators for client & internode connections
Patch by Jyothsna Konisa & Dinesh Joshi; reviewed by Yifan Cai, Jon Meredith,
Yuki Morishita & Dinesh Joshi for CASSANDRA-18554
Co-Authored-By: Dinesh Joshi <djoshi@apache.org>
1e3bc4c3b34eae563547899645bfb3f0a1948c79 | Author: Doug Rohrer <doug@therohrers.org>
| 2023-05-18 20:44:43-04:00
Add JMX utility class to in-jvm dtest to ease development of new tests using JMX
While reviewing CASSANDRA-18511, some repetitive code was identified across the 4 branches,
and 2 different tests, that would also be repeated for any new usages of the JMX support
in the in-jvm dtest framework. Therefore, a utility class should be added to the dtest-api's
`shared` package that will simplify some of this repetitive and error-prone code.
patch by Doug Rohrer; reviewed by Jon Meredith, Dinesh Joshi for CASSANDRA-18537
602ffcbf3e4ead4732fdf46d506165f63d80a9a4 | Author: Jon Meredith <jonmeredith@apache.org>
| 2023-05-03 10:27:48-06:00
fix flaky o.a.c.distributed.test.PaxosRepair2Test.paxosRepairHistoryIsntUpdatedInForcedRepair
patch by Jon Meredith; reviewed by Blake Eggleston for CASSANDRA-18047
853ae8c84049be875921a40c9d5924724cc72792 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2023-03-30 13:07:16-05:00
Avoid loading the preferred IP for BulkLoader streaming
patch by Caleb Rackliffe; reviewed by Jon Meredith for CASSANDRA-18370
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: Jon Meredith <jonmeredith@apache.org>
4444721b6de555352bf0ac3ef7e36f94dc832f41 | Author: Natnael Adere <natnael_adere@apple.com>
| 2023-03-24 09:28:37-07:00
Provide summary of failed SessionInfo's in StreamResultFuture
patch by Natnael Adere; reviewed by David Capwell, Dinesh Joshi, Jon Meredith for CASSANDRA-17199
0a0e06847bf10aa88a3a30c239c507a64f949d74 | Author: Kamalesh Palanisamy <kamalesh800@gmail.com>
| 2023-03-03 15:42:06-07:00
org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload fails when running with TrieMemtables
patch by Kamalesh Palanisamy; reviewed by David Capwell, Jon Meredith for CASSANDRA-18144
40f9ca60f103783aa481bc9a91b92fd55b4ea625 | Author: Benedict Elliott Smith <https://benedict@apache.org>
| 2023-03-01 19:08:20-07:00
Improve memtable allocator accounting when updating AtomicBTreePartition
patch by Benedict Elliott Smith; reviewed by Benjamin Lerer, Jon Meredith for CASSANDRA-18125
5be1038c5d38af32d3cbb0545d867f21304f3a46 | Author: David Capwell <dcapwell@apache.org>
| 2023-01-11 13:40:57-08:00
Streaming progress virtual table lock contention can trigger TCP_USER_TIMEOUT and fail streaming
patch by David Capwell; reviewed by Abe Ratnofsky, Jon Meredith for CASSANDRA-18110
22ec7eee7f340e8333055b2b10646cfe00cb6a84 | Author: Josh McKenzie <jmckenzie@apache.org>
| 2022-09-15 12:40:25-04:00
Mitigate direct buffer memory OOM on replacements
Patch by Jon Meredith; reviewed by Josh McKenzie for CASSANDRA-17895
Co-authored-by: Jon Meredith <jonmeredith@apache.org>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
0e855c4b7c157b7ba63bb7377bc441260d76556f | Author: Josh McKenzie <jmckenzie@apache.org>
| 2022-08-22 14:28:50-04:00
Fix potential out of range exception on column index downsampling
Patch by Marcus Eriksson; reviewed by Josh McKenzie, Jon Meredith, and Caleb Rackliffe for CASSANDRA-17839
Co-authored-by: Marcus Eriksson <marcuse@apache.org>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
9ebe0aa08ae616f49983e2800eee190921f2edf3 | Author: Josh McKenzie <jmckenzie@apache.org>
| 2022-08-12 12:43:26-04:00
Replace getStderr calls with getCleanedStderr calls in tests checking for emptiness
Patch by Jon Meredith; reviewed by Josh McKenzie and Berenguer Blasi for CASSANDRA-17815
Co-authored-by: Jon Meredith <jmeredithco@gmail.com>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
7bde2c23abacf60d156de7c444f136dcfe9fe276 | Author: Josh McKenzie <jmckenzie@apache.org>
| 2022-08-12 12:43:26-04:00
Replace getStderr calls with getCleanedStderr calls in tests checking for emptiness
Patch by Jon Meredith; reviewed by Josh McKenzie and Berenguer Blasi for CASSANDRA-17815
Co-authored-by: Jon Meredith <jmeredithco@gmail.com>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
3e0b94565acc64e903d73af3a14b23c875abc5b3 | Author: Josh McKenzie <jmckenzie@apache.org>
| 2022-08-02 16:02:03-04:00
Add support to generate a One-Shot heap dump on unhandled exceptions
Patch by Caleb Rackliffe; reviewed by Josh McKenzie, David Capwell, and Jon Meredith for CASSANDRA-17795
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
fe28f482db0e1bc81936a62d0564e9657f428d2a | Author: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
| 2022-07-27 09:41:44-04:00
Fix sstable_preemptive_open_interval_in_mb disabled value - backward compatibility
patch by Ekaterina Dimitrova; reviewed by Andres de la Pena and Jon Meredith for CASSANDRA-17737
7119cf8be1c32fa6ac015456965ae27a17cd828c | Author: Jyothsna Konisa <jkonisa@apple.com>
| 2022-06-30 09:52:50-07:00
Fix TestGossipingPropertyFileSnitch.test_prefer_local_reconnect_on_listen_address
patch by Jyothsna Konisa; reviewed by Jon Meredith, Yifan Cai for CASSANDRA-17700
5e39c54678b0d70145b5c699593eb9ce7fa7706a | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2022-06-22 17:12:41-06:00
Avoid initializing schema via SystemKeyspace.getPreferredIP() with the BulkLoader tool
patch by Caleb Rackliffe; reviewed by Jon Meredith for CASSANDRA-17740
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: Jon Meredith <jmeredithco@gmail.com>
7da28ef37848d14c0ff4597dfc6e116bd9febce6 | Author: Stefan Miklosovic <smiklosovic@apache.org>
| 2022-06-16 19:26:02+02:00
SSL storage port in sstableloader is deprecated
this is the follow-up commit which deprecates ssl storage port for backward compatibility
patch by Stefan Miklosovic; reviewed by Jon Meredith for CASSANDRA-17602
6247c9d966d7e3886fef0c7486013578407b37e4 | Author: David Capwell <dcapwell@apache.org>
| 2022-06-06 13:42:00-07:00
jvm-dtest upgrade tests run all supported pairs of upgrades between from/to but does not actually test all patches from/to
patch by David Capwell; reviewed by Jon Meredith, Michael Semb Wever for CASSANDRA-17656
ba0555e965699d64099870c0288b31d1a15b2698 | Author: Jon Meredith <https://jonmeredith@apache.org>
| 2022-06-05 15:13:24-06:00
Fix flaky test - org.apache.cassandra.distributed.test.MessageForwardingTest.mutationsForwardedToAllReplicasTest
patch by Jon Meredith; reviewed by David Capwell for CASSANDRA-17583
a00d8fd5ba9d73a377d1a11e6f540c56d66e9c8f | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2022-05-25 17:08:25-05:00
Ensure FileStreamTask cannot compromise shared channel proxy for system table when interrupted
patch by Caleb Rackliffe; reviewed by Jon Meredith and David Capwell for CASSANDRA-17663
ed3901823a5fe9f8838d8b592a1b7703b12e810b | Author: Jyothsna Konisa <jkonisa@apple.com>
| 2022-05-24 10:21:16-07:00
Adding support for TLS client authentication for internode communication
patch by Jyothsna Konisa; reviewed by Bernardo Botella, Francisco Guerrero, Jon Meredith, Maulin Vasavada, Yifan Cai for CASSANDRA-17513
3d9365096bc579d10e417278576d650611105120 | Author: Josh McKenzie <jmckenzie@apache.org>
| 2022-03-23 12:42:36-04:00
Disallow removal of a DC from system_auth replication settings
Patch by Josh McKenzie; reviewed by Jon Meredith for CASSANDRA-17478
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
Co-authored-by: Nachiket Patil <nachiket_patil@apple.com>
94580a272e77439e4150926a1bd1e723a36236e6 | Author: Jon Meredith <jonmeredith@apache.org>
| 2022-03-22 15:14:00-06:00
Test Failure: org.apache.cassandra.db.lifecycle.LogTransactionTest.testGetTemporaryFilesSafeAfterObsoletion-cdc
patch by Jon Meredith; reviewed by Josh McKenzie for CASSANDRA-17286
431c692b884395b16beadac1d10f7e674b3e7ed5 | Author: Jon Meredith <https://jonmeredith@apache.org>
| 2022-03-15 16:17:43-06:00
Failed inbound internode authentication failures generate ugly warning with stack trace
patch by Jon Meredith; reviewed by David Capwell for CASSANDRA-17068
57ab3afcf16970047d3df4656241cf0705e94bee | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2022-03-14 17:13:47-05:00
reduce hot-path object allocations required to record local/remote requests against the client request metrics
patch by Caleb Rackliffe; reviewed by Jon Meredith for CASSANDRA-17424
Co-authored-by: Marcus Eriksson <marcuse@apache.org>
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
9ff28fc717e7926b5cf7c8acc85a35e0cfb43595 | Author: Jon Meredith <https://jonmeredith@apache.org>
| 2022-02-02 17:09:42-07:00
Fixes for intermittent in-JVM dtest failures
patch by Jon Meredith, Caleb Rackliffe, Marcus Eriksson, Benedict Elliott Smith <benedict@apache.org>; reviewed by Caleb Rackliffe for CASSANDRA-17256
92dc415902654c0e69de47205af62b9bb4532809 | Author: Alex Petrov <oleksandr.petrov@gmail.com>
| 2021-10-28 15:35:57-04:00
Tolerate local files in data dir during startup
Patch by Alex Petrov; reviewed by Aleksey Yeschenko, Jon Meredith, and Caleb Rackliffe for CASSANDRA-17082
Co-authored-by: Alex Petrov <oleksandr.petrov@gmail.com>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
8e225c55c49493f00fc9bc0b5809ab026d60c767 | Author: David Capwell <dcapwell@apache.org>
| 2021-10-25 07:28:08-07:00
v4+ protocol did not clean up client warnings, which caused leaking the state
patch by David Capwell; reviewed by Caleb Rackliffe, Jon Meredith, Sam Tunnicliffe for CASSANDRA-17054
4f09733d28398207bc16ace92cda6e1ffeb99644 | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2021-10-07 13:34:26-05:00
Skip remaining bytes in the Envelope buffer when a ProtocolException is thrown to avoid double decoding
patch by Caleb Rackliffe; reviewed by Sam Tunnicliffe and Jon Meredith for CASSANDRA-17026
f9d41ff83655ead37ac6083d7ee43f2c35a346da | Author: Caleb Rackliffe <calebrackliffe@gmail.com>
| 2021-08-24 14:42:24-05:00
Avoid signaling DigestResolver until the minimum number of responses are guaranteed to be visible
patch by Caleb Rackliffe; reviewed by Jon Meredith for CASSANDRA-16883
2b6799a3941353444d964c769415937920099b18 | Author: Alex Petrov <oleksandr.petrov@gmail.com>
| 2021-08-13 12:02:50-04:00
Harden PrunableArrayQueue against Pruner implementations that might throw exceptions
patch by Alex Petrov; reviewed by Caleb Rackliffe and Jon Meredith for CASSANDRA-16866
Co-authored by Alex Petrov <oleksandr.petrov@gmail.com>
Co-authored by Josh McKenzie <jmckenzie@apache.org>
2fba5c80ce7bf71d04c62043ffa1088b9e832d83 | Author: Marcus Eriksson, Jon Meredith <marcuse@apache.org>
| 2021-06-25 22:00:25-07:00
Avoid memoizing the wrong min cluster version during upgrades
patch by Marcus Eriksson, Jon Meredith; reviewed by Brandon Williams, Yifan Cai for CASSANDRA-16759
8cd02afce972ecaf0e0cf0fe09c610d67d9af9c5 | Author: Matt Fleming <matt@codeblueprint.co.uk>
| 2021-05-13 22:12:28+01:00
Spin up SEPWorker threads whenever we grow the number of work permits
authored by Matt Fleming, reviewed by Jon Meredith, Andres de la Pena, Ekaterina Dimitrova for CASSANDRA-16668
b1a8a56c563b85ab9a34d3bbf9c16278dd441157 | Author: Marcus Eriksson <marcuse@apache.org>
| 2021-05-04 09:56:32+02:00
Avoid race in AbstractReplicationStrategy endpoint caching
Patch by marcuse; reviewed by Alex Petrov and Jon Meredith for CASSANDRA-16673
Co-authored-by: Jon Meredith <jonmeredith@apache.org>
6fa5300682fbfcbaaae9d4593a015c18ab34df1f | Author: Jon Meredith <jmeredithco@apple.com>
| 2021-04-20 09:41:05-07:00
Harden internode message resource limit accounting against serialization failures
patch by Jon Meredith; reviewed by Benjamin Lerer, David Capwell for CASSANDRA-16616
51e762c5dbe63ac5bdd853945ce6462772e59820 | Author: David Capwell <dcapwell@apache.org>
| 2021-04-07 11:12:37-07:00
When behind a firewall trunk is not buildable, need to allow overriding URLs
patch by David Capwell; reviewed by Brandon Williams, Jon Meredith, Michael Semb Wever for CASSANDRA-16563
2d80e9904b46474b3a7cc135690c27511a234713 | Author: Jon Meredith <jmeredithco@apple.com>
| 2021-02-11 14:20:57-08:00
Unable to ALTER KEYSPACE while decommissioned/assassinated nodes are in gossip
patch by Jon Meredith; reviewed by Brandon Williams, David Capwell for CASSANDRA-16422
5879813db7e5c9485a393cf79473b77be38ad5b3 | Author: David Capwell <dcapwell@apache.org>
| 2020-12-15 12:11:02-08:00
Cannot replace_address /X because it doesn't exist in gossip
patch by David Capwell; reviewed by Brandon Williams, Jon Meredith, Paulo Motta, Sam Tunnicliffe for CASSANDRA-16213
919a8964a83511d96766c3e53ba603e77bca626c | Author: Jon Meredith <jmeredithco@apple.com>
| 2020-12-02 15:33:36-08:00
Bring back the accepted encryption protocols list as configurable option
patch by Jon Meredith; reviewed by Berenguer Blasi, David Capwell, Dinesh Joshi for CASSANDRA-13325
876ac8c6111697c8105899889bf794438110bc74 | Author: David Capwell <dcapwell@apache.org>
| 2020-12-02 13:35:56-08:00
When a table attempts to clean up metrics, it was cleaning up all global table metrics
patch by David Capwell; reviewed by Jon Meredith, Jordan West, Yifan Cai for CASSANDRA-16095
67f0c3491a4a1966603ace4fe110b7cfc5b64e9c | Author: Alexander Dejanovski <alex@thelastpickle.com>
| 2020-11-17 10:18:22-08:00
SSTableLoader will fail if encryption parameters are used due to CASSANDRA-16144
patch by Alexander Dejanovski; reviewed by David Capwell, Jon Meredith for CASSANDRA-16280
f293376aa8dd315a208ef2f03bdcb7a84dcc675c | Author: Jon Meredith <jmeredithco@apple.com>
| 2020-11-05 12:58:07-08:00
TLS connections to the storage port on a node without server encryption configured causes java.io.IOException accessing missing keystore
patch by Jon Meredith; reviewed by David Capwell, Dinesh Joshi for CASSANDRA-16144
ce270081bc0bc8ffa0a7e1e5c04f30b5c1875a84 | Author: Yifan Cai <yc25code@gmail.com>
| 2020-10-29 10:03:56-07:00
Invalid serialized size for responses caused by increasing message time by 1ms which caused extra bytes in size calculation
patch by Yifan Cai; reviewed by David Capwell, Jon Meredith for CASSANDRA-16103
db5832120f0fe9ad799ca0b5b16bbcf6f7404580 | Author: Jon Meredith <jmeredithco@apple.com>
| 2020-10-22 10:54:55-07:00
In-JVM dtest - modify schema with stopped nodes and use yaml fragments for config
patch by Jon Meredith; reviewed by Alex Petrov, David Capwell, Dinesh Joshi, Yifan Cai for CASSANDRA-16152
91bcbb28733437a7a5fedb16984d4de2fa70b049 | Author: David Capwell <dcapwell@apache.org>
| 2020-09-15 15:16:39-07:00
Add a new jmxtool which can dump what JMX objects exist and diff
patch by David Capwell, Stephen Mallette; reviewed by Berenguer Blasi, Jon Meredith for CASSANDRA-16082
bd1b84dc3b5667c969e6d0277eb40a8e475e149a | Author: David Capwell <dcapwell@apache.org>
| 2020-09-08 16:52:14-07:00
in-jvm dtests should validate Instance#serializeMessage serializeSize matches bytes written
patch by David Capwell; reviewed by Jon Meredith, Blake Eggleston for CASSANDRA-16112
23ba48aa935d3f81e66b65285fa8e7972f94dcfe | Author: David Capwell <dcapwell@apache.org>
| 2020-08-31 11:33:20-07:00
MessageSerializationPropertyTest fails with bytes should not be empty for type org.apache.cassandra.db.marshal.BytesType
patch by David Capwell; reviewed by Jon Meredith, Caleb Rackliffe for CASSANDRA-16086
0697489f7455fa078cb454776b98236f18f82dd4 | Author: David Capwell <dcapwell@apache.org>
| 2020-08-26 14:34:32-07:00
Add test which validates that Message serializedSize(version) == serialize(out, version).length
patch by David Capwell; reviewed by Caleb Rackliffe, Jon Meredith for CASSANDRA-16064
624d01660bdad4dc924717f4c602ce6241c0c825 | Author: David Capwell <dcapwell@apache.org>
| 2020-07-30 17:02:05-07:00
jvm upgrade dtests fail on java 11 caused by bad initialization order of DatabaseDescriptor and FileUtils
patch by David Capwell; reviewed by Jon Meredith, Jordan West for CASSANDRA-16002
57a2a8613d2595b8650c24ef1cf3bb0055202409 | Author: David Capwell <dcapwell@apple.com>
| 2020-07-23 10:31:33-07:00
Fix version parsing logic when upgrading from 3.0
Patch by David Capwell, reviewed by Jon Meredith and brandonwilliams for
CASSANDRA-15973
c230ec9ed07b9077ce8422bce8db4e94d5b644cb | Author: Jon Meredith <jmeredithco@apple.com>
| 2020-06-01 11:52:50-06:00
Include DROPPED_COLUMNS in schema digest computation.
CASSANDRA-11050 introduced dropped columns but excluded it from schema digest computations, with
a comment to include the table in the next major release - 4.0.
The patch now includes DROPPED_COLUMNS in the schema digest computation.
Patch by Jon Meredith; reviewed by Aleksey Yeschenko for CASSANDRA-15843
c4db3f89a9a07c45c78da9b5b3f802a6f8b51531 | Author: Jon Meredith <jmeredithco@apple.com>
| 2020-04-17 14:17:49-06:00
Generate compiler options file to support Java11 in IDEA.
The change to JMX in CASSANDRA-15653 prevents the IDEA project from
compiling under JDK11. This change adds the required compiler flag
when the project is upgraded from Java1.8 to Java11.
Patch by Jon Meredith; Reviewed by Dinesh Joshi for CASSANDRA-15738
7ddfe52d51639817c6c5be86c0c8e317e33620eb | Author: Jon Meredith <jmeredithco@gmail.com>
| 2020-04-10 12:04:40-06:00
Support for replacing logback with alternate logger config (like log4j2)
Not all forks use logback, and there is an (prematurely) closed ticket
indicating that it would be valuable CASSANDRA-13212.
Also had to add 'org.w3c.dom' to the InstanceClassLoader so that
log4j2 could load it's configuration.
Patch by Jon Meredith; reviewed by David Capwell and Alex Petrov for CASSANDRA-15714.
f9ddaf1841147fc284e802739ca42403aa2816ae | Author: Jon Meredith <jmeredithco@apple.com>
| 2020-04-09 16:59:53-06:00
Fix flaky SEPExecutor.changingMaxWorkersMeetsConcurrencyGoalsTest
Thread scheduling is not guaranteed to be fair and having the BusyWork
tasks reschedule itself makes sure there is always more work for
the SEPWorker once it finishes, so it can hog all the CPU if
run with a low number of cores. To randomize the scheduling better,
introduce a second thread that keeps the executor primed with work,
but guarantees a thread switch by waiting on the sempahore.
Also resolves a cleanup bug - the sharedPool was not being shutdown
correctly.
Patch by Jon Meredith; reviewed by David Capwell and Dinesh Joshi for CASSANDRA-15709
678ca3fc29c38b64a110dcf40693aa7840b0585c | Author: Jon Meredith <jmeredithco@gmail.com>
| 2020-04-07 18:58:59-06:00
Update port when reconnecting to pre-4.0 SSL storage
On a failed outbound connection to a node with pending data, recheck
the messaging version before reattempting the connection.
Prior to this change, if the endpoint version was incorrectly set
to 4.0 when the node was running 3.0 with an SSL storage port
the connection would continuously try to reconnect on the wrong port.
The patch also improves some of the log messages to include the
actual port being connected to as well as the canonical endpoint for
the node.
Patch by Jon Meredith & Andy Tolbert; reviewed by Aleksey Yeschenko for
CASSANDRA-15727
Co-authored-by: Jon Meredith <jmeredithco@gmail.com>
Co-authored-by: Andy Tolbert <andy_tolbert@apple.com>
02c6d6540c6ab108b763a639146e74e9f8d0dd40 | Author: Jon Meredith <jmeredithco@apple.com>
| 2020-04-02 15:31:40-06:00
Do not check cdc_raw_directory filesystem space if CDC disabled
On startup, applySimpleConfig checks disk space for cdc_raw_directory
even if cdc_enabled=false. The cdc_raw_directory could be computed
automatically from the cassandra.storagedir property so if that
has been deliberately set to an invalid directory (e.g. to force
explicit configuration of storage paths) then the server will not
start.
Additionally this protects against an NPE while checking storage
space if misconfigured.
Patch by Jon Meredith; Reviewed by Dinesh Joshi for CASSANDRA-15688
02cc5df0ed64ba1e746fdb2662f4442fa308abf4 | Author: Jon Meredith <jmeredithco@apple.com>
| 2019-10-22 09:17:21-06:00
In-JVM DTest: Set correct internode message version for upgrade test
On instance startup, if using mock internode messaging,
find out what version of internode messaging should be used
for other endpoints and configure the messaging service.
Also adds a more helpful diagnostic message when versions are
not supported.
Patch by Jon Meredith; Reviewed by Dinesh Joshi for CASSANDRA-15371
c55d727bbe8d66e87497d6c8b6301a767b11bb4c | Author: David Capwell <dcapwell@gmail.com>
| 2019-09-19 16:23:29-07:00
Fix in-JVM dtest failures on java 11 as the system ClassLoader is not a URLClassLoader as of java 9
Patch by David Capwell, reviewed by Jon Meredith and Alex Petrov for CASSANDRA-15329.
58a5ce14ba80a0a4eeef0f6b18e58d63113e1159 | Author: Jon Meredith <jmeredithco@gmail.com>
| 2019-08-26 15:07:44-06:00
In-JVM DTest: Add network topology and tracing support
In-JVM DTest: readRepairTest - Set read repair query to CL.ALL
The current test relies on the order of nodes returned by the snitch
to include node3, which SimpleSnitch does. With support for other
snitches coming then the test should be able to handle any order
of nodes - so make sure all nodes are present.
In-JVM DTest: remove minimum messaging service calculation
Match change on trunk to resolves issue with trying to call
getMessagingVersion on nodes that are not started. Fixes
mixed version upgrades once all branches are updated.
Patch by Jon Meredith; Reviewed by Dinesh Joshi and Alex Petrov for CASSANDRA-15319
8dcaa12baa97ce870f23ff9045f968f2fa28b2cc | Author: Jon Meredith <jmeredithco@gmail.com>
| 2019-08-15 10:12:06-06:00
Allow instance class loaders to be garbage collected for inJVM dtest
Backport support optional network/gossip test features,
instance generations and subnet support from trunk.
Backport MessageFilter and cluster builder API changes to match
trunk (except for the change in namespace for Verbs).
Add a test for repeatedly creating/tearing down in-JVM dtest
clusters to help find resource leaks.
Change IsolatedExecutor to clean up on an executor with zero
core threads so that it exits sooner enabling GC on the
InstanceClassLoader. Moved classloader close after shutdown to prevent
improve logging when the isolated executor is shutdown.
Update the logback config for dtests to make it obvious
which log threads are for instances vs the main logger.
Disable native library loading until it can be reinstated
(tracked in CASSANDRA-15170).
Shutdown various executors and threads that were
preventing the instance classloader from being unloaded.
Add test-jvm-dtest-some ant target
Patch by Jon Meredith; Reviewed by Alex Petrov and
Benedict Elliott Smith for CASSANDRA-15170
860de83a02f3b7711e842a58a073802b9920a1a1 | Author: Jon Meredith <jmeredithco@gmail.com>
| 2019-07-09 13:50:57-06:00
Enable nodetool/JMX resizing of processing stage executor pool
This patch enables users to resize the thread pools used by the
various processing stages at runtime using nodetool or over JMX.
Changes:
Switch to using idiomatic Java Executor names for thread pool configuration
functions. Deprecate `{get,set}CoreThreads` for `{get,set}CorePoolSize`,
`{get,set}MaximumThreads` for `{get,set}MaximumPoolSize`.
Introduce a new ResizableThreadPool interface used by SEPExecutorMBean and
JMXEnabledThreadPoolExecutorMBean to expose a common interface for setting
thread pool sizes. Replace singled usage of JMXConfigurableThreadPoolExecutor
in repair code with JMXEnabledThreadPoolExecutor as both are now resizable
(since CASSANDRA-5044) and ResizableThreadPool now exporting the same API
over JMX.
Implement {get,set}CorePoolSize and {get,set}MaximumPoolSize for SEPExecutor.
To change the maximum pool size for SEPExecutor, the number of permits
has been changed so that it can go negative if the size of the pool is
reduced. If a SEPWorker discovers the number of permits is negative when
looking for more work it stops.
Add `nodetool getconcurrency` to retrieve the current core and maximum
pool sizes for all of the executor stages and `nodetool setconcurrency`
to change core/maximum pool sizes where permitted.
Update Stage to lazily initialize the executors so that in-JVM dtests
can reference Verbs (which have an associated Stage) in message filtering
without starting up all the executors. Introduce new Stage.execute/submit
convenience functions to avoid needing to lookup the executor first.
Update Stage executors to pass a consumer function that
updates the configuration used to initialize the thread pools. This keeps
the config in sync with changes made over JMX to `org.apache.cassandra.{request,internal}.*`
or via nodetool. Also implement for native transport threads - although
that can currently only be updated by JMX rather than nodetool.
Introduce a new `JMXEnabledSingleThreadedExecutor` for executors
that need to be single threaded for correctness that forbids changing
the core/maximum pool sizes (previously it was possible to set gossip to
run multiple threads over JMX).
Patch by Jon Meredith; reviewed by Benedict Elliot Smith for CASSANDRA-15277
174cf761f7897443080b8a840b649b7eab17ae25 | Author: Dinesh A. Joshi <dinesh.joshi@apple.com>
| 2019-01-28 12:29:46+00:00
Validate token() arguments early instead of throwing NPE at execution
patch by Dinesh Joshi; reviewed by Aleksey Yeschenko and Jon Meredith
for CASSANDRA-14989
d8164c643395e3b6579a2fe6ce6ff0423df2f520 | Author: Jon Meredith <jmeredithco@gmail.com>
| 2018-10-18 09:56:46-06:00
In BufferPool, make allocating thread receive a Chunk.
Prevents a condition where the thread allocating the macro chunk
could have all of the chunks taken from the queue before it
is able to use one.
patch by Jon Meredith; reviewed by Benedict for CASSANDRA-14832